Conversion Checker Issues

[Zacchaeus]

I want them to point to the campaign itself. But thanks. I did notice that if I have the modules loaded, the CC does not list them as an error. But if I unload everything, then they show up. So that's part of where my confusion with the list of issues changing was coming from.

Just removing the @* should do that I think.

[LordEntrails]

Thanks. Once you download it, would you mind editing my post and deleting it?

[LordEntrails]

I'm still seeing inconsistent behavior. (note, this is in 4.4.9)

For instance-
I end up with several issues that are false errors. i.e. when I open the object link, there is no link in the object so it can't be wrong. I've looked into the XML and here's what I see.

In the below instance, the indication is a missing like to a Myconid Sovereign, but as can be seen in the XML, no such link is present.
Object: Goblin War Party (encounter)

Record: Link Target Missing - reference.npcdata.myconidsovereign@DD MM Monster Manual,

battlerandom.id-00003.npclist.id-00001.link,

xml:

            <id-00003>
                <cr type="string">3</cr>
                <exp type="number">600</exp>
                <name type="string">Goblin War Party</name>
                <npclist>
                    <id-00001>
                        <count type="number">2</count>
                        <isidentified type="number">1</isidentified>
                        <link type="windowreference">
                            <class>npc</class>
                            <recordname>npc.id-00031</recordname>
                        </link>
                        <maplink>
                            <id-00001>
                                <imageref type="windowreference">
                                    <class />
                                    <recordname />
                                </imageref>
                                <imagex type="number">0</imagex>
                                <imagey type="number">0</imagey>
                            </id-00001>
                            <id-00002>
                                <imageref type="windowreference">
                                    <class />
                                    <recordname />
                                </imageref>
                                <imagex type="number">0</imagex>
                                <imagey type="number">0</imagey>
                            </id-00002>
                        </maplink>
                        <name type="string">Goblin Warrior</name>
                        <token type="token">tokens/goblin.png@DD MM Monster Manual</token>
                    </id-00001>
                    <id-00007>
                        <count type="number">1</count>
                        <isidentified type="number">1</isidentified>
                        <link type="windowreference">
                            <class>npc</class>
                            <recordname>npc.id-00030</recordname>
                        </link>
                        <maplink>
                            <id-00001>
                                <imageref type="windowreference">
                                    <class />
                                    <recordname />
                                </imageref>
                                <imagex type="number">0</imagex>
                                <imagey type="number">0</imagey>
                            </id-00001>
                        </maplink>
                        <name type="string">Goblin Sargent</name>
                        <token type="token">tokens/goblinboss.png@DD MM Monster Manual</token>
                    </id-00007>
                    <id-00008>
                        <count type="number">4</count>
                        <isidentified type="number">1</isidentified>
                        <link type="windowreference">
                            <class>npc</class>
                            <recordname>npc.id-00184</recordname>
                        </link>
                        <maplink>
                            <id-00001>
                                <imageref type="windowreference">
                                    <class />
                                    <recordname />
                                </imageref>
                                <imagex type="number">0</imagex>
                                <imagey type="number">0</imagey>
                            </id-00001>
                            <id-00002>
                                <imageref type="windowreference">
                                    <class />
                                    <recordname />
                                </imageref>
                                <imagex type="number">0</imagex>
                                <imagey type="number">0</imagey>
                            </id-00002>
                            <id-00003>
                                <imageref type="windowreference">
                                    <class />
                                    <recordname />
                                </imageref>
                                <imagex type="number">0</imagex>
                                <imagey type="number">0</imagey>
                            </id-00003>
                            <id-00004>
                                <imageref type="windowreference">
                                    <class />
                                    <recordname />
                                </imageref>
                                <imagex type="number">0</imagex>
                                <imagey type="number">0</imagey>
                            </id-00004>
                        </maplink>
                        <name type="string">Goblin</name>
                        <token type="token">tokens/goblin.png@DD MM Monster Manual</token>
                    </id-00008>
                </npclist>
            </id-00003>

I think I found what was happening. In this case, it's for a Random Encounter. And I found a different Encounter that had a Myconid Sovereign in it with a bad link. Fix it and it seems to have go away.

edit: I found a similar error with an item template. The error was indicating as being related to a regular item (mace of disruption), but actually was in an item template called scroll of banishment (no idea why it had a item template, I deleted the template to resolve the issue.

Another issue - I found if I test the campaign and have zero modules loaded, I get different results than if I have just the 5E SRD Data module loaded.

And with no modules loaded I get an error about an anonymous link (to a spell from a spell scroll item). I've fixed this issue ultiple times and it keeps coming back. I've even go so far to remove the link completely from the scroll item and the error still comes up. Even after closing and re-opening FG and seeing that their is no link at all in the scroll item.

edit: Finally, whenI export to a module and open the module in a different campaign and run CC on it, I get errors again, mostly (?) the same, but this time some of the anonymous links that worked in the campaign does not work in the module (while some do work).

[Jiminimonka]

I'm still seeing inconsistent behavior.

For instance-
I end up with several issues that are false errors. i.e. when I open the object link, there is no link in the object so it can't be wrong. I've looked into the XML and here's what I see.

In the below instance, the indication is a missing like to a Myconid Sovereign, but as can be seen in the XML, no such link is present.
Object: Goblin War Party (encounter)

Record: Link Target Missing - reference.npcdata.myconidsovereign@DD MM Monster Manual,

battlerandom.id-00003.npclist.id-00001.link,

xml:

            <id-00003>
                <cr type="string">3</cr>
                <exp type="number">600</exp>
                <name type="string">Goblin War Party</name>
                <npclist>
                    <id-00001>
                        <count type="number">2</count>
                        <isidentified type="number">1</isidentified>
                        <link type="windowreference">
                            <class>npc</class>
                            <recordname>npc.id-00031</recordname>
                        </link>
                        <maplink>
                            <id-00001>
                                <imageref type="windowreference">
                                    <class />
                                    <recordname />
                                </imageref>
                                <imagex type="number">0</imagex>
                                <imagey type="number">0</imagey>
                            </id-00001>
                            <id-00002>
                                <imageref type="windowreference">
                                    <class />
                                    <recordname />
                                </imageref>
                                <imagex type="number">0</imagex>
                                <imagey type="number">0</imagey>
                            </id-00002>
                        </maplink>
                        <name type="string">Goblin Warrior</name>
                        <token type="token">tokens/goblin.png@DD MM Monster Manual</token>
                    </id-00001>
                    <id-00007>
                        <count type="number">1</count>
                        <isidentified type="number">1</isidentified>
                        <link type="windowreference">
                            <class>npc</class>
                            <recordname>npc.id-00030</recordname>
                        </link>
                        <maplink>
                            <id-00001>
                                <imageref type="windowreference">
                                    <class />
                                    <recordname />
                                </imageref>
                                <imagex type="number">0</imagex>
                                <imagey type="number">0</imagey>
                            </id-00001>
                        </maplink>
                        <name type="string">Goblin Sargent</name>
                        <token type="token">tokens/goblinboss.png@DD MM Monster Manual</token>
                    </id-00007>
                    <id-00008>
                        <count type="number">4</count>
                        <isidentified type="number">1</isidentified>
                        <link type="windowreference">
                            <class>npc</class>
                            <recordname>npc.id-00184</recordname>
                        </link>
                        <maplink>
                            <id-00001>
                                <imageref type="windowreference">
                                    <class />
                                    <recordname />
                                </imageref>
                                <imagex type="number">0</imagex>
                                <imagey type="number">0</imagey>
                            </id-00001>
                            <id-00002>
                                <imageref type="windowreference">
                                    <class />
                                    <recordname />
                                </imageref>
                                <imagex type="number">0</imagex>
                                <imagey type="number">0</imagey>
                            </id-00002>
                            <id-00003>
                                <imageref type="windowreference">
                                    <class />
                                    <recordname />
                                </imageref>
                                <imagex type="number">0</imagex>
                                <imagey type="number">0</imagey>
                            </id-00003>
                            <id-00004>
                                <imageref type="windowreference">
                                    <class />
                                    <recordname />
                                </imageref>
                                <imagex type="number">0</imagex>
                                <imagey type="number">0</imagey>
                            </id-00004>
                        </maplink>
                        <name type="string">Goblin</name>
                        <token type="token">tokens/goblin.png@DD MM Monster Manual</token>
                    </id-00008>
                </npclist>
            </id-00003>

I think I found what was happening. In this case, it's for a Random Encounter. And I found a different Encounter that had a Myconid Sovereign in it with a bad link. Fix it and it seems to have go away.

Another issue - I found if I test the campaign and have zero modules loaded, I get different results than if I have just the 5E SRD Data module loaded.

And with no modules loaded I get an error about an anonymous link (to a spell from a spell scroll item). I've fixed this issue ultiple times and it keeps coming back. I've even go so far to remove the link completely from the scroll item and the error still comes up. Even after closing and re-opening FG and seeing that their is no link at all in the scroll item.

It's always doing this, helpful for finding some mistakes but inconsistent is being lenient.

[superteddy57]

I'm still seeing inconsistent behavior. (note, this is in 4.4.9)

For instance-
I end up with several issues that are false errors. i.e. when I open the object link, there is no link in the object so it can't be wrong. I've looked into the XML and here's what I see.

In the below instance, the indication is a missing like to a Myconid Sovereign, but as can be seen in the XML, no such link is present.
Object: Goblin War Party (encounter)

Record: Link Target Missing - reference.npcdata.myconidsovereign@DD MM Monster Manual,

battlerandom.id-00003.npclist.id-00001.link,

xml:

            <id-00003>
                <cr type="string">3</cr>
                <exp type="number">600</exp>
                <name type="string">Goblin War Party</name>
                <npclist>
                    <id-00001>
                        <count type="number">2</count>
                        <isidentified type="number">1</isidentified>
                        <link type="windowreference">
                            <class>npc</class>
                            <recordname>npc.id-00031</recordname>
                        </link>
                        <maplink>
                            <id-00001>
                                <imageref type="windowreference">
                                    <class />
                                    <recordname />
                                </imageref>
                                <imagex type="number">0</imagex>
                                <imagey type="number">0</imagey>
                            </id-00001>
                            <id-00002>
                                <imageref type="windowreference">
                                    <class />
                                    <recordname />
                                </imageref>
                                <imagex type="number">0</imagex>
                                <imagey type="number">0</imagey>
                            </id-00002>
                        </maplink>
                        <name type="string">Goblin Warrior</name>
                        <token type="token">tokens/goblin.png@DD MM Monster Manual</token>
                    </id-00001>
                    <id-00007>
                        <count type="number">1</count>
                        <isidentified type="number">1</isidentified>
                        <link type="windowreference">
                            <class>npc</class>
                            <recordname>npc.id-00030</recordname>
                        </link>
                        <maplink>
                            <id-00001>
                                <imageref type="windowreference">
                                    <class />
                                    <recordname />
                                </imageref>
                                <imagex type="number">0</imagex>
                                <imagey type="number">0</imagey>
                            </id-00001>
                        </maplink>
                        <name type="string">Goblin Sargent</name>
                        <token type="token">tokens/goblinboss.png@DD MM Monster Manual</token>
                    </id-00007>
                    <id-00008>
                        <count type="number">4</count>
                        <isidentified type="number">1</isidentified>
                        <link type="windowreference">
                            <class>npc</class>
                            <recordname>npc.id-00184</recordname>
                        </link>
                        <maplink>
                            <id-00001>
                                <imageref type="windowreference">
                                    <class />
                                    <recordname />
                                </imageref>
                                <imagex type="number">0</imagex>
                                <imagey type="number">0</imagey>
                            </id-00001>
                            <id-00002>
                                <imageref type="windowreference">
                                    <class />
                                    <recordname />
                                </imageref>
                                <imagex type="number">0</imagex>
                                <imagey type="number">0</imagey>
                            </id-00002>
                            <id-00003>
                                <imageref type="windowreference">
                                    <class />
                                    <recordname />
                                </imageref>
                                <imagex type="number">0</imagex>
                                <imagey type="number">0</imagey>
                            </id-00003>
                            <id-00004>
                                <imageref type="windowreference">
                                    <class />
                                    <recordname />
                                </imageref>
                                <imagex type="number">0</imagex>
                                <imagey type="number">0</imagey>
                            </id-00004>
                        </maplink>
                        <name type="string">Goblin</name>
                        <token type="token">tokens/goblin.png@DD MM Monster Manual</token>
                    </id-00008>
                </npclist>
            </id-00003>

I think I found what was happening. In this case, it's for a Random Encounter. And I found a different Encounter that had a Myconid Sovereign in it with a bad link. Fix it and it seems to have go away.

edit: I found a similar error with an item template. The error was indicating as being related to a regular item (mace of disruption), but actually was in an item template called scroll of banishment (no idea why it had a item template, I deleted the template to resolve the issue.

Another issue - I found if I test the campaign and have zero modules loaded, I get different results than if I have just the 5E SRD Data module loaded.

And with no modules loaded I get an error about an anonymous link (to a spell from a spell scroll item). I've fixed this issue ultiple times and it keeps coming back. I've even go so far to remove the link completely from the scroll item and the error still comes up. Even after closing and re-opening FG and seeing that their is no link at all in the scroll item.

edit: Finally, whenI export to a module and open the module in a different campaign and run CC on it, I get errors again, mostly (?) the same, but this time some of the anonymous links that worked in the campaign does not work in the module (while some do work).

Can you zip up that campaign and send me a pm with a link to download? I need something to test against to check on this.

[superteddy57]

I've gone through with Moon and a further expansion of the tool should sort a few things we are seeing. Wildcard links will be separated out and some of the dynamically made windowlists won't be shown as they show up as false positives. An update will be pushed when it is ready.

[LordEntrails]

Thank you so much!

[superteddy57]

This should now be pushed LIVE

[LordEntrails]

Thank you No more inconsistencies, it seems to be working as expected. I also appreciate breaking out the anonymous links.

I will note that the removal of the link to the anonymous items does make it harder to track down the anon link, esp since the item only has the xml ID and not the UI name. Somethign to think about next time you are updating it, but nothing to worry about now.

[superteddy57]

Something to look at for sure next time.