Generic Actions extension for Fantasy Grounds Unity 5E ruleset

[vaughnlannister]

Hi Silentruin, not sure if you noticed, however unfortunatley the latest FGU update afflicts your extension, I get an error message "Unable to find extension".
While the extension is still in my extension folder.

Thank you for taking a look!

[SilentRuin]

Hi Silentruin, not sure if you noticed, however unfortunatley the latest FGU update afflicts your extension, I get an error message "Unable to find extension".
While the extension is still in my extension folder.

Thank you for taking a look!

Yeah THANK you for confirming I'm not the only one seeing this. It's literally for every extension I get these errors. At least the one's I run which include Death Indicator. Please note in this thread that you have also seen this with this update. I have no idea what is going on.

[mattekure]

I tried it out and dug into your extension. The error is because your XML files have comments between the <xml declaration at the top and the <root tag. If you take out any comments between those, the extension loads just fine. This is due to the FGUnity xml parser being much more strict than the one from FG Classic. Classic allowed a number of things which are really bad xml, and just ignored it. Unity doesnt allow them.

If you want to include comments, just do it right after the opening <root tag. so they would look like.

<?xml version="1.0" encoding="iso-8859-1"?>
<root>
<!--
comments
-->
<whatever code>

[SilentRuin]

I tried it out and dug into your extension. The error is because your XML files have comments between the <xml declaration at the top and the <root tag. If you take out any comments between those, the extension loads just fine. This is due to the FGUnity xml parser being much more strict than the one from FG Classic. Classic allowed a number of things which are really bad xml, and just ignored it. Unity doesnt allow them.

If you want to include comments, just do it right after the opening <root tag. so they would look like.

<?xml version="1.0" encoding="iso-8859-1"?>
<root>
<!--
comments
-->
<whatever code>

So the most recent update just killed it now? Ok - I can fix all that I guess. Let me give it a try. So 4 extensions I have to fix. Wondrous. Thanks much for the news. Please post that in this other thread.

[SilentRuin]

I tried it out and dug into your extension. The error is because your XML files have comments between the <xml declaration at the top and the <root tag. If you take out any comments between those, the extension loads just fine. This is due to the FGUnity xml parser being much more strict than the one from FG Classic. Classic allowed a number of things which are really bad xml, and just ignored it. Unity doesnt allow them.

If you want to include comments, just do it right after the opening <root tag. so they would look like.

<?xml version="1.0" encoding="iso-8859-1"?>
<root>
<!--
comments
-->
<whatever code>

Let me make absolutely sure on this - your talking about where I started with Death Indicator and they had comments in all there XML's with something like this...

<!--
	File: record_char.xml
  	Author: Cleveland E. Raymond (Valerian Stormbreaker)
	Copyright © 2019 Slotware Gaming Technologies LLC. All Rights Reserved.
-->

And I need to move that down into the root correct? Because I did copy that format assuming it was the way to go in ALL my xml files. Just want to make sure I'm understanding you correctly.

[mattekure]

Yes, this

<?xml version="1.0" encoding="iso-8859-1"?>

<!--
	File: extension.xml
	Author: Cleveland E. Raymond (Valerian Stormbreaker)
	Copyright © 2019 Slotware Gaming Technologies LLC. All Rights Reserved.
	
	Modified 2020 SilentRuin
-->


<root version="3.0">

Should look like this:

<?xml version="1.0" encoding="iso-8859-1"?>
<root version="3.0">
<!--
	File: extension.xml
	Author: Cleveland E. Raymond (Valerian Stormbreaker)
	Copyright © 2019 Slotware Gaming Technologies LLC. All Rights Reserved.
	
	Modified 2020 SilentRuin
-->

[SilentRuin]

Yes, this

<?xml version="1.0" encoding="iso-8859-1"?>

<!--
	File: extension.xml
	Author: Cleveland E. Raymond (Valerian Stormbreaker)
	Copyright © 2019 Slotware Gaming Technologies LLC. All Rights Reserved.
	
	Modified 2020 SilentRuin
-->


<root version="3.0">

Should look like this:

<?xml version="1.0" encoding="iso-8859-1"?>
<root version="3.0">
<!--
	File: extension.xml
	Author: Cleveland E. Raymond (Valerian Stormbreaker)
	Copyright © 2019 Slotware Gaming Technologies LLC. All Rights Reserved.
	
	Modified 2020 SilentRuin
-->

Well crap - just moved all those in death indicator of which there are a bunch - and the same error popped up. Let me double check I did not miss one. You sure you had a failing version and fixed it right?

[mattekure]

Yes. I downloaded the most recent death indicator. stripped out the comments. and it loads fine in unity.



I've attached my version here.

[SilentRuin]

Yes. I downloaded the most recent death indicator. stripped out the comments. and it loads fine in unity.



I've attached my version here.

Stripped OUT the comments. That's different than moving them under the root. I actually have another extension with comments between xml and root that is not giving this error. And when I moved them under root (like you did not) I still get the error.

Something is still weird here. I'm beginning to think there is a special char that's been copied around from the original comments or something.

[mattekure]

thats certainly possible. I know I ran into the issue of comments between <xml and <root before, which is where my suggestion came from. And stripping those comments has worked for both extensions I tested. perhaps the copyright character or something else is causing FG to treat the xml file as invalid.