Better Menus (CoreRPG, 5E/etc)

[jkeller]

Hi - I had a request to make one of my extensions compatible with Better Menus. I added the addMenuItem call like this:

function onTabletopInit()
   if Session.IsHost then
      local tButton = { sIcon = "FF_Icon", tooltipres = "FF_title", class = "fishing_tournament_window", path = DB_ROOT };
      DesktopManager.registerSidebarToolButton(tButton, 8);

      if MenuManager then
         MenuManager.addMenuItem("fishing_tournament_window", DB_ROOT, "Open the Fishing Fun UI", "Fishing Fun");
      end
   end
end

It works, but it ends up adding two menu entries. Did I do something wrong?

menus-issue.png

Not sure if it matters, but this is for 5E.

[celestian]

Hi - I had a request to make one of my extensions compatible with Better Menus. I added the addMenuItem call like this:
It works, but it ends up adding two menu entries. Did I do something wrong?

menus-issue.png

Not sure if it matters, but this is for 5E.

Try not adding it and see what happens. It looks like it detected a menu and added it and then you're adding it again.

[jkeller]

If I don't call it, I get no menus. If I call it, I get both. When selected, both open my window.

[celestian]

Even if the code is just...

function onTabletopInit()
   if Session.IsHost then
      local tButton = { sIcon = "FF_Icon", tooltipres = "FF_title", class = "fishing_tournament_window", path = DB_ROOT };
      DesktopManager.registerSidebarToolButton(tButton, 8);
   end
end

DesktopManager.registerSidebarToolButton internally adds the button record to Desktop.aCoreDesktopDockV4["live"]. BetterMenus' createMenuSelections() automatically iterates that exact list to populate the dropdown.

I expect if you use one or the other it'll be there just once.

[jkeller]

If I just use registerSidebarToolButton, then I don't see it in the menu. All I did was comment-out the addMenuItem call.

if I have both, I see the 2 menu items.

Anything else I could try?

[celestian]

Sorry, nothing comes to mind immediately and im not home to dig deeper into the code for a week. I was certain it would be the discovery bit.

The other option is try...

function onTabletopInit()
   if Session.IsHost then
      if MenuManager then
         MenuManager.addMenuItem("fishing_tournament_window", DB_ROOT, "Open the Fishing Fun UI", "Fishing Fun");
      end
   end
end

[jkeller]

Thanks for the responses. That works fine as long as I have Better Menus. But if not, then of course it doesn't show up in the sidebar. That's not really an option.

I can use if/else; it does what I want as long as Better Menus loads first. Do you specify a load order? I typically don't for mine (which I think means it defaults to 50).

function onTabletopInit()
   if MenuManager then
      MenuManager.addMenuItem(EXT_UI, DB_ROOT, "Open the Boar Riding (festival event) UI", "Boar Riding");
   else
      local tButton = { sIcon = "BR_Icon", tooltipres = "BR_title", class = EXT_UI, path = DB_ROOT };
      DesktopManager.registerSidebarToolButton(tButton, 8);
   end
end

[celestian]

It loads last, 999 I believe.

[jkeller]

I think it might work as long as I do it in onTabletopInit, not onInit.