Fantasy Grounds Merchandise
Page 32 of 52 First ... 22 30 31 32 33 34 42 ... Last
  1. #311
    Quote Originally Posted by JustinFreitas View Post
    Yeah, in my branch to maintain FGC compatibility, I changed those to be defaults set in options. Sorry if there was anything accidentally pulled in from my branch.
    So we can set them in the options now? That would work as well. My experience is that they reset to zero each load. I will have to take a look.

  2. #312
    MrDDT's Avatar
    Join Date
    Nov 2018
    Location
    Disney World, FL
    Posts
    2,046
    Quote Originally Posted by bmos View Post
    To make it more obvious since the chat messages are easy to miss?
    Exactly, as a DM you have a lot of stuff going on and might miss it. But pop ups are hard to miss.
    -MrDDT
    Discord @mrddt
    Grim Press Discord (Publishing/Extensions/Modules)
    Bethica Discord (West Marches RPG)

    PLEASE VOTE FOR THESE FEATURES VERY IMPORTANT!!!

  3. #313
    Quote Originally Posted by JustinFreitas View Post
    Yeah, in my branch to maintain FGC compatibility, I changed those to be defaults set in options. Sorry if there was anything accidentally pulled in from my branch.
    ah! that's what that was about.
    Looks like the options themselves didn't come over. nephranka/anyone, do you have a preference between fields that hold onto their numbers or a default in options?

  4. #314
    Quote Originally Posted by bmos View Post
    ah! that's what that was about.
    Looks like the options themselves didn't come over. nephranka/anyone, do you have a preference between fields that hold onto their numbers or a default in options?
    I think the long/short rest time fields stay set to the last entry so it would make sense the adj hours/mins fields behave the same way. That said if they all are options or all use "stay set" works equally well for me.

    Edit: So in the new version the long/short rest time field are now not saved as well. I see now what is going on. So either as options or last set fields works for me.
    Last edited by nephranka; March 15th, 2022 at 22:28.

  5. #315
    The reason I did options in my FGC branch is because I usually always have my long/short rest the same at 8hr / 60min. I tried a 'last used' implementation but ended up back at options in the end. If you need me to look at anything when you pull whatever in, just add me as a reviewer to the PR and I'll give it a look!

  6. #316
    Justin posted a pull request to re-enable saving those values (both methods actually, very generous -- i went with the 'last used' method) and I made a few more improvements to clean things up.
    https://www.fantasygrounds.com/forum...l=1#post608785

  7. #317
    Quote Originally Posted by bmos View Post
    Justin posted a pull request to re-enable saving those values (both methods actually, very generous -- i went with the 'last used' method) and I made a few more improvements to clean things up.
    https://www.fantasygrounds.com/forum...l=1#post608785
    I just happen to be here and saw this. When I follow the link and click the ext to download, I get:
    "Invalid Attachment specified. If you followed a valid link, please notify the administrator"

  8. #318
    Quote Originally Posted by nephranka View Post
    I just happen to be here and saw this. When I follow the link and click the ext to download, I get:
    "Invalid Attachment specified. If you followed a valid link, please notify the administrator"
    Link works for me but I’m just on my phone right now and haven’t made it to my computer today. I’ll try it there in a few minutes.

  9. #319
    Just tried again and it downloaded. All good. Thanks for this update!

  10. #320
    Quote Originally Posted by JustinFreitas View Post
    Link works for me but I’m just on my phone right now and haven’t made it to my computer today. I’ll try it there in a few minutes.
    Yeah, it's working on the desktop too. That's weird, nephranka. Maybe try again from an Incognito tab or something?

    Edit: Ah, it's fixed. Nice!

Page 32 of 52 First ... 22 30 31 32 33 34 42 ... Last

Thread Information

Users Browsing this Thread

There are currently 2 users browsing this thread. (0 members and 2 guests)

Bookmarks

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
Starfinder Playlist

Log in

Log in