Kelrugem's extensions

[rmilmine]

Oh, I just realized that I forgot to add that in my last reupload I wrote it now on some list for the next upload (together with other things like the bypass damage types), so, hopefully I won't forget that in the next time Sorry

The way I did it was as follows: I added the following code to manager_action_attack.lua around line 514.

	elseif nDefenseVal then
		-- The following was added or changed to allow for a defenders AC to be increased for any crit confirmation roll.
		local nACCCMod, nACCCCount = EffectManager35E.getEffectsBonus(rTarget, {"ACCC"}, true, aAttackFilter, rSource);
		if nACCCMod == nil then
			nACCCMod = 0
		end
		if (rRoll.sType ~= "critconfirm" and rAction.nTotal >= nDefenseVal) or (rRoll.sType == "critconfirm" and rAction.nTotal >= nDefenseVal + nACCCMod) then

I'm sure there is a better way to do it, such as pull the ACCC mod out earlier, but not really sure where best to put it in the code.

[Kelrugem]

The way I did it was as follows: I added the following code to manager_action_attack.lua around line 514.

    elseif nDefenseVal then
        -- The following was added or changed to allow for a defenders AC to be increased for any crit confirmation roll.
        local nACCCMod, nACCCCount = EffectManager35E.getEffectsBonus(rTarget, {"ACCC"}, true, aAttackFilter, rSource);
        if nACCCMod == nil then
            nACCCMod = 0
        end
        if (rRoll.sType ~= "critconfirm" and rAction.nTotal >= nDefenseVal) or (rRoll.sType == "critconfirm" and rAction.nTotal >= nDefenseVal + nACCCMod) then

I'm sure there is a better way to do it, such as pull the ACCC mod out earlier, but not really sure where best to put it in the code.

thanks Yes, that I would also have suggested, but I will adjust it a bit because right now it would stack with AC bonus even when the bonus types would not stack

[rmilmine]

There would be circumstances where it would stack though.

https://www.d20pfsrd.com/classes/cor.../armored-hulk/

The Resilience of Steel ability from above doesn't give any stacking type and so would stack with everything.
This of course is why I made it as I'm playing an armored hulk. lol

[Kelrugem]

There would be circumstances where it would stack though.

https://www.d20pfsrd.com/classes/cor.../armored-hulk/

The Resilience of Steel ability from above doesn't give any stacking type and so would stack with everything.
This of course is why I made it as I'm playing an armored hulk. lol

Oki, this is a untyped bonus, then it doesn't matter, indeed But who knows, there is maybe some typed bonus running around (though such effects like ACCC are rare )

[rmilmine]

Oki, this is a untyped bonus, then it doesn't matter, indeed But who knows, there is maybe some typed bonus running around (though such effects like ACCC are rare )

Always better with more options. Never know when you might need them. lol
If it isn't broke it doesn't have enough options.

[Kelrugem]

Always better with more options. Never know when you might need them. lol
If it isn't broke it doesn't have enough options.

hehe

Thanks again for the code, whenever I have time again (also for adding some other requests) then I will add and adjust it a bit, and I will name you and your name gets added to the extensions then, too

[rmilmine]

No worries about naming me. I have a question though. Is there a way to denote on a weapon that the damage is for crits only? That is to say the damage only happens if a critical is scored.
I'm thinking it would be nice to be able to add items with like flaming burst directly to the weapon instead of as an effect.

[Kelrugem]

No worries about naming me. I have a question though. Is there a way to denote on a weapon that the damage is for crits only? That is to say the damage only happens if a critical is scored.
I'm thinking it would be nice to be able to add items with like flaming burst directly to the weapon instead of as an effect.

yup, the damage type critical is doing that, but only works in effects as far as I know when you just add an additonal damage die in the weapon entry with that damage type then it will be always rolled; but DMG effects with that damage type will only be triggered on crits then Like DMG: d10 fire, critical; I want to convert the advanced effects extension of Celestian (5e), there it is possible to add effects which only work with a specific weapon to avoid that such effects have to be turned off for other weapons

And of course I will name you

[rmilmine]

yup, the damage type critical is doing that, but only works in effects as far as I know when you just add an additonal damage die in the weapon entry with that damage type then it will be always rolled; but DMG effects with that damage type will only be triggered on crits then Like DMG: d10 fire, critical; I want to convert the advanced effects extension of Celestian (5e), there it is possible to add effects which only work with a specific weapon to avoid that such effects have to be turned off for other weapons

And of course I will name you

I actually have a semi working version of his code. The basics work as does the interface. The code for dynamically applying effects doesn't work yet.

[Kelrugem]

I actually have a semi working version of his code. The basics work as does the interface. The code for dynamically applying effects doesn't work yet.

Nice Yeah, many things of that directly work, but the effects stuff has to be exchanged due to that the effects manager are different, and it might be incompatible with my extensions, such that I will probably only upload a very big extension of that and my extensions (at some point in the far future; I sadly have no time to mess with such big projects now )