5e Reactions

Hey,

I'm trying to make this extension work for the "Parry" and "Riposte" Combat Superiority maneuvers, but I must be doing something wrong.

I've read the instructions on the Forge, but could please guide me through each step, since I'm definitely missing some of it.

Thank you in advance

Quote:

---

Originally Posted by Stv

It's still on my todo list, promise :D

---

Any movement on this? Thanks for all the effort.

Hi guys,
I've not had much time to devote to my extensions recently, so nothing much has been done.
I still plan to revisit this one and see what can be done. Hopefully in the not too distant future.

Cheers, Steve.

Checking back in. I finally got my players to use the shift button for OA anticipating the ext will check the reaction off for me :)

Just pushed version 1.2. Give that a shot @Nephranka and let me know if it works :P

Cheers, Steve.

Quote:

---

Originally Posted by Stv

Just pushed version 1.2. Give that a shot @Nephranka and let me know if it works :P

Cheers, Steve.

---

Stv is on a roll! This appears to be working for me (with all 100+ extensions loaded)

Looks good. I play sat, so I report back. Thank you.

Sad to report but we have a conflict with BCEG. The bug only happens on the client side. No conflicts as the host. When players use the shift the chat indicates OA but no check off in the CT.

My test as host showed nothing but once I logged into the host as a player it would not work for the player.



Edit: This is happening with only reactions loaded. Client side will not trigger the check mark.

I think I know why this is happening, stupidity on my part. I'll hopefully get a chance to fix it tomorrow.

Thanks for testing !!

Cheers, Steve.

Sounds good.

Just pushed a new build.
Opportunity attacks should hopefully be being flagged when a client machine triggers them, as well as the DM machine.

Try it out and lemme know :)

Cheers, Steve.

Quote:

---

Originally Posted by Stv

Just pushed a new build.
Opportunity attacks should hopefully be being flagged when a client machine triggers them, as well as the DM machine.

Try it out and lemme know :)

Cheers, Steve.

---

Looks to have fixed it. Thanks!

Quote:

---

Originally Posted by Stv

Just pushed a new build.
Opportunity attacks should hopefully be being flagged when a client machine triggers them, as well as the DM machine.

Try it out and lemme know :)

Cheers, Steve.

---

Worked great on both GM and Client sides tonight. Thanks much!!

Hi there. I'm looking for guidance on how to set this up to use with Riposte. I've read and re-read the instructions on the Forge page and am still a little lost. Here's what my Combat Superiority power group looks like:


Attachment 63735

Hi sdclarknc,
I've not looked at this extension for a very long time, so had to refamiliarise myself with hiow it works :P
Firstly, 'Riposte' needs to be added as a feature on the character, then the effect groups need setting up. I've attached a couple of screenshots which show how it's done.
Hope this helps.

Cheers, Steve.Attachment 63736Attachment 63737

Thank you so much. This is very helpful.

Cheers to you.

Hello Stv,

we hit an incompatibility of this extension with Automatic Mirror Image (tested with only those two loaded). I suspect there is a function overwrite which prevents the other extension to work. Error only occurs when a mage has Shield spell and applied Mirror Image to himself and it is checked if an image is hit instead of the mage. No output from 5e Reactions but image is correctly removed and the following error occurs:

Code:

---

[ERROR] Script execution error: [string: "5e Reactions:scripts/reactions.lua"]:78 bad argument #1 to 'match' (string expected, got nil).

---

Unfortunately, the other extension is in the vault so I cannot trace further - perhaps you can check with Kent McCullough what he is doing with rRoll.sResult which seems to be empty in the strings.match call.

Quote:

---

Originally Posted by Arnagus

Hello Stv,

we hit an incompatibility of this extension with Automatic Mirror Image (tested with only those two loaded). I suspect there is a function overwrite which prevents the other extension to work. Error only occurs when a mage has Shield spell and applied Mirror Image to himself and it is checked if an image is hit instead of the mage. No output from 5e Reactions but image is correctly removed and the following error occurs:

Code:

---

[ERROR] Script execution error: [string: "5e Reactions:scripts/reactions.lua"]:78 bad argument #1 to 'match' (string expected, got nil).

---

Unfortunately, the other extension is in the vault so I cannot trace further - perhaps you can check with Kent McCullough what he is doing with rRoll.sResult which seems to be empty in the strings.match call.

---

This likely should be fixes on Kent's side as he needs to send a string and not another way, this would correctly better link into other features of other EXTs and is the better passing of the information.

They could put a nil check but it would end up not having all the information they need for a roll result. I believe we had the same issue for Rolling Mirror ext and added that in. The issue will also come up with other EXTs that need the string info like Requested Rolls (suppressed dice feature).

@MrDDT has it right I think. You may want to reach out to @kentmccullough. I'll try and add in a nil check in the next day or so to suppress the error meantime, but it's a bit of a cludge fix tbh.

Cheers, STeve.

Quote:

---

Originally Posted by Stv

@MrDDT has it right I think. You may want to reach out to @kentmccullough.

---

Already done on his Discord channel. He is looking into it as he planned an update for 2024 rules for this very extension.

Quote:

---

Originally Posted by Stv

@MrDDT has it right I think. You may want to reach out to @kentmccullough. I'll try and add in a nil check in the next day or so to suppress the error meantime, but it's a bit of a cludge fix tbh.

Cheers, STeve.

---

I've done a fix, part of the fix is just sending an empty string in that field when it's nil due to mirror images needing to negate the original attack role. The other part is making sure mirror images load after reactions that way when I do negate the original attack roll, but still need to process it (images bypassed) reactions will properly pickup after.

Quote:

---

Originally Posted by kentmccullough

The other part is making sure mirror images load after reactions that way when I do negate the original attack roll, but still need to process it (images bypassed) reactions will properly pickup after.

---

Many thanks! Just to understand: this allows a Shield (or other) reaction if the original character is hit (instead of a mirror image), correct? This is awesome!

Quote:

---

Originally Posted by kentmccullough

I've done a fix, part of the fix is just sending an empty string in that field when it's nil due to mirror images needing to negate the original attack role. The other part is making sure mirror images load after reactions that way when I do negate the original attack roll, but still need to process it (images bypassed) reactions will properly pickup after.

---

Nice job on the fix, thanks for your time.

Cheers, Steve.

Looks like something stop working. I used the (RCT) code and it is not checking the reaction.

Quote:

---

Originally Posted by nephranka

Looks like something stop working. I used the (RCT) code and it is not checking the reaction.

---

Yup, I think you're right. I'll try and get a look into it this week.

Thanks for the heads up. :)

Quote:

---

Originally Posted by Stv

Yup, I think you're right. I'll try and get a look into it this week.

Thanks for the heads up. :)

---

Thanks!

Guess I missed something in an update, but it looks like the EffectManager.addEffect function is no longer being called when an effect is added to a player in the CT. I think I've found a different function to hook into that exposes the data I need.
I will hopefully post a fix tomorrow.

Cheers,
Steve.

Quote:

---

Originally Posted by Stv

Guess I missed something in an update, but it looks like the EffectManager.addEffect function is no longer being called when an effect is added to a player in the CT. I think I've found a different function to hook into that exposes the data I need.
I will hopefully post a fix tomorrow.

Cheers,
Steve.

---

Sweet

@Nephranka,
I just pushed a (hopefully) fixed build. Give it a try and let me know if it's still broken/broken something else :P

Cheers,
Steve.

Happy to report it is working in both LIVE and TEST now. Thanks!

Awesome, Thanks for the feedback and testing :)

Your extension is broken as PCS or NPCs add effects, adding the effect does not show on the chat display. Also it slows it down the game because of this. I just wanted to alert you and also my players and I love this extension as it reminds them of reactions to use!

Hi @charros,
Can you let me know what other extensions you're using as it seems to be working fine for me.

Thanks,
Stv

Tactical dot . :)

Hi!

There seems to be a conflict between this extension and one of mine (Special Damage Options). I tested with just these two.

Mine listens for onEffectAdd events ("chaining" itself in case there are other listeners), but it doesn't get called if this extension is enabled.

Code:

---

function registerHandlers()
  GameManager_OnEffectAdd = GameManager.getFunction("onEffectAdd");
  GameManager.addEventFunction("onEffectAdd", onEffectAdd);
end

function onEffectAdd(rActor, nodeEffect, tData)
  if GameManager_OnEffectAdd then GameManager_OnEffectAdd(rActor, nodeEffect, tData); end -- call super
  if not SpecialDamageEffects.isEnabled() then return; end
  . . .
end

---

I assume it's something to do with how you override onEffectAddMain, but I'm not sure. It also seems questionable that you may return before calling the function you overrode, but I don't think that's causing the issue, since my PC's reaction has not been used.

Code:

---

function newonEffectAddMain(rActor, rEffect)
-- Check to see if the new effect contains "(RCT)"
        if checkeffectforreaction(rEffect) then
        --Ensure that we have a valid Source (stored as a string)
                local sSource
                        sSource=rActor.sCTNode
        --Check to see if the effect source character already has its reaction flag set
        --if so, notify that it can't use a reaction and exit the whole function
                if reactionused(sSource) ==1 then
                        messagereactionused(rEffect.sName,sSource)
                        return
                else
        --Set the effect sources reaction flag
                        DB.setValue(sSource..".reaction","number",1)
                end
        end
--call old function
oldonEffectAddMain(rActor, rEffect)
end

---

Thanks for the heads up, looks like the functino I override isn;t quite the right one to play nicely with others :P
I've adjusted to override in the same fashion you do and it appears to work now. I've probably broken somehting else though :)

Yup, broke something else, but it's late so it'll be a tomorrow job at best.

Quote:

---

Originally Posted by Stv

Thanks for the heads up, looks like the functino I override isn;t quite the right one to play nicely with others :P
I've adjusted to override in the same fashion you do and it appears to work now. I've probably broken somehting else though :)

---

Heh, they don't make it easy on us, do they? Thanks for the quick update!

Quote:

---

Originally Posted by Stv

Yup, broke something else, but it's late so it'll be a tomorrow job at best.

---

I assume this is tied to not getting chat messages for effects?

Quote:

---

Originally Posted by nephranka

I assume this is tied to not getting chat messages for effects?

---

TBH, I've no idea why that's happening.
All my recent updates have been on the test channel in readiness for the major effects overhaul that has been done by SW.
It all works in test, so not really giving the issue any time on the live server as I think the new update is live in the middle of this month.

I hope this isn't too much of an inconvenience for those that use this extension, but I only have so much free time to devote to the upkeep of my extensions.

Cheers,
Stv.