Thread: PFRPG Ammunition Manager
-
November 20th, 2021, 22:29 #171
Last edited by Kelrugem; November 20th, 2021 at 22:31.
My extensions for 3.5e and Pathfinder
Bug reports please here
-
November 21st, 2021, 13:40 #172
Yes, I added in 1.9 and removed in 1.10 (the feb ruleset update), so there wasn't ever any improvement to that code.
You can see all the code changes that 1.9 had over 1.8 here: https://github.com/bmos/FG-Ammunitio...re/v1.8...v1.9Last edited by bmos; November 21st, 2021 at 13:45.
-
November 21st, 2021, 17:22 #173My extensions for 3.5e and Pathfinder
Bug reports please here
-
November 28th, 2021, 12:56 #174
By the way, the CharManager contains functons hasFeat and hasTrait for PCs, they look similar what you do in that case but are a bit different. Where there some specific concerns you had in the string checks you wanted to get resolved which is why there are some differences? Seemingly something about hyphens? But what does the %d+ do in the string match? (probably allowing numbers which are ignored then for the check?) (and the ,1? )
My knowledge about string comparisons is basically zero and I find the documentation about it often utterly confusing which is why I usually avoid any string comparisons (if you have any good documentation about string stuff in Lua I would be happy )
I will handle the remaining code different. I want to automate the blind fight differently. The blind fight will be checked before the defense values are checked such that I can counter bonuses coming from invisibility (melee), and attackers with that ability simply gain advantage on their miss chance roll, using my base code of that (as you may have seen I already added effects for advantage on attacks and so on) I want to add ethereal as counter effect to blind-fight in order to support stuff like blink and ethereal creatures in generalLast edited by Kelrugem; November 28th, 2021 at 13:00.
My extensions for 3.5e and Pathfinder
Bug reports please here
-
November 28th, 2021, 13:00 #175
Yeah, lua's pattern recognition was hard to learn but is pretty powerful.
This is my go-to reference link for string.match, although there are still a few things it doesn't explain well.
This is my go to for string.find.
Happy to help if you have questions.
If I remember correctly, I wrote my own function for that because I wanted it to handle PC special abilities and NPCs as well. I think the 3.5E CharManager functions just work for PCs.
If I was writing that again, I'd do it differently.
Those sound like great improvements.Last edited by bmos; November 28th, 2021 at 13:09.
-
November 28th, 2021, 13:04 #176
Thanks for the link
Yeah, the NPC stuff I have seen It was just about the part with PCs because I was thinking about to replace these specific if-clauses for PCs with the existing functions (although they are rarely used in the code, besides two weapon fighting, slow and steady, multitalented and skilled no other feat or trait is automated. Hence, I doubt that these functions will get updated in the future. But if they get updated, your function could profit from such an update if using these instead)My extensions for 3.5e and Pathfinder
Bug reports please here
-
November 28th, 2021, 13:07 #177
There are other things going on in that function too though that I forget haha
At the very least, it ignores numbers at the end of a feat/trait name like "armor expert 1" and "Armor Expert 2".
It also looks at Effects in case things are added temporarily.
And ",1" just means it's starting at the first character of the string it's searching.Last edited by bmos; November 28th, 2021 at 13:11.
-
November 28th, 2021, 13:08 #178My extensions for 3.5e and Pathfinder
Bug reports please here
-
December 5th, 2021, 19:50 #179
- Join Date
- Jan 2021
- Posts
- 214
Bmos, thank you for listening to my (and others) feedback and removing the RELD from weapons that don't use ammunition.
It was a small thing, but it was annoying.
Absolutely fantastic extension.Last edited by BushViper; December 5th, 2021 at 23:33.
-
December 6th, 2021, 14:43 #180
Thread Information
Users Browsing this Thread
There are currently 1 users browsing this thread. (0 members and 1 guests)
Bookmarks