PFRPG Total Encumbrance Extension

[Zygmunt Molotch]

I have most of the official modules, I will give it a go in a moment, see if I can make it spit out anything else!

for reference 1.5.1 worked absolutely fine... so it's something between the two 1.5.1-1.5.4


ok, so now


Script Error: [string "scripts/real_encumbrance.lua"]:94: attempt to perform arithmetic on global 'nTrimmedItemCost' (a nil value)
Ruleset Warning: window: Anchored static width ignored for control (name) in windowclass (charsheet)


line 94?

[bmos]

for reference 1.5.1 worked absolutely fine... so it's something between the two 1.5.1-1.5.4

Yes, the section that is erroring was completely re-written for clarity, conciseness, and to avoid other potential issues. As usual, the result has been initially sub-optimal but the change will be worth it in the long run.

The attached beta should keep that whole section from running if there isn't anything there.

EDIT: beta builds removed as issue has been fixed in 1.6.1

[Asgurgolas]

Nice! I'll check it after I'm done here (D&D session just ended, now I'mma go grab some food and compile notes. And yes, it's 3.45 AM here but I'm totally not sleepy)

[bmos]

Nice! I'll check it after I'm done here (D&D session just ended, now I'mma go grab some food and compile notes. And yes, it's 3.45 AM here but I'm totally not sleepy)

I know that feeling! GMing is a really crazy cup of coffee haha
I hope you had a fun session.

[Asgurgolas]

Session was fun. Dice weren't.. I mean, level 8 spellcaster trying to kill a drow with SR 12. 5 rounds of continuous fail XD
Level 8 fighter with +13 to attack willing to rain two-handed death on said drow (AC: 16). Do you think he ever hit then and in the following rounds?

Said drow attempted to murder a half-naked level 7 flat-footed elf wizard (AC like, 14) -> kept missing.

The one combat that would usually last 2, 3 rounds top went on for 13

[bmos]

Session was fun. Dice weren't.. I mean, level 8 spellcaster trying to kill a drow with SR 12. 5 rounds of continuous fail XD
Level 8 fighter with +13 to attack willing to rain two-handed death on said drow (AC: 16). Do you think he ever hit then and in the following rounds?

Said drow attempted to murder a half-naked level 7 flat-footed elf wizard (AC like, 14) -> kept missing.

The one combat that would usually last 2, 3 rounds top went on for 13

Sometimes the dice are in your favor, sometimes they want you dead

[bmos]

I finally reproduced the nil issue! The item "cards" caused it to come up because it has a value of "1 sp-100 gp".
This sort of format is also used for hats and other items of varying value.

Technically, this is a data-entry issue as the player or GM should enter the correct value when the item is purchased, but I plan to ignore any item values that contain a "-" to keep the apparent-bugginess at bay.

If, after the next release (v1.6.1) anyone encounters errors including "sTrimmedItemCost" or "nTrimmedItemCost", please send me your db.xml file and tell me which character's inventory triggers the error message.

v1.6.1 - bugfix for nil values in processItemCost

EDIT: ran a 5th level game with 5 players this evening with both of my extensions enabled and didn't have any errors (and the extensions worked)

[Zygmunt Molotch]

ah, yes the undefined price items
-removed, I was wrong nothing seems to be listed as a dice value

[bmos]

ah, yes the undefined price items

does this fix also cover miscellaneous loot values, Pyrite, Turquoise etc, all of which have undefined 'rollable' values of coin, (I guess this is what was causing my game crashes, because I wont assign a value to those 'rocks' until they attempt to sell them... and pass some bluff/sense motive checks ;-) )

That's quite the edge case, as well. I don't see turquoise or anything with dice-based values on d20pfsrd, where are you getting those items from?
Can you copy/paste one of the item cost fields so I can see exactly how they're formatted?

[Zygmunt Molotch]

ah I'm wrong, sorry

they're in Ultimate Equipment, listed as 5gp, but it's their notes field that is +2d4 and so on (and that wont affect it as it's purely notes)

scratch that, their value was listed as 5 gp, can't be that then!

must have been the hats!