Function Issue

[bloodylemming]

I'm trying to move calculations out of the objects and into functions, but I'm having a bit of trouble.


Here, I'm trying to pass three values into the function, the character id, a value being manipulated and the name of the object whose value I need to set.

Here's what I have in the function

function calculateAbilityMod(nodeChar, strMod, numCurrent)

	local nResult =0;
	
	if numCurrent < 10 then
		nResult = math.ceil((nScore - 10) / 2);
	elseif numCurrent > 10 then
		nResult = math.floor((nScore - 10) / 2);
	else
		nResult = 0;
	end

	nodeChar.getChild(strMod).setValue(nResult);
	
	return true;
	
end

Here's what I have in the triggers:

function onValueChanged()
	--values passed> nodeChar, strMod, numCurrent
	local nodeChar = window.getDatabaseNode();
	local strMod = "numStrengthMod";
	local numCurrent = nodeChar.getChild("numStrengthCurrent").getValue();
	
	charManager.calculateAbilityMod(nodeChar, strMod, numCurrent);
end

I've confirmed the variables are being passed into the function properly, but it's not setting the value in the target.
I don't think I'm handling the strMod value properly... I need this value so the function knows which stat modifier to update...

[Trenloe]

Please provide the XML of the control anchored to the numStrengthMod DB field.

[bloodylemming]

Please provide the XML of the control anchored to the numStrengthMod DB field.

There is no code added to numStrengthMod. That's the target I want to set the value of. Or are you talking about the XML setting up that number field?

[damned]

above this line

nodeChar.getChild(strMod).setValue(nResult);

add

Debug.chat(nodeChar, strMod, nResult);

I suspect that you should be using nodeChar where you have used strMod

[bloodylemming]

above this line

nodeChar.getChild(strMod).setValue(nResult);

add

Debug.chat(nodeChar, strMod, nResult);

I suspect that you should be using nodeChar where you have used strMod

Here's what I got with the debug. Everything looks right.....

s'nodeChar: ' | databasenode = { charsheet.id-00001 }
s'strMod: ' | s'numStrengthMod'
s'numCurtrent: ' | #17

[Trenloe]

Or are you talking about the XML setting up that number field?

Yes, the XML for the configuration of the number field.

[bloodylemming]

Yes, the XML for the configuration of the number field.

It's automatically generated, as I'm using Ruleset Wizard to do the layout, but here's the entry from the XML.

</number>
      <number name="numStrengthMod">
        <bounds>131,43,35,35</bounds>
        <readonly />
        <font>reference-b</font>
</number>

[damned]

Here's what I got with the debug. Everything looks right.....

s'nodeChar: ' | databasenode = { charsheet.id-00001 }
s'strMod: ' | s'numStrengthMod'
s'numCurtrent: ' | #17

Show what the data in the database looks like please.
This is in a charsheet - so find the db.xml and find <charsheet><id-00001> and copy everything from the <id-000001> to the </id-00001> tag and share here.

[bloodylemming]

Show what the data in the database looks like please.
This is in a charsheet - so find the db.xml and find <charsheet><id-00001> and copy everything from the <id-000001> to the </id-00001> tag and share here.

<id-00001>
			<abilitylist />
			<Checkbox1 type="number">0</Checkbox1>
			<chkCharisma type="number">0</chkCharisma>
			<chkConstitution type="number">0</chkConstitution>
			<chkDexterity type="number">0</chkDexterity>
			<chkIntelligence type="number">0</chkIntelligence>
			<chkStrength type="number">0</chkStrength>
			<chkWisdom type="number">0</chkWisdom>
			<numCharismaCurrent type="number">10</numCharismaCurrent>
			<numCharismaMod type="number">0</numCharismaMod>
			<numCharismaScore type="number">10</numCharismaScore>
			<numConstitutionCurrent type="number">16</numConstitutionCurrent>
			<numConstitutionMod type="number">3</numConstitutionMod>
			<numConstitutionScore type="number">16</numConstitutionScore>
			<numDexterityCurrent type="number">14</numDexterityCurrent>
			<numDexterityMod type="number">2</numDexterityMod>
			<numDexterityScore type="number">14</numDexterityScore>
			<numExperience type="number">0</numExperience>
			<numFamiliarBonus type="number">0</numFamiliarBonus>
			<numHeight type="number">0</numHeight>
			<numIntelligenceCurrent type="number">8</numIntelligenceCurrent>
			<numIntelligenceMod type="number">-1</numIntelligenceMod>
			<numIntelligenceScore type="number">8</numIntelligenceScore>
			<numLevel type="number">1</numLevel>
			<numNextLevel type="number">0</numNextLevel>
			<numNonProficiencyBonus type="number">0</numNonProficiencyBonus>
			<numProficiencyBonus type="number">1</numProficiencyBonus>
			<numSpeed type="number">0</numSpeed>
			<numSpellcastingBonus type="number">0</numSpellcastingBonus>
			<numStrengthCurrent type="number">17</numStrengthCurrent>
			<numStrengthMod type="number">4</numStrengthMod>
			<numStrengthScore type="number">18</numStrengthScore>
			<numWeight type="number">0</numWeight>
			<numWisdomCurrent type="number">7</numWisdomCurrent>
			<numWisdomMod type="number">-1</numWisdomMod>
			<numWisdomScore type="number">7</numWisdomScore>
			<token type="token"></token>
			<txtWounds type="formattedtext">
				<p />
			</txtWounds>
		</id-00001>

[damned]

It looks like its working to me.

17-10/2 = 4