Printable View
Hey everyone. Sorry for the late reply.
I've updated the Forge version with the fix Saagael supplied for the calendar issue. No version change.
Life, death and my job keep me busy.
'll try to make some room to read through everything at the weekend.
Cheers
Hello, and thank you so much for the theme that saves our eyes. I have a few questions (comments? complaints?) First while it's dark it's a bit... to dark at least in the starfinder settings. I totally bet this is my monitor settings, but sometimes the brown menu's with their brown boarders are hard to see the brown edges, of the brown other windows behind them. Then there's the x in some of the windows, with no background of it's own, blend into other windows.
With that complaint out of the way the reason i'm posting today is 2 fold
On the character sheet, (and party sheet) we have the Starship tab, all the other tabs have nice bright text, but these 2 are dark. I'm told they are images, I'd love to be able to assist with the code to change it, but I wouldn't know where to look. (like what .png should be found / updated to bright colors) if I could help out with that, I could also brighten the ones in the inventory tab.
Thanks for the praise and critique, so let's see:Quote:
Originally Posted by Camberme
Darkness and Contrast:
The theme was developed at 120 cd/mē brightness on an professionally calibrated wacom cintiq 27qhd. Keep in mind that a lot of monitors have very weird factory settings, so I'd suggest to either use tools like Spyder Elite (can be rented), X-Rite hardware like the ColorMunki or the "i" calibration hardware suite. This might be somewhat overkill (still highly recommended) so there are easier methods out there to do the process manually (eyeballing, but better than nothing).
I will try to provide a link to some good ones soon, you might want to google a little in the meantime.
The frame borders have seen around 3 iterations by now and I'm pretty happy in general with their appearance, I will however, take your feedback and test some more iterations with even brighter dual frames than they're already using.
Misaligned elements:
This is something I can't easily fix, as I only change the provided graphics with some minor tweaks here and there, but I steer clear of anything in regard of messing with frame values. Sorry, I'm unable to fix this (some of the issues are present in the official themes as well mind you :D ).
Icons:
I assume you're running Starfinder, which has only very basic support by me. I had planned to conquer the missing icons and graphics at some point, but l a healthy work/life balance is unobtainable to me for quite some time now (I'm extremely overworked lol ). Maybe ask around in the forums or discord, if someone is willing to provide further support. I can gladly make my design files available, as I don't see providing the graphics myself in the foreseeable future.
He lives! So, beware of the new Theme changed test (not sure it will effect you or not). Also, let me know if you plan or even can resolve the map UI anomolies where color differences make highlighted layers unseeable.
I really like the theme but some of it is showing up as black on dark grey for me, particularly the tabs in the combat tracker and the speed ranks used by AD&D's combat and tactics mod. Also target symbols seem unreadable in the combat tracker UI for me. Is there anything I can do for this? https://media.discordapp.net/attachm...1332/image.png
Show a screenshot of the Chat window on loading your campaign. What other extensions are being loaded?
An update - my players do not seem to report this issue, it only seems to be effecting my end as the DM.
https://media.discordapp.net/attachm...6898/image.png
two things to try.
delete corerpg.pak and 2e.pak (can also delete the extensions in the vault) and rerun the updater
disable the other extensions and add them back in one by one
also are you running on Live or Test channel?
Are the pak files somewhere in the folder? Also uncertain how to check the live/test channel thing but I can do after my game today
i think you can type
/info
in chat and it should tell you
on the fg splash screen there is an explorer/folder icon
if you click that it will take you to your data folders
Okay, deleted the relevant pak files and then got it to update, disabled all extensions besides the Hearth Theme. I'm on Live, I think.
The only extension activated is this theme and I'm still getting labels dark.
https://media.discordapp.net/attachm...6494/image.png
Is there anything else I can try?
Huh, I've never seen horizontal tabs before. I cracked open the code for 2e and Hearth theme and I think I see the issue. The buttongroup_tabs.lua script that drives how the tabs function has hard-coded colors in there for when a tab is active or not. That is most likely overriding the theme's color assignment. I can try to find some time tomorrow or friday to patch it.Quote:
Originally Posted by TheButterdragon
That's awesome of you, thank you very much. That issue aside, my players today told me they loved the new theme I was using. Some of them have been struggling with readability with the default and really appreciated this one.
Like Saagael said, this is probably not fixable, at least by me (I suck at coding). Maybe he will be able to find a solution.Quote:
Originally Posted by TheButterdragon
Thanks for the praise, the theme has been a labor of love for a long time. Unfortunately I lack fee-time right now to look into quite a long list of requests and issue that have come up recently.
I've taken some time to try and solve this but unfortunately the only way I can see to fix this is to completely override how the horizontal tabs work, which I do not feel comfortable doing as it would harm cross-version compatibility. If Smiteworks could update the way horizontal tabs work such that the colors are configurable, I would happily add support for them. I suspect they will do this sooner or later, as horizontal tab colors are currently un-theme-able as they are, and there has been a big push to update controls for better theming.Quote:
Originally Posted by TheButterdragon
I just found this theme a few days ago and I absolutely love it. It fixes a lot of problems I've had with other themes. Thank you for the work you've put into it!!Quote:
Originally Posted by SirMotte
Appreciate it all the same! Its a nuisance but a pretty minor one and it seems to only effect me as the DM so its one I think I can live with.Quote:
Originally Posted by Saagael
With today's FG update and the code changes for themes, I only have a couple things to report, but they are minor and won't cause me to have to use a different theme next session! LOL In any case, here's what I've found
1. Dice tower now looks super funky:
Attachment 58666
2. Story Entry and Note Header text color:
Attachment 58667
3. NPC and Vehicle name text (black on brown):
Attachment 58668
4. This may be something from another extension, but there is a button to "Send to Chat" that is extremely hard to see:
Attachment 58669
(I can figure out which extension if you need me to)
I haven't gone through the console logs yet, but wanted to report the main issues I saw -- I think with as many extensions as I use as a DM, this theme isn't not THAT broken with the new changes SW have done. If I find anything else, I will let you know.
4. is the ichat button. It sends the contents of the record to the chat for all to see. It's new.
Quote:
Originally Posted by SmackDaddy
I've got a 'good enough' fix for #2 and #3 where I set the font to that light color used everywhere (#FFF0CA).
It requires adding these lines to the extension's graphics\graphics_fonts.xml file:
<font name="npcsheet_header">
<ttf file="graphics/fonts/Noto_Sans/NotoSans-Bold.ttf" name="Noto Sans Bold" size="16" />
<color value="#FFF0CA" />
</font>
<font name="storybox_header">
<ttf file="graphics/fonts/Noto_Sans/NotoSans-Bold.ttf" name="Noto Sans Bold" size="24" />
<color value="#FFF0CA" />
</font>
I'll open a pull request on the repo later today... gotta run for now.
Edit for Pull Request link: https://github.com/SirMotte/FGU-Theme-Hearth/pull/42
Edit number two... I just pulled in all of the .21 changes as they weren't in the main branch I branched from... so now the pull request should be current and versioned for .22. Feel free to change or add whatever.
Attachment 58744
I just added the dice tower fix to that pull request. It was just some changes to the icon names for the three dice tower pngs. Here's a screenshot of the change. I also realized there is a dev branch that has those .21 changes that are already published to the Forge. Once those are committed, I can put these fixes on top of those. In the meantime, you can just use the folder directly from the .22 branch on GitHub.
Attachment 58746
Epic, thank you @JustinFreitas.
It was fun to figure out what was what. I hope it helps. Here's a link to a bundled up ext file...Quote:
Originally Posted by MrDDT
Version 2.9.22 of FGU-Theme-Hearth.ext
Edit: Just fixed the NPC header font size to match the Story header font size. Looks correct now. Updated file at the link but did not re-version anything.
Oh you beautiful person! Thanks a lot. Could you redirect the pull request to the dev build on github. I mess things up, without fail, if I try to merge diverging branches.Quote:
Originally Posted by JustinFreitas
Thank you Justin, I'll try to upload your adjustments to the forge this weekend. You're awesome!
SirMotte,
If I may ask, when do you think we will see the Forge updated again? No hurries, not trying to be rude, just that my players insist that only the Hearth theme is worthy of their game time! :)
ChipDancer
Wow, awesome -- thank you so much for this. I didn't feel comfortable doing some of the manual changes, but providing this .ext is awesome. When SirMotte updates it (on the forge), will it update when checking for updates in FGU, or will I need to delete the manually installed version and then update? Many thanks!Quote:
Originally Posted by JustinFreitas
As are YOU!Quote:
Originally Posted by SirMotte
My pleasure... if there's anything you need me to change, just say. When the time comes to upload, be sure to pull the latest file from the link. I've been fixing things here and there in the pull request and repackaging the file at that link. Was really fun to learn how the theming works. Looking forward to helping contribute going forward. Thanks for this amazing theme! It looks SOOOOOO GOOOOD!Quote:
Originally Posted by SmackDaddy
I added some simple support for the OSE ruleset too... looks decent but not perfect yet.
Update to v2.9.21 - Knightowl
Announcement:
Thanks to the amazing JustinFreitas some fixes are provided for the recent changes Smite Works did to how Themese are set-up. Make sure to shower him with praise!
My current work schedule doesn't allow me to allocate time to anything else and during the few hours of free time I'm too exhausted to actually work on the theme right now, please bear with me.
The Update is now live on the forge, in case you have used the Version posted my JustinFreitas in this thread, you don't need to delete it, it will get overwritten if you update though the forge.
Cheers Sir Motte
If your Theme's Version number goes down from 2.9.22 to 2.9.21, this is intended, as I don't jump numbers for the main branch releases (in case you used Justins Version)
Added Ruleset Support
- Old School Essentials (brought to you by Justin Freitas)
Theme Changes:
- Fixed new Graphics and broken stuff introdued with the recent Smiteworks Updates. (brought to you by Justin Freitas)
- Maybe some minor adjustments that I have forgotten about by now.
- File size was optimized, will need to take a closer look if the gain is worth it.
Download:
Fantasy Grounds Forge (Recommended)
(Run an update using the FG Client if you're already subscribed):
https://forge.fantasygrounds.com/shop/items/12/view
GitHub:
https://github.com/SirMotte/FGU-Theme-Hearth/releases
I don't think my changes made it into the newly published .21 version on the Forge. I'm seeing the CoreRPG dice tower and the Note/Story headers are incorrect. I'll keep using my .22 for now. Lemme know if you need any help with the merge or packaging. Thanks!
Edit: I see my changes in the dev branch... but the file sent from Forge is the 'old .21' not the 'new .21'. Did that Forge publish go ok? Also, in the dev branch, I see you renamed the announce text to .21 which is great... but the actual version a few lines lower in extension.xml is still set at .22.
Working for me in CoreRPGQuote:
Originally Posted by JustinFreitas
Many thanks to you and Saagael for all your efforts and for giving us this great theme! :)Quote:
Originally Posted by SirMotte
ChipDancer
According to the GitHub files, the changes should be included. I'll test stuff tomorrow.
Just in case I re-uploaded the forge file again.
Edit: Took a quick look, else I couldn't sleep. The chatframes added by "Output Record to Chat" need to be adjusted, as well as the button. The Sound Asset Manage Button needs to be brought in line with the theme as well as related play/pause buttons. Reference Manuals Need adjusted copy/paste collapse/expand buttons as well. Other than that, Dice Tower and Story/Note Headers are working s intended.
There are sure to be more small issues that need to be resolved. I might just have the motivation to do so during the week.
Thanks for looking! If you need anything when you check things out, just give a shout. I made a new branch with more fixes (mostly for OSE, some general) but no pull request yet.Quote:
Originally Posted by SirMotte
The Font for the Activities Tab on the PF2E character sheets is Black and barely Legible with the 19 update in Live.
Hi chaosknight199, I saw the dark Activities tab and made the color fix for it. The font on the tab is still slightly different though... at least I got it visible. I put it in my changelist but it will be a bit before it makes it into the Forge version. This isn't my project, I'm just helping with some of the maintenance by making some fixes. I did update the .ext file on my site if you need it sooner.Quote:
Originally Posted by chaosknight199