Printable View
After updating, opening any item causes an error:
[ERROR] Script execution error: [string "campaign/scripts/item_main.lua"]:121: attempt to index global 'divider6' (a nil value)
I deactivated extensions, and the error stopped with Custom Item Generator disabled, so that seems to be the culprit.
Does that sound like an extension that would attempt to index global 'divider6'? :)
I just did a search for divider6 in all the built-in and store rulesets; but it only exists in PF2 and RMC rulesets and not on that line number. So, it's most likely an extension.
Regards,
JPG
Thanks for that report! I had updated it but forgot to move it from test to live.Quote:
Originally Posted by coyote670
Update and it should be okay now!
my extensions no longer add dividers :)
yup, updated, reenabled Custom Item Generator, and no more errors.
Many thanks!
(The PCs are going shopping on Sunday, so there will be many items opened, and probably several custom items created - so very happy everything's working. :D)
Thanks for the update!Quote:
Originally Posted by bmos
wrong thread, sorry ^^;
https://www.fantasygrounds.com/forum...l=1#post662276 here it is
Advanced Effects v1.17
* Character sheet minimum height has been increased so that the location of the effects on the combat tab is more obvious.
Click here to see raw code changes
Aura Effect v1.15
* Simplify code
* Script error fix reported by @rhagelstrom
Click here to see raw code changes
Advanced Item Actions v1.11-hotfix.1
* Patch for compatibility for Advanced Charsheet by Zarestia in https://github.com/FG-Unofficial-Dev...Actions/pull/8
* Search for spells in any loaded modules by Zarestia in https://github.com/FG-Unofficial-Dev...Actions/pull/9
* HOTFIX: typo fixed
Click here to see raw code changes
Greetings,
Advanced Item Actions does not seem to be working. I added a weapon to a PC and it does not show in the Actions tab. After removing the extension, and deleting and replacing the weapon in inventory, it showed up in the Actions tab.
Thanks for all your hard work on all these extensions, the are all so helpful!
Thanks for the report! I'll fix it this week.Quote:
Originally Posted by ssostac1
It should be working again. Just run an update to make sure you have the new version.Quote:
Originally Posted by ssostac1
It's also much more compatible and less likely to break with future updates :)
Advanced Item Actions v1.12
* The changes to support adding fire/cold/electricity/acid damage and adding shields to the weapons list no longer overwrite the base ruleset function for better compatibility (removed over 200 lines of code, quite a lot!)
* Adding weapons to inventory now adds them to the Actions tab again.
* Double weapon parsing should again be working
Click here to see raw code changes
Live Hitpoints v2.8
* Fix NPC implementation locking misc field
* Support for upcoming extension from @ZarestiaDev
* Move scripts to lua files for better debug messages
* Adds support for Effect Builder extension.
Click here to see raw code changes
Enhanced Items v4.7
* Add activation field by @ZarestiaDev in #2
* Cleanup of some code behind the scenes.
Click here to see raw code changes
Enhanced Items v4.8
* Changes ItemManager.isArmor, isWeapon, and isShield to use looser string.match instead of exact match. This means formats like "Magic Armor" in the type field will also be accepted instead of simply "Armor".
* Fixed detection of wondrous items.
* Widened charge/maxcharge fields so "Maximum" label is visible. Sorry they don't line up anymore.
* Fixed weapon/armor fields getting 'stuck' visible.
* Fixed 4th divider not being visible.
Click here to see raw code changes
Customized Item Generator v1.11
* Fix inability to generate consumables or magic items from read only records.
* Many code changes in an attempt to follow best practices. More cleanup to come.
Click here to see raw code changes
Enhanced Items v4.8
* Changes ItemManager.isArmor, isWeapon, and isShield to use looser string.match instead of exact match. This means formats like "Magic Armor" in the type field will also be accepted instead of simply "Armor".
* Fixed detection of wondrous items.
* Widened charge/maxcharge fields so "Maximum" label is visible. Sorry they don't line up anymore.
* Fixed weapon/armor fields getting 'stuck' visible.
* Fixed 4th divider not being visible.
Click here to see raw code changes
Drain and Permanent Bonuses v1.3
* Improve compatibility with an upcoming extension from @ZarestiaDev
* Cleaned up formatting of code
Click here to see raw code changes
Ammunition Manager v3.10
* Ammopicker defaults on, so should the default case by @SoxMax in #28
* Fix issues with other extension compatibility.
Click here to see raw code changes
Extra Stat to Saves v2.7
* Moved lua code to lua files to improve error message accuracy when they occur.
* Improve compatibility with other extensions by calling prior functions.
Click here to see raw code changes
Extraplanar Containers v1.12-hotfix.4
* Allow collapsing containers via double-click.
* Use alternate chat messaging so that 'overfull' messages are broadcast to all users.
* HOTFIX: Now works in 5E and SFRPG again.
* HOTFIX: Collapsing items now works in PFRPG2.
* HOTFIX: Mundane containers now also collapse properly.
* HOTFIX: Collapsing mundane containers was negating the weight of contents. Fixed.
* HOTFIX: Collapsing extraplanar containers was not collapsing child containers. Fixed but only works one level deep.
* HOTFIX: Contents weight shown within container could get too long due to decimals. Now rounds to fewer decimals as numbers gets longer.
Click here to see raw code changes
The REVERT positive effect that is auto added to undead seems to be bugged. Channel energy is positive for a good cleric and damages undead in the game. In FGU Pathfinder 1 with the extended automation extension, REVERT positive turns the damage into healing for the undead. I don't really understand what REVERT is trying to accomplish, healing doesn't have a type, so healing can't be turned to damage. It is being added automatically by the extension, so I can't even remove the effect until after they are in the combat tracker, very tedious.
REVERT: positive is automatically reverting all heal rolls into damage; are you not observing that, or do you not want that to happen? :) Or do you mean that Channel energy is set-up as positive damage rolls and accidentally turns out to be heal now instead? That is a good point then I was not thinking of, you may just remove positive as a damage type. In 3.5E it is not a damage type (I think?) which is why I didn't expect that anyone is using it as a damage type :)Quote:
Originally Posted by rickyhunt
I noticed the same thing today. The cleric's player was quite aggrieved.Quote:
Originally Posted by rickyhunt
Or in other words, I always thought positive energy stuff is healing for living, damage for undead :) But I may be wrong with that, or PF1 handles that differentlyQuote:
Originally Posted by Kelrugem
(EDIT: We are in the wrong thread by the way :D)
It reverts all damage, though, so hitting the damage effect on channel positive energy heals them. If you hit them with the heal effect, they do take damage; however, the saving throw for half damage doesn't work. They take full damage regardless. So it's kind of messy, and the players know that channeling positive energy is either to heal the living or damage the undead, not both, so they pick the appropriate effect - and then things are snafu city.Quote:
Originally Posted by Kelrugem
Yeah, I was not expecting that people use damage buttons with positive damage (more like untyped damage). But it is so many years ago already that I played any game that I am extremely rusty in how people set-up their actions; I was only updating my extensions because I know that people are using it, but I am not playing anymore since the end of 2019Quote:
Originally Posted by coyote670
Yup, this is known, it would have taken too much time to take the save stuff into account (because the damage is rolled after the save happened; it is not impossible but I would need a major rewrite of the code). Hmm, I need to think about it, I mainly added that effect and its parsing because I regularly got requests in private messages to add such an effect, so it may depend on the playstyle in FG. I remember that there was a request about the NPC parsing and making it optional, that should be easier to add for the time-being than catering the save stuff etc.Quote:
Originally Posted by coyote670
Maybe you could just (time withstanding) add in the option panel "automate revert on undead?" so one can decide if to activate it or not?
[edit: just saw Kelrugem already pondered that XD]
Can a mod move posts 415-421 into Kel's thread? Do they have the ability to do that?
https://www.fantasygrounds.com/forum...m-s-extensions
Encumbrance Penalties v1.9
* Resolves issues with the wrong encumbrance info being used when encumbered but not wearing armor
* Adds SPEEDMULT effect to allow for more spell automation
* Cleans up the codebase a bunch for easier readability (but still a long way to go)
Click here to see raw code changes
hi! sorry but im noticing an issue with extraplanar containers. sometimes when moving an item out of a bag to another location itll still collapse when the bag is collapsed.
theres another issue with like changing the locations of bags that is more avoidable, seem like sometimes when typing the location if it auto suggests an item thats inside the bag itll basically collapse in on itself and the bag along with everything in it disappears.
I guess I'll need to prioritize reworking that... Thanks for the report!Quote:
Originally Posted by Kazuto217
I haven't been able to reproduce these issues. Perhaps it's an incompatibility with another extension you're running or maybe I just need more specific directions to reproduce the issue.Quote:
Originally Posted by Kazuto217
EDIT: actually it just happened! I'll try and figure out why.
haha glad to hear you got it, sorry i was busy the past few days. let me know if i can be of any help nailing down the cause tho
I think I have it fixed (along with a couple little improvements). When you get a chance, can you update and make sure your items have re-appeared?Quote:
Originally Posted by Kazuto217
Encumbrance Penalties v1.10-hotfix.2
* Compatibility issues with new ruleset updates caused by merge tag on template.
* Compatibility with Advanced Charsheet
* HOTFIX: block negative speed.
* HOTFIX: remove merge tag on number_charspeed template for compatibility with FGU 4.3.0
* HOTFIX: disable checking for disabled character if character level is zero
Click here to see raw code changes
Extraplanar Containers v1.12-hotfix.6
* Allow collapsing containers via double-click.
* Use alternate chat messaging so that 'overfull' messages are broadcast to all users.
* HOTFIX: Now works in 5E and SFRPG again.
* HOTFIX: Collapsing items now works in PFRPG2.
* HOTFIX: Mundane containers now also collapse properly.
* HOTFIX: Collapsing mundane containers was negating the weight of contents (Issue #10 ). Fixed.
* HOTFIX: Collapsing extraplanar containers was not collapsing child containers (Issue #11 ). Fixed but only works one level deep.
* HOTFIX: Contents weight shown within container could get too long due to decimals (Issue #12 ). Now rounds to fewer decimals as numbers gets longer.
* HOTFIX: Add second function override to fix issues with 2E
* HOTFIX: Fix containers "collapsing in on themselves" as reported by [Kazuto217](https://www.fantasygrounds.com/forum...3731-Kazuto217).
* HOTFIX: Fix potential issue of un-carried containers not allowing collapsing.
Click here to see raw code changes
Customized Item Generator v1.12
* Only disallow item creation if total bonus is equal to total bonus from abilities AND total bonus from abilities is not zero. It's not clear to me whether cost-only abilities require a +1, so for now they do not.
* Add message for item with ability that is missing an enhancement bonus
* Code cleanup
Click here to see raw code changes
Ammunition Manager v3.12
* Resolves issues with the wrong encumbrance info being used when encumbered but not wearing armor
* Update starfinder ammo reloading by @SoxMax in https://github.com/bmos/FG-Ammunition-Manager/pull/30
* Compatibility with new SFRPG update by @SoxMax in https://github.com/bmos/FG-Ammunition-Manager/pull/31
Click here to see raw code changes
I'm in the process of validating my extensions against the new v4.3.3 update on the test server that looks like it may drop in the latter half of next month.
If anyone finds it useful for me to post builds to the test channel, let me know. Otherwise, I'll hold off until closer to release.
Along with updating extensions for compatibility with the upcoming changes, I'm also fixing reported bugs and addressing some requested features.
Extraplanar Containers will support containers that limit the number of items that can be put in them (like scroll cases or quivers) and containers that exceed their limits will be tagged in red.
I just dropped a bunch of updates on the TEST branch.
https://github.com/FG-Unofficial-Dev...tag/v1.14-rc.1
https://github.com/FG-Unofficial-Dev.../tag/v2.1-rc.1
https://github.com/FG-Unofficial-Dev...tag/v1.14-rc.1
https://github.com/FG-Unofficial-Dev.../tag/v1.7-rc.1
https://github.com/FG-Unofficial-Dev.../tag/v2.5-rc.1
https://github.com/FG-Unofficial-Dev...tag/v1.18-rc.1
https://github.com/bmos/FG-CoreRPG-E...tag/v1.13-rc.1
https://github.com/bmos/FG-CoreRPG-C.../tag/v2.2-rc.1
https://github.com/bmos/FG-Ammunitio...tag/v3.14-rc.1
Tons of new stuff posted.
Mostly minor, but a few extensions got some neat new features.
First off, great extensions you make, thank you =)Quote:
Originally Posted by bmos
There are containers in Pathfinder 2 that work a little different:
- "Saddlebags come in a pair. Each can hold up to 3 Bulk of items, and the first 1 Bulk of items in each doesn't count against your mount's Bulk limit."
- "A backpack holds up to 4 Bulk of items. and the first 2 Bulk of these items don't count against your Bulk limits."
Would it be possible for Extraplanar Containers to support container like this?
I probaly could do this in a workaround and define a special backpack as a extraplanar container that can hold 2 Bulk, which then wouldn't count, but then the chat message for the full container would trigger at 2 Bulk and not at 4 :/
Feedback, it would be great if Hit Margins had options to also show margins for skill checks and saving throws! I often give extra benefits when a player beats a DC by factors of 5.
Great idea about Saves, but not sure how I could implement that for Skill checks since FG doesn't know the DC unless you roll it from the Party sheet.Quote:
Originally Posted by Hjorimir
sorry, wrong thread
Hah, fair observation about the Skill checks. I guess I just glossed over the part where I have a DC in my head. You can't program FGU to read my mind?! Anyway, the saves would be a great addition!
You're not the first to ask :)Quote:
Originally Posted by Hjorimir
It would be super helpful as there sure are a lot of cases like that.
Extraplanar Containers v1.14-hotfix.1
Click here to see raw code changes
- Support Pathfinder 2e-style items that ignore N weight units. Syntax of this is "the first 2 bulk of these items don't count against your bulk limits" as found here.
- To support this, the weight of items in mundane containers is now counted by combining the subtotals of each mundane container with the subtotal of items not in a container rather than by counting each item not in an extraplanar container.
- Some other code cleanup also included.
- HOTFIX: Better string search. No longer case sensitive, "of these items " now optional.
Ammunition Manager v4.0-hotfix.2
Click here to see raw code changes
- Reworked UI in 5E and PFRPG to count hits and misses separately and allow recovering either to different ammo items (such as for magic items that lose their magic when they hit).
- Pretty major back-end changes to support these changes in a modular fashion.
- All data for extension is now stored in a sub-node of each weapon rather than directly inside the weapon -- kind of like having a subfolder.
- Removed Starfinder support as it has been forked into its own extension by SoxMax.
- Updated UI to resize its width along with the rest of the weapon details window.
- Optional Custom Loading Weapons ext can now add and remove item names and properties from search lists.
- Loading property in 5E no longer requires loading manually as it takes no discrete action. Crossbow Expert feat no longer used to remove loading button on Crossbows (as they don't have it now unless you do that yourself).
- HOTFIX: Move 5e field visibility code to another function to facilitate easier extension compatibility patching.
- HOTFIX: Fix potential issue of onAttackAction not being de-registered correctly in 5e when char_weapon windowclass is unloaded