PFRPG Upgrade NPC Actions Extension

[bmos]

Please - if you include this make it optional, at least i don´t bother with mythic stuff.

Definitely. Few do.
I don't think I'd want to skip spells with a "[Y]" since that just means the spell has a Mythic variant. (perhaps with an opt-in toggle)
Using the word "Mythic" would be distinct since that's only used when a spell on an NPC is the Mythic variant.

[bmos]

Hi,
I've just looked into the code, and it's not an error: they are debug messages.
Annoying, yes, but nothing broken.

I bet bmos will remove those debug.chat lines as soon as he's notified.

It looks like I didn't post about it, but I fixed those

[KevenSimmons]

Running Pathfinder 1e ruleset - I'm getting this error for manually created spells.
[ERROR] Script execution error: [string "..Upgrade-NPC-Actions:..C_upgradespells.lua"]:90: setValue: Invalid parameter 1
Spells affected are dropped/deleted from the NPC entirely.

Troubleshooting has determined it is occurring when the Description field of the manually created spell is left Null. Adding any character to the field eliminates the issue, as does adding a character, then removing it.
2023-11-11_10h37_13.jpg

I'm guessing that the description or description_full attribute on the original spell node is not being created at all until the field is edited, causing the setValue command in the extension to fail as the attribute being referenced does not exist on the node.

[bmos]

Running Pathfinder 1e ruleset - I'm getting this error for manually created spells.
[ERROR] Script execution error: [string "..Upgrade-NPC-Actions:..C_upgradespells.lua"]:90: setValue: Invalid parameter 1
Spells affected are dropped/deleted from the NPC entirely.

Troubleshooting has determined it is occurring when the Description field of the manually created spell is left Null. Adding any character to the field eliminates the issue, as does adding a character, then removing it.
2023-11-11_10h37_13.jpg

I'm guessing that the description or description_full attribute on the original spell node is not being created at all until the field is edited, causing the setValue command in the extension to fail as the attribute being referenced does not exist on the node.

The issue was much simpler and a fix has been pushed.

I was calling

DB.deleteNode(node_spell, 'description')

instead of

DB.deleteChild(node_spell, 'description')

which resulted in deleting the entire "node_spell" instead of the child "description". Hopefully fixing this does not break anything else!

[KevenSimmons]

Awesome - thanks !

[Navigat0r]

Hello, I believe I have found an issue with this extension. When using this extension in my main PFRPG campaign, attempting to use the spell parsing function of this extension causes some error messages to appear. Additionally, sometimes the spell will fail to parse entirely. I also discovered that reparsing some spells removes the effects that come from dllewell's spellbook extended (I did not do extensive testing, but beast shape 2-4 would remove all effects when pressing the reparse button. Other spells such as enlarge person were fine and the effects stayed as is, though an error message appeared).

I use quite a few extensions so I went into a test campaign with only this extension, the spellbook module, and the CRB loaded. I encountered the same errors.

The image I have attached is from my original campaign (read - one with many extensions). Some of the errors may be from other extensions. However, the errors at the bottom of the picture are the same as in my test campaign with no other extensions or modules.

[bmos]

When using this extension in my main PFRPG campaign, attempting to use the spell parsing function of this extension causes some error messages to appear.

Thanks for the detailed information and path to reproduce the issue! I will investigate.

EDIT: I have confirmed I can reproduce the issue.

[bmos]

So the issue was that the spell had roman numerals at the end which were being scrubbed when looking for the actions to add.
I have addressed this, but would expect that it will cause another issue somewhere else (with spells on NPCs that have some sort of uppercase letter codes at the end of the spell name?)

[Navigat0r]

So the issue was that the spell had roman numerals at the end which were being scrubbed when looking for the actions to add.

I am still encountering this issue when attempting to parse spells with roman numerals (absorb rune, elemental body, beast shape...). If I take the version of the spell from the CRB or another module with no effects, reparsing the spell does nothing. If I take the spell direclty from dllewell's spellbook module, attempting to reparse the spells containing roman numerals removes all effects. The console also throws an error when "reparsing" spells that already have proper effects attached to them (for example, Acid Fog parsed properly, but if i try to press parse again an error appears).

I have attached an image of the error from a new test campaign.

[bmos]

I am still encountering this issue when attempting to parse spells with roman numerals (absorb rune, elemental body, beast shape...). If I take the version of the spell from the CRB or another module with no effects, reparsing the spell does nothing. If I take the spell direclty from dllewell's spellbook module, attempting to reparse the spells containing roman numerals removes all effects. The console also throws an error when "reparsing" spells that already have proper effects attached to them (for example, Acid Fog parsed properly, but if i try to press parse again an error appears).

I have attached an image of the error from a new test campaign.

Can you confirm the version number of the extension that is posted in the chat when you load your campaign? I have tested with a number of spells and don't see an issue.