5E Advanced Effects (items, npcs, characters)

[Moon Wizard]

@Myrrdin, thanks for the sleuthing.

I've checked in a new build for AE with that fix.

Regards,
JPG

[RobboNJ69]

Thank you for the amazingly fast responses and fixes!

[Castellanox7]

Confirmed the update works on my side. Thank you, sir!

[dllewell]

This is for PF1E. I have this extension loaded and no others.

I am getting the attached warnings in the console.
It doesn't appear to actually affect the layout but once other extensions are added (specifically Advanced Charsheet) things start to overlap.
Now that may be a problem with Advanced Charsheet but seeing as this extension is throwing warnings without any other extensions loaded I figured I would start here.
Advanced Effects Error.png

[Moon Wizard]

It was in the 3.5E ruleset. I've pushed an update to fix the warnings in the ruleset code.

Regards,
JPG

[dllewell]

Thank you. That fixed the warnings.

Unfortunately it did not fix the issue with the Advanced Charsheet being overlapped by Advanced Effects. But pretty sure that is an issue with Advanced Charsheet not with this extension.

I'll post the error on that thread.

[dllewell]

I found what is causing the conflict between these two extensions.

The default character sheet puts the attackframe at the top and the acframe at the bottom.
Default Character Sheet.png
The Advanced Charsheet rearranges this to put the acframe at the top and the attackframe at the bottom.
Advanced Charsheet.png


The Advanced Effects code (classes_pfrpg.xml) specifically anchors to the acframe.
That works fine for the default character sheet but creates a problem for the Advanced Charsheet because the Advanced Charsheet window sits on top of the attackframe (and saveframe) window.

Is there any way to change the Advanced Effects code to anchor to a point after the last frame rather than specifically to the acframe?

Relevant Advanced Effects Code (classes_pfrpg.xml)
<windowclass name="charsheet_combat" merge="join">
<sheetdata>
<subwindow name="char_combat_ae">
<anchored>
<top parent="acframe" anchor="bottom" relation="relative" offset="0" />
<left parent="acframe" />
<right parent="acframe" />
<bottom anchor="bottom" relation="relative" offset="-5" />
</anchored>
<class>advanced_effects_subwindowf</class>
<activate />
<fastinit />
</subwindow>
</sheetdata>
</windowclass>

[Moon Wizard]

In general, extensions should refrain from redefining window classes. I don't see any differences between the default and the AdvCS version; which means that it probably should not be defined/overwritten.

Regards,
JPG

[dllewell]

While I completely agree with you in theory, the AdvCS extension has not been updated in over a year. I have dropped a message in that thread about the issue but there is a good chance that this may not get updated.

The Advanced Effects extension on the other hand is something that you have just updated.

Although maybe not the 'correct' answer, the path of least resistance is to ask you make the change to the Advanced Effects extension. Assuming this is something that can be done fairly easily. I don't know enough about the coding to know how easy or hard it easy to change from anchored to a frame to anchored to the bottom or to the last thing that was on the page. And therein lies the rub. What I'm asking for might be significantly more difficult than I am hoping it would be

[Moon Wizard]

It's actually changed in the core 3.5E ruleset, per a separate request to make the character sheet work better when resizing. The AdvCS extension will need to be adjusted.

Regards,
JPG