Temporary fix version of Kelrugem's Extended Automation

[Arimil508]

I can confirm that putting the tag before the check statement does seem to make the effect resolve correctly. Using my Titan Fighter as an example, I have nested IF statements that check for weapon tags to apply penalties for wielding an oversized two-handed weapon. When the tag is placed first, the penalty is applied as intended.

However, that does not appear to be the whole issue with our stack overflow problem.

What I was seeing is that the stack overflow would occur on virtually any roll made by that character. I was getting the error on attacks with other weapons, skill checks, and other rolls where this effect should not have been resolving to a positive result at all.

From my testing, changing the order of the tag check only affects whether the effect itself evaluates correctly. The stack overflow behavior still occurs in all the other situations where I was seeing it before. That makes me think the tag ordering issue and the stack overflow issue may be related, but they are not the same problem.

[rogerv]

Updated version with fix for IF: CUSTOM(...) processing causing Stack overflow error (see attachment in 1st post in this thread)

@Arimil508 / @FGMax I wasn't suggesting that changing the ordering was the fix, just that it explained why I wasn't initially able to reproduce the problem. Thanks for the testing

[FGMax]

Updated version with fix for IF: CUSTOM(...) processing causing Stack overflow error (see attachment in 1st post in this thread)

@Arimil508 / @FGMax I wasn't suggesting that changing the ordering was the fix, just that it explained why I wasn't initially able to reproduce the problem. Thanks for the testing

Tried it and it's working, great to have this feature working with this again. Thanks for the fix!

[Arimil508]

Your cool. I just wanted to make sure that it was clear that the error was persisting when rolling things that would not resolve as a positive for the if statement regardless of the order. because idk if anyone mentioned that it effected other rolls from the sheet besides the one that would have been effected by the statement itself

[FGMax]

With things settling down post patch, I've started to experiment with some of the new tags in the CoreRPG. It looks like DMGWARD, ABSORB, and IGNOREx don't work while this extension is running. It also means trying to drag dice onto a character in the combat tracker affected by one of these tags against a relevant damage type simply don't roll or do anything. I can't speak yet for the other new ones on the same line in the patch notes like MAKEx, xTOx, or DMGR but I'm guessing similar case. Also worth noting that the arcane spell failure chance just doesn't fire at all while the extension is running, but will automatically without it on any character that has it trying to cast a spell.