5E - Better Combat Effects Gold

[Henix]

Hi Moon Wizard,

I think this recent update may have broken the SAVEADD effect. Here is a breakdown of what i found in the code:

The Issue
In the updated manager_action_save_dnd_bce.lua, the save resolution callbacks are still invoking the function as:

BCEManager.addEffectFromCompData(rActor, rOrigin, tCompData)

This passes the arguments as (target, source).

The Cause

1. addEffectFromCompData passes those arguments directly to notifyAddEffect.
2. However, notifyAddEffect now expects (source, target).
3. Because of this, the arguments are currently swapped for save resolutions in the update.

The Impact
This breaks SAVEADD effects on saves. Instead of applying the effect to the save-rolling creature who failed, it applies it to the caster.

[Moon Wizard]

Thanks for the heads up and the sleuthing. I've swapped the calls for SAVEADD, SAVEADDP, and EXPIREADD to match the new format. It was messed on in *DMGADD*, which I was working on yesterday.

Please run a new Check for Updates.

Regards,
JPG

[ColoradoGM]

This is part of the Witch ability "Rending Hex" from Tales of the Valiant, and it looks really tricky to code so I thought I would ask if anyone wants to take a crack at it.

It looks like nested conditionals - IF hexed, and IF bloodied - then force a save, and on a fail apply an aura that gives enemies ADVATK?

"Each time a creature with one of your Hex dice starts its turn with less than half its hit point maximum, you can force the target to make a CON save against your spell save DC (no action required, and you can’t use the Hex die to reduce this save). On a failure, creatures within 5 feet of the target have advantage on attack rolls against it until the start of the target’s next turn."

[nephranka]

Looks like DMGR is not working.
When I use: Deflect Attacks; DMGR: 1d10 [DEX] [MONK], piercing, slashing, bludgeoning; DMGRT; (RCT) it comes on DMGR: 1d10 [DEX] [MONK], piercing, slashing, DMGRT; (RCT)

[MrDDT]

Rending Hex; IF: CUSTOM(hexed); IF: Bloodied; SAVES: [SDC] CON (M); SAVEADD: Rended Hex

Rended Hex; AURA: 5 all, !self; AoE Rended Hex; IFT:CUSTOM(Rended Hex); ADVATK

First one, apply to target that need this effect is being applied to and needs to make a save. This target should also be Hexed effect on them at some point else it will never trigger.
This target also will need to be both Bloodied and Hexed at some point when its the start of their turn else this will never trigger.

Second one, needs to go in the custom effect list. Make sure the duration is set to the correct amount of time.

[MrDDT]

Looks like DMGR is not working.
When I use: Deflect Attacks; DMGR: 1d10 [DEX] [MONK], piercing, slashing, bludgeoning; DMGRT; (RCT) it comes on DMGR: 1d10 [DEX] [MONK], piercing, slashing, DMGRT; (RCT)

I can confirm, this is not working

TestingDMGR; DMGR: 10 all

Chat says "REDUCED: 10" but it doesn't reduce it.