Fantasy Grounds Merchandise
Page 6 of 8 First ... 4 5 6 7 8 Last
  1. #51
    I addressed it for the moment.

    The base code only allows one handler, and there's no way for extensions to get any existing handler. So any handler that runs last will be the only one that runs.

    My extension overrides the code that registers handlers, and I set it to run early. So, if another extension tries to register, I can capture it and the dispatch to it.

    The devs said they will change the code to add a way for extensions to get any registered handler, so we can "chain" ourselves. Not sure when that will happen.
    DISCORD / EXTENSIONS:
    Combat: Crit Dmg Options, Effect FX, Enlarge/Reduce, Flavorful Names, Hidden Death Saves, Lingering Injuries (PL), Major Injuries (DK), Special Dmg FX, Spell FX, Summoner, Weapon Dmg Props
    Skills: Crits & Fumbles, Fail Forward, Toolkit Actions
    DM Tools: DB Search, Dynamic Pricing, Party Info, Redacted Table Fields
    For Fun: Achievement Tracker, Boar Riding, Dragon Cards, Drink & Sink, Fishing Fun, Seven Seas, Tarot, Turtle Race
    Puzzles: Cryptex, Volvelle, Word Key

  2. #52
    The savage attacker is only rerolling one of the two weapon dice now. Not sure what changed?

    Using Greatsword. it only offers to reroll the first of the two d6's rolled.

    I fixed it my adding a bit of code to the CountD, also added a check to make sure it ignored other dice that might get added by CT effects, so it only rerolls the weapon dice.

    local CountD = 0;
    local nOrigClauses = tonumber(rRoll.nOrigClauses) or 1;
    local nClauseCount = 0;
    local sEffectsExpr = string.match(rRoll.sDesc, "%[EFFECTS (.-)%]") or "";
    local aEffectsDice = DiceManager.convertStringToDice(sEffectsExpr) or {};
    local nEffectsDice = #aEffectsDice;
    for sDmgType, sDmgExpr in string.gmatch(rRoll.sDesc, "%[TYPE:%s*(.-)%s*%(([^)]*)%)%]") do
    nClauseCount = nClauseCount + 1;
    if nClauseCount > nOrigClauses then break; end
    local lowerType = sDmgType:lower();
    if string.match(lowerType, "slashing") or string.match(lowerType, "piercing") or string.match(lowerType, "bludgeoning") then
    local sDiceExpr = string.match(sDmgExpr, "(.-)=%d*") or sDmgExpr; -- Strip =total if present
    local aTempDice = DiceManager.convertStringToDice(sDiceExpr) or {};
    CountD = CountD + math.max(0, #aTempDice - nEffectsDice); -- Subtract effects dice
    end
    end
    Last edited by bwatford; February 25th, 2026 at 07:07.

  3. #53

    sorry

    Quote Originally Posted by bwatford View Post
    The savage attacker is only rerolling one of the two weapon dice now. Not sure what changed?

    Using Greatsword. it only offers to reroll the first of the two d6's rolled.

    I fixed it my adding a bit of code to the CountD, also added a check to make sure it ignored other dice that might get added by CT effects, so it only rerolls the weapon dice.

    local CountD = 0;
    local nOrigClauses = tonumber(rRoll.nOrigClauses) or 1;
    local nClauseCount = 0;
    local sEffectsExpr = string.match(rRoll.sDesc, "%[EFFECTS (.-)%]") or "";
    local aEffectsDice = DiceManager.convertStringToDice(sEffectsExpr) or {};
    local nEffectsDice = #aEffectsDice;
    for sDmgType, sDmgExpr in string.gmatch(rRoll.sDesc, "%[TYPE:%s*(.-)%s*%(([^)]*)%)%]") do
    nClauseCount = nClauseCount + 1;
    if nClauseCount > nOrigClauses then break; end
    local lowerType = sDmgType:lower();
    if string.match(lowerType, "slashing") or string.match(lowerType, "piercing") or string.match(lowerType, "bludgeoning") then
    local sDiceExpr = string.match(sDmgExpr, "(.-)=%d*") or sDmgExpr; -- Strip =total if present
    local aTempDice = DiceManager.convertStringToDice(sDiceExpr) or {};
    CountD = CountD + math.max(0, #aTempDice - nEffectsDice); -- Subtract effects dice
    end
    end


    the extension should be making sure it is just the weapon dice already.
    and I know it was rolling all damage die before.

    I know there were alot of changes in the last update, but I have been unable to test my extensions. I am in the process of selling my house and moving so my free time has been non-existent. I know a couple of problems popped up with great weapon master as well so I will be looking into fixing this extension As soon as I can.

    Sorry to everybody being affected.
    Last edited by lprchaun; February 25th, 2026 at 14:52.

  4. #54
    Quote Originally Posted by MrDDT View Post
    Are there currently only 2 reroll damage options for this ext right now? Or is there ways to customize others or are others being added?
    I programmed these for 5E feats.
    What other damage reroll options are you talking about?

  5. #55
    Hello

    I just bought and installed the extension and it works as inteded (5e, 2024).

    If I may, i want to add a suggestion. It would be nice to have an option to select, if the feat is automatically used or if the promt should appear. It could be nice for if a player does not want to confirme eatch round the only attack it can make.

    Have a nice day

    Greetings
    Frectorius

  6. #56
    Updating. I am still in the process of moving so I am between two houses (not to mention fixing issues with house that is being sold, etc.) so I have not had time to address the issues that recently popped up.
    I want everybody to know I have not forgotten will be getting to these items as soon as I can!

  7. #57
    Looks like on TEST:
    When any damage is rolled:
    [3/18/2026 7:10:56 AM] [ERROR] Handler error: [string "DamageRerollFeats:..nager_action_damage.lua"]:57: attempt to call global 'onDamageRoll' (a nil value)

    Passing it along

  8. #58
    Just checking back in since TEST will be live soon.

  9. #59
    Hi,

    With this active, every attempt at rolling damage comes up with this error (same as reported above):
    [ERROR] Handler error: [string "DamageRerollFeats:..nager_action_damage.lua"]:57: attempt to call global 'onDamageRoll' (a nil value)Untitled.png
    Last edited by coyote670; May 12th, 2026 at 21:53.

  10. #60
    sturtus's Avatar
    Join Date
    Feb 2010
    Location
    New Jersey, NYC
    Posts
    208
    Still broken on release. Do you have a repo? I could have a PR up pretty quick to fix.

Page 6 of 8 First ... 4 5 6 7 8 Last

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Tags for this Thread

Bookmarks

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
Refer a Friend

Log in

Log in