Jack of All Things for 5e (rebranding of Kit'N'Kaboodle)

[Farratto]

Hello

I reviewed the JackOfAllThings extension and tracked the two warnings down to specific merge blocks in the XML.

The warnings were coming from these files:

campaign/record_char_actions.xml
This file contains a FloatingTabs compatibility merge block targeting charsheet_actionsft.

campaign/record_power.xml
This file contains a merge block targeting power_action_resource.

The issue is that JackOfAllThings is trying to merge into UI classes that no longer match the versions currently being loaded by Fantasy Grounds. Because of that mismatch, FG reports that the asset name does not match the existing asset.

To resolve the warnings, I removed the two outdated merge blocks.

The blocks removed were:

From campaign/record_char_actions.xml:

<!-- FloatingTabs compatibility -->
<windowclass name="charsheet_actionsft" merge="join">
...
</windowclass>

From campaign/record_power.xml:

<windowclass name="power_action_resource" merge="join">
<script>
function update(_, bHideCast)
if super and super.update then super.update() end
resourcebutton.setVisible(not bHideCast);
end
</script>
</windowclass>

Result:
Removing those blocks cleared the JackOfAllThings merge warnings.

Tradeoff:
This also removes JackOfAllThings support for the FloatingTabs version of the character actions page and removes its custom update() patch for the power_action_resource row. In my testing, this was the safest way to eliminate the warnings without guessing at new merge targets.

I also created a cleaned version of the extension with those warning-causing blocks removed:

As the maintainer of Jack of All Things, I recommend against using this person's code. Apparently (s)he is not aware that warnings are normal part of extensions and can be ignored and they are proposing removing support for other extensions in order to get rid of a warning that has 0 effect on the functioning of the extension.

The result of the changes that this person is proposing will be loss of support for FloatingTabs and will have no gain whatsoever.

To wrandalljr4: If you are having some issue with Jack of All Things, please let me know and I will make my best effort to help, fix, or find a work-around for you. Please do not make public posts about code changes without first consulting the maintainer of the extension.

[wrandalljr4]

As the maintainer of Jack of All Things, I recommend against using this person's code. Apparently (s)he is not aware that warnings are normal part of extensions and can be ignored and they are proposing removing support for other extensions in order to get rid of a warning that has 0 effect on the functioning of the extension.

The result of the changes that this person is proposing will be loss of support for FloatingTabs and will have no gain whatsoever.

To wrandalljr4: If you are having some issue with Jack of All Things, please let me know and I will make my best effort to help, fix, or find a work-around for you. Please do not make public posts about code changes without first consulting the maintainer of the extension.

Sorry, this was meant to let you know, not for anyone else to make changes. I was getting this conflict in my logs. I just wanted you to be aware, that is all. Sorry for overstepping.

[Farratto]

Sorry, this was meant to let you know, not for anyone else to make changes. I was getting this conflict in my logs. I just wanted you to be aware, that is all. Sorry for overstepping.

These things happen. It's okay.

So you are aware though, these messages are not a conflict. It's just a warning. A conflict will show up as an "error" or lack of function. These warnings occur because the extension is calling templates that are not loaded on that particular system. Extension writers take advantage of this functionality to support other extensions without causing real errors or disfunction. You can safely ignore these warnings. Only pay attention to them if they are paired with dysfunction or an actual error message.

[wrandalljr4]

These things happen. It's okay.

So you are aware though, these messages are not a conflict. It's just a warning. A conflict will show up as an "error" or lack of function. These warnings occur because the extension is calling templates that are not loaded on that particular system. Extension writers take advantage of this functionality to support other extensions without causing real errors or disfunction. You can safely ignore these warnings. Only pay attention to them if they are paired with dysfunction or an actual error message.

Yes, I knew it was not a major issue, but I do not like warnings or errors showing up, so I try to fix them when I can. Right now, we have an extension loaded that is preventing the effect tagging notification from displaying in chat, so I am troubleshooting all of the extensions we currently have loaded.

[Farratto]

Yes, I knew it was not a major issue, but I do not like warnings or errors showing up, so I try to fix them when I can. Right now, we have an extension loaded that is preventing the effect tagging notification from displaying in chat, so I am troubleshooting all of the extensions we currently have loaded.

That's a bummer. Best of luck with that.

[wrandalljr4]

That's a bummer. Best of luck with that.

It was 5e Reaction extension

[metaldm007]

Seems like the big overhaul to Fantasy Grounds has caused an error with the extension. When opening a PCs inventory, I receive the following code in the attached screenshot.
jackofallthingsnewupdate.png

EDIT: The same line of code also pops up when entering the Effects tab on the sheets.

SECOND EDIT: Figured out that it was an incompatibility with older extensions on the Effects tab, particularly bmos' Advanced Spell Damage and Advanced Weapon Damage.

[Farratto]

Seems like the big overhaul to Fantasy Grounds has caused an error with the extension. When opening a PCs inventory, I receive the following code in the attached screenshot.
jackofallthingsnewupdate.png

EDIT: The same line of code also pops up when entering the Effects tab on the sheets.

Thank you for reporting. I'll take a look soon. This was not noticed or reported during the testing phase. Either a late change or just never reported.

[Farratto]

My bad. Apparently I fixed this problem way back when testing was new and then forgot to upload it to forge. It's in the forge now. Please let me know if you have any other problems.

[Speculi]

Is it expected that most of the settings for JoAT seem to be per user instead even though it says (GM) in the headline?