5E - Better Combat Effects Gold

[jfg1984]

Looked at this and while there are a number of ways I could make this work, there is a fundamental change that needs to happen which is more involved and will avoid future similar issues. For now evasion and avoidance are considered broken with ongoing saves in bec and bceg. Sorry for the bad news.

Bummer! But thank you for the feedback. Thankfully avoidance and evasion aren't super common traits that pop up.

[rhagelstrom]

Version Update: 3.19
Fixed: Changed ongoing saves to fall within the pipeline. Fixes Evasion/Avoidance issue. Should also prevent/solve other corner case issues. This is how I wanted to originally implement ongoing saves but at the time I didn't know enough to do it correctly.
Fixed: (E) not working as intended
Removed: Add Prone on unconscious as now native in ruleset
Documentation update: SAVE tags format changed from SAVE: ABILITY (N) to SAVE: (N) ABILITY

On the last point, you can write the Ongoing Save tags either way and it will stay that way for the foreseeable future The new format falls more in line with how FG works so it is highly recommended that the SaveDC be placed before the ability rather than after to avoid any unforeseen issues, which the chance of which I think is small

[jfg1984]

Absolutely awesome.

[jfg1984]

Version Update: 3.19
Fixed: Changed ongoing saves to fall within the pipeline. Fixes Evasion/Avoidance issue. Should also prevent/solve other corner case issues. This is how I wanted to originally implement ongoing saves but at the time I didn't know enough to do it correctly.
Fixed: (E) not working as intended
Removed: Add Prone on unconscious as now native in ruleset
Documentation update: SAVE tags format changed from SAVE: ABILITY (N) to SAVE: (N) ABILITY

On the last point, you can write the Ongoing Save tags either way and it will stay that way for the foreseeable future The new format falls more in line with how FG works so it is highly recommended that the SaveDC be placed before the ability rather than after to avoid any unforeseen issues, which the chance of which I think is small

Just a heads up but when I was briefly looking at this last night it seemed to be not applying damage on failed saving throws to creatures with evasion, as if they had succeeded. I have quite a few other extensions running though so when I get home from work tonight I'll test it in isolation to make sure it's actually an issue localized to BCEG, and if it isn't I'll find which extension it's experiencing the incompatibility with.

[jfg1984]

Alright I tested BCEG in isolation and the evasion interaction worked fine. So then I started testing it with other extensions and isolated the compatibility issue down to something not jiving between BCEG and 5E Indicators, by John Waite & Rob Twohy. I reached out to those guys to see if they can patch it. Thanks and great work.

[rhagelstrom]

Alright I tested BCEG in isolation and the evasion interaction worked fine. So then I started testing it with other extensions and isolated the compatibility issue down to something not jiving between BCEG and 5E Indicators, by John Waite & Rob Twohy. I reached out to those guys to see if they can patch it. Thanks and great work.

I have a hunch this is me. But I actually own 5E Indicators so I'll test it out. Thanks!

Confirmed its me. I'll get a fix in...

[jfg1984]

I have a hunch this is me. But I actually own 5E Indicators so I'll test it out. Thanks!

Confirmed its me. I'll get a fix in...

Cool thank you. Ummm ... also I hate to be sending you more bugs but-
Screenshot 2022-07-28 194819.png

I have a simple ADVSAV: wisdom effect on a character; now it was originally a TREGENA: 5; ADVSAV: wisdom effect so that it gives them the 5 temp points when you add it but that part disappears and you're left with only the advantage to wisdom saves remaining (so that part is working as intended) ... but when I try to make the character roll a wisdom save to test that, I get the error message that you see in the attachment image I included. I disabled all other extensions except for BCEG and still have this error.

Just to be sure I also loaded up the game with no extensions at all, and the ADVSAV: wisdom syntax started working, so I'm pretty sure this is also a BCEG issue.

[rhagelstrom]

No problem. Thanks for the report and I’ll roll it in the same update

[Rhuarc]

EDIT: Just saw that the poster before me has the same problem, so this is just another instance of the same error.

Hey, I just got BCEG but unfortunately encountered an issue when I attempted to roll a saving throw manually from both the PC character sheet or an NPC sheet:
Error Snap.jpg
If I double-click on the save field, nothing happens except for this message. With Drag&Drop into the chat window, the save is rolled but the message is still popping up. No other extensions are enabled.

Any idea what could be the issue? Anyway, thanks for looking into this!

[rhagelstrom]

Version Update: 3.20
Fixed: Script error when rolling save from character sheet
Fixed: Save handler not overridden just registered for