Better Combat Effects

[rhagelstrom]

No, look at the screenshot in the combat tracker. It shows all the effects on everybody. Only "PC1" has the effect "party" on him.

Right so since non of them have party except for PC1 the condition isn't met and the effect won't fire. REGEN didn't fire on Adalet6
REGEN fires on PC1 because it has party. SREGENS won't because that never really made sense to me why code it that way when it should just be REGEN. I can see a use case for aura though so I'll fix that.

[Drogo210]

All the categories Add Effect on Damage Modifiers will add the effect with 'all rolls' even if the effected added was set to roll. This has probably is due the fact that they do not relay on any roll damage. Then it would be nice, if possible, to add something expire on roll for such effects.

I have noticed that STURNRE does not end the effect at the end of your turn but instead at the end of ur next turn.

[rhagelstrom]

All the categories Add Effect on Damage Modifiers will add the effect with 'all rolls' even if the effected added was set to roll. This has probably is due the fact that they do not relay on any roll damage. Then it would be nice, if possible, to add something expire on roll for such effects.

I have noticed that STURNRE does not end the effect at the end of your turn but instead at the end of ur next turn.

Thanks. Yes I noticed the apply to rolls weren't being respected. Look for that in the next version. I tested STURNRE and it is working as intended. It doesn't work if you apply the effect to yourself as it wasn't intended to be used that way just like SREGENS but I'll fix that as well.

[bmos]

Would you mind including some compatibility code for my Ammunition Manager extension?

For 5e, 4e, and 3.5E onAttack functions, change

	Comm.deliverChatMessage(rMessage);

to

	--	bmos adding hit margin tracking
	--	for compatibility with ammunition tracker, add this here in your onAttack function
	if AmmunitionManager then
		local nHitMargin = AmmunitionManager.calculateMargin(nDefenseVal, rAction.nTotal)
		if nHitMargin then table.insert(rAction.aMessages, "[BY " .. nHitMargin .. "+]") end
	end
	--	end bmos adding hit margin tracking

	Comm.deliverChatMessage(rMessage);

	--	bmos adding automatic ammunition ticker and chat messaging
	--	for compatibility with ammunition tracker, add this here in your onAttack function
	if AmmunitionManager and ActorManager.isPC(rSource) then AmmunitionManager.ammoTracker(rSource, rRoll.sDesc, rAction.sResult) end
	--	end bmos adding automatic ammunition ticker and chat messaging

[rhagelstrom]

Would you mind including some compatibility code for my Ammunition Manager extension?

For 5e, 4e, and 3.5E onAttack functions, change

BCE only has its fingers in onAttack in 4E but I'll make a slight mod that should fix it.

[bmos]

BCE only has its fingers in onAttack in 4E but I'll make a slight mod that should fix it.

even better! thank you

[rhagelstrom]

Version update 4.6
Changed effects that act on the source of the effects turn now work when the source is the same as the target
Changed - 4E onAttack to be compatible with bmos Ammunition Manager extension
Fixed 4E effect being applied from Equipped Effects would throw a script error

The apply on rolls issue is a little more complicated than hoped. Still working on that issue.

[eriktedesco]

Hi all!

Would it be possible to open somewhere a thread dedicated to the spell/feats/item etc coding with BCE operators?

I truly suck with this thing so thiw would be a huge help! (pretty much what was done with kent-extension-outsorce in Team Thowy channel on Discord)

What do yu think about it?

Thanks again

[MrDDT]

Even though I use BCE, I use a lot of other EXTs that give me tools to add in effect coding. So for me it wouldn't greatly useful nor would I want to add to it, because of this reason.

Everyone would have to be using the same EXTs (Unless you only want to use BCE coding).

[rhagelstrom]

Version Update 2.7

Fixed a couple of issues that were triggering script errors.