Thread: Potential Ruleset Issues
-
July 13th, 2022, 11:30 #1
Potential Ruleset Issues
I just noticed something about the relatively-new ActionAttack.onAttackResolve in 3.5E (and therefore PFRPG).
It has these two sections that check for variables (nDefenseVal and nAtkEffectsBonus) that are not available within their scope.
Code:if nDefenseVal then rCritConfirmRoll.sDesc = rCritConfirmRoll.sDesc .. " [AC " .. nDefenseVal .. "]"; end if nAtkEffectsBonus and nAtkEffectsBonus ~= 0 then local sFormat = "[" .. Interface.getString("effects_tag") .. " %+d]"; rCritConfirmRoll.sDesc = rCritConfirmRoll.sDesc .. " " .. string.format(sFormat, nAtkEffectsBonus); end
The new ruleset update looks great btw. The new addNPC/addPC stuff is neat.bmos' extensions
he/them
-
July 14th, 2022, 18:21 #2
Supreme Deity
- Join Date
- Mar 2007
- Posts
- 20,559
Thanks for reporting. I'll look at getting these attached to the rRoll table soon.
Regards,
JPG
-
July 15th, 2022, 01:48 #3
Supreme Deity
- Join Date
- Mar 2007
- Posts
- 20,559
This is addressed in the hot fix I just pushed today.
Regards,
JPG
-
July 15th, 2022, 14:03 #4
Awesome, thanks!
Rather than starting another thread, I'll just point out one more here
ActionDamage.applyDamage in 3.5E has a typo. "local nNonLethal" should be "local nNonlethal" as that is how all later uses of this variable are capitalized.
I don't think it's causing any issues, but it's accidentally a global variable.bmos' extensions
he/them
-
July 15th, 2022, 19:09 #5
Supreme Deity
- Join Date
- Mar 2007
- Posts
- 20,559
Thanks, I checked in, so it will be addressed in the next 3.5E push, whenever that happens.
Regards,
JPG
Thread Information
Users Browsing this Thread
There are currently 1 users browsing this thread. (0 members and 1 guests)
Bookmarks