STAR TREK 2d20
Page 3 of 6 First 12345 ... Last
  1. #21
    SoxMax's Avatar
    Join Date
    Mar 2021
    Location
    Massachusetts, USA
    Posts
    154
    Quote Originally Posted by bmos View Post
    Sweet, want to take over maintaining it overall? Looks like you forked kentmccullough's 5E-only version and released this a few days after I took started posting multi-ruleset-supporting versions in his thread.
    I can give you access to the existing mainline repo.

    I took it over 17 days ago and fixed a bunch of bugs and tidied up a lot of the codebase (some of which it looks like you also did), but I don't really have time to give it all the attention it deserves.

    Pretty hilarious that we did this almost in parallel.
    Oh man I didn't realize you'd picked it up too, and you already did all the other things I was planning on doing. This is actually the 2nd time this has happened, since you also fixed up the Advanced Effects extension from rmilmine!

    If you don't want to maintain the aura effects I've no problem taking it over.

  2. #22
    SoxMax's Avatar
    Join Date
    Mar 2021
    Location
    Massachusetts, USA
    Posts
    154
    @tahl_liadon One thing to keep in mind if you just take the original 5E mod wholesale and only change the rulesets it works with the FACTION keyword probably wont work since the extension is explicitly looking for the 5E Effects Manager to do that work. Also the default range calculation gets really broken with non medium sized tokens.

  3. #23
    Quote Originally Posted by SoxMax View Post
    Oh man I didn't realize you'd picked it up too, and you already did all the other things I was planning on doing. This is actually the 2nd time this has happened, since you also fixed up the Advanced Effects extension from rmilmine!

    If you don't want to maintain the aura effects I've no problem taking it over.
    hehe
    If you're interested, go for it. It's great to have other interested PFRPG developers. Also if you want ideas for new extensions you can look at my combo thread which has a wishlist of things I might someday get around to.

    Here is my GitHub which has a bunch of improvements that you might not have yet:
    https://github.com/bmos/FG-Aura-Effect/

    My attempt with the work I've done on it was to include support for 5E, 4E, 3.5E, and PFRPG in one extension. So far I have accomplished this pretty well.
    There is certainly room for improvements in the code (such as re-implementation to use FGU's getTokensWithinDistance function which probably didn't exist yet when the extension was created).
    Last edited by bmos; April 27th, 2021 at 14:33.

  4. #24
    SoxMax's Avatar
    Join Date
    Mar 2021
    Location
    Massachusetts, USA
    Posts
    154
    I was thinking about using getTokensWithinDistance but I think its probably more efficient the way it is now. You still have to check the auras of every combatant since you may step into one. Seems better to just get the distance between the mover and all combatants once.

  5. #25
    I finally updated my FG and this is what I get u.u

    Script Error: [string "scripts/manager_effect_aura.lua"]:382: attempt to call field 'getDistanceBetween' (a nil value)

  6. #26
    Quote Originally Posted by Asgurgolas View Post
    I finally updated my FG and this is what I get u.u

    Script Error: [string "scripts/manager_effect_aura.lua"]:382: attempt to call field 'getDistanceBetween' (a nil value)
    This extension only works in FGU not FGC (the function getDistanceBetween is only for FGU)

  7. #27
    There is an incompatability error with distance calculation with token height extension. See also this post in "combat modifier calculation" extension, pretty sure it is the same problem.
    https://www.fantasygrounds.com/forum...l=1#post596881

    I also reported it in the token height extension:
    https://www.fantasygrounds.com/forum...l=1#post596884
    Here is the reply:
    https://www.fantasygrounds.com/forum...l=1#post596997


    Running latest fantasy grounds unity live version.
    Aura effects - extension v0.9
    token heigh indication v3.0 (https://www.fantasygrounds.com/forum...ight-Indicator)
    no other extensions

    See screenshot for explanation.
    When dealing with larger tokens it looks like it calculates distance from center of token? instead of from the nearest space between tokens. This means that auras with range does not work as intended.
    When measuring (when choosing the alchemical golem in the screenshot and targeting with control the other tokens it measures correctly 5 feet, but this measurement is not the same distance as the aura extension gets from the Token.getDistanceBetween (as seen since it does not apply the auras correctly in the screenshots.


    And to just get messy with linking to other threads that link back to this one, here is my uninformed speculations that I hope might provide hints to what is wrong?
    https://www.fantasygrounds.com/forum...l=1#post597805
    Attached Images Attached Images
    Last edited by Svandal; May 2nd, 2021 at 20:56.

  8. #28
    SoxMax's Avatar
    Join Date
    Mar 2021
    Location
    Massachusetts, USA
    Posts
    154
    @Svandal
    I started looking into this and there's definitely some weird behavior with the Height extension, even when the Height extension is used alone. From what I'm seeing it appears as though there's some problem with changing a character's size in the combat tracker and the Height extension is calculating things off of d20 size of Large, Huge, etc. I'll try and dig into the Height extension and see what's happening, I see GKEnialb mentioned he's doing some special size handling in 5E exclusively: https://www.fantasygrounds.com/forum...l=1#post597815

  9. #29
    Quote Originally Posted by SoxMax View Post
    @Svandal
    I started looking into this and there's definitely some weird behavior with the Height extension, even when the Height extension is used alone. From what I'm seeing it appears as though there's some problem with changing a character's size in the combat tracker and the Height extension is calculating things off of d20 size of Large, Huge, etc. I'll try and dig into the Height extension and see what's happening, I see GKEnialb mentioned he's doing some special size handling in 5E exclusively: https://www.fantasygrounds.com/forum...l=1#post597815
    I added the Pathfinder support to that extension and probably it's not correct.

    see image.lua line 151

  10. #30
    SoxMax's Avatar
    Join Date
    Mar 2021
    Location
    Massachusetts, USA
    Posts
    154
    So I've narrowed it down, it seems to be a problem when using nonstandard pathfinder sizes, but I've updated the non 5E code to be more generic:

    local nSpace = DB.getValue(ctNode, "space");
    sizeMultiplier = ((nSpace / 5) - 1) * 0.5
    if nSpace > 10 and nSpace % 10 > 0 then
    bExact = false
    end
    I'll post in the Height extension thread with this as well

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Bookmarks

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
DICE PACKS BUNDLE

Log in

Log in