Thread: 5E - Token Height Indicator
-
July 20th, 2021, 04:16 #331
-
July 20th, 2021, 04:37 #332
That's an excellent question. The placement between the other two functions is particularly odd. When I was first playing with taking height into account in the range arrow, I was trying different things with the tokens, so it may have been that. I've removed it now (but will wait until there's another reason to update for it to come through).
-
July 20th, 2021, 04:37 #333
-
July 20th, 2021, 06:03 #334
- Join Date
- Mar 2016
- Location
- Bergen
- Posts
- 313
I am posting this here also, a bug report compatability between two extensions.
https://www.fantasygrounds.com/forum...l=1#post611803
These extensions where compatible before, and the other one did not update, only this.
It calls for the positions on each token to get the range between the tokens before each ranged attack, that is when the error occurs.
-
July 20th, 2021, 10:43 #335bmos' extensions
he/them
-
July 20th, 2021, 11:13 #336
- Join Date
- Oct 2019
- Location
- Hong Kong
- Posts
- 310
That might explain something's I've moaned about
I regularly drop tokens for things like backpacks or torches or dancing lights, I guess they dont have a passable (to the functions) token-id if dropped in from art assets, and then it gets confused when trying to work out flanking/height/targetting (extension depending) etc?
-
July 20th, 2021, 14:29 #337
Yeah, when tokens on the image aren't also in the combat tracker, things don't necessarily work really well.
I imagine what's going is something like this::
- In version 4.5, I overrode the Token functions related to distance (before I just did the imagecontrol functions)
- Combat Modifier Calculation Extension uses Token.getTokensWithinDistance
- Token.getTokensWithinDistance only used to return tokens in the combat tracker (I'm speculating here) and Token Height returns all tokens within the distance on the map
- Combat Modifier Calculation Extension doesn't protect against non-combat tracker tokens
If that is what's going on, I can filter the tokens to only return tokens that are in the combat tracker. The big question is whether that's the expected behavior or not - I'd hate to break somebody that does want all tokens within range to be returned. I can run some tests to see what the core behavior is in the next few days, unless anybody knows off the top of their head.
-
July 20th, 2021, 15:48 #338
- Join Date
- Mar 2016
- Location
- Bergen
- Posts
- 313
-
July 20th, 2021, 16:09 #339
That's really good to know. My new theory would be that I return a different type of token than expected - I should be able to track that down pretty easily.
-
July 20th, 2021, 16:10 #340
- Join Date
- Oct 2019
- Location
- Hong Kong
- Posts
- 310
Thread Information
Users Browsing this Thread
There are currently 2 users browsing this thread. (0 members and 2 guests)
Bookmarks