5E Storm Kings Thunder Playlist
Page 11 of 12 First ... 9101112 Last
  1. #101
    Quote Originally Posted by MeAndUnique View Post
    Should be fixed with version 1.2.1, sorry for the inconvenience.
    Tested and working here. Thanks for the quick fix!

  2. #102
    We played with it tonight and one thing that would help, if possible, would be to cut back on the rolling for recharging when there are no charges currently used. We had plenty of time pass and the recharging was happening even though we did not have any missing charges.

    Also, is there a way to control who gets the message? Ideally, it would be the owner and GM and not the whole group. I could not tell who was seeing the messages, so maybe this is already the case?

    Finally, we found a strange corner case. When you use the long rest field to advance the clock and your clock ends up at 6am the recharge kicks off as expected but as soon as the clock moves off of 6am the recharge fires again.

    Either way, thanks for the great extension!

  3. #103
    Quote Originally Posted by nephranka View Post
    We played with it tonight and one thing that would help, if possible, would be to cut back on the rolling for recharging when there are no charges currently used. We had plenty of time pass and the recharging was happening even though we did not have any missing charges.

    Also, is there a way to control who gets the message? Ideally, it would be the owner and GM and not the whole group. I could not tell who was seeing the messages, so maybe this is already the case?

    Finally, we found a strange corner case. When you use the long rest field to advance the clock and your clock ends up at 6am the recharge kicks off as expected but as soon as the clock moves off of 6am the recharge fires again.

    Either way, thanks for the great extension!
    Sure, I'll take a look at cutting down on unnecessary rolling.

    That should be how it works already.

    That's annoying to hear, since I actually attempted to account for that case specifically. Did a bit more testing with it, and I do see this happening some of the time. If you can provide concrete examples for times that you used to advance it would be appreciated.

    Thanks for providing so much feedback so I can keep improving the extension
    My creations: https://github.com/MeAndUnique/FantasyGrounds
    Discord: MeAndUnique#6805

  4. #104
    I will put together some examples.

    Thanks!

  5. #105
    Version 1.2.2 will no longer roll to recharge full charged items. Also includes a potential fix for the bug nephranka mentioned; I'll test further with the examples once they're ready.
    My creations: https://github.com/MeAndUnique/FantasyGrounds
    Discord: MeAndUnique#6805

  6. #106
    I am happy to report the use of the long/short rest and 6am/12noon/6pm/12mid buttons in conjunction with the hour button no longer causes a corner case issue. Also, the charging is no longer happening if the item is fully charged.

    At least I can not get the case to happen in 1.2.2.

    I would note that there were some recent changes to the clock ext due to long/short not working correctly. So maybe the change in that code also did something here? Maybe it is a combination of the 2 or user error

    Thanks!

  7. #107
    Quote Originally Posted by nephranka View Post
    I am happy to report the use of the long/short rest and 6am/12noon/6pm/12mid buttons in conjunction with the hour button no longer causes a corner case issue. Also, the charging is no longer happening if the item is fully charged.

    At least I can not get the case to happen in 1.2.2.

    I would note that there were some recent changes to the clock ext due to long/short not working correctly. So maybe the change in that code also did something here? Maybe it is a combination of the 2 or user error

    Thanks!
    Glad to hear its all sorted.
    Fwiw, there was a bug in 1.2.1 where I had been using too tight of a tolerance in the math, causing some cases where it would overzealously include the starting time due to rounding error (I trusted the Lua docs, which is of course an amateur mistake )
    My creations: https://github.com/MeAndUnique/FantasyGrounds
    Discord: MeAndUnique#6805

  8. #108
    Glad it is back to working!

  9. #109
    Version 1.2.3 is up. Recent ruleset changes broke compatibility with Clock Adjuster for the purposes of recharge based on time of day, and this fixes it.
    My creations: https://github.com/MeAndUnique/FantasyGrounds
    Discord: MeAndUnique#6805

  10. #110

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
Starfinder Playlist

Log in

Log in