DICE PACKS BUNDLE

Thread: Ruleset bug 2

  1. #1

    Ruleset bug 2

    Hi, "guardian of faith", is not showing any "radiant" damage, see attached, because the data_spell.lua file, sets the 'modifier', while the 'code' reads it from 'bonus'... "DB.setValue(nodeEntry, "bonus", "number", vDamage.bonus);" at 1932 in parsePCPower..

    I'm not sure which is wrong !!

    Further down the parsePCPower the damage/heal side from the spell text description side swaps over to using 'modifier' as its source.

    The spell_data.lua documents 'modifier', so maybe its the 'parsePCPower' 1932 line that is wrong ?

    Thanks, Pete
    Attached Images Attached Images

  2. #2
    LordEntrails's Avatar
    Join Date
    May 2015
    Location
    -7 UTC
    Posts
    17,148
    Blog Entries
    9
    What's the source/module? FGC or FGU? How about ruleset? Is this an extension issue?

    Problems? See; How to Report Issues, Bugs & Problems
    On Licensing & Distributing Community Content
    Community Contributions: Gemstones, 5E Quick Ref Decal, Adventure Module Creation, Dungeon Trinkets, Balance Disturbed, Dungeon Room Descriptions
    Note, I am not a SmiteWorks employee or representative, I'm just a user like you.

  3. #3
    This is just 5E with 'player's' handbook loaded, to be able to add the spell to character.. same in FGC, FGU.

    I've attached the FGC campaign.

    -pete
    Attached Files Attached Files

  4. #4
    Zacchaeus's Avatar
    Join Date
    Dec 2014
    Location
    Scotland
    Posts
    20,736
    This is one of the spells where it isn't the parser that is picking up the effects but rather it's in an override database in the ruleset. The error must be in the override since if you copy the spell and change it's name it correctly adds in the damage effect.
    Attached Images Attached Images
    If there is something that you would like to see in Fantasy Grounds that isn't currently part of the software or if there is something you think would improve a ruleset then add your idea here https://www.fantasygrounds.com/featu...rerequests.php

  5. #5
    yes, if you let the 5e rule set use the 'data_spell.lua' you get the zero damage, if you change its name and reparse you get damage but the wrong effect lines.. ( Hence the custom 'data_spell.lua' entry. )

    ["guardian of faith"] = {
    { type = "effect", sName = "NOTE: Guardian of Faith", sTargeting = "self", nDuration = 8, sUnits = "hour" },
    { type = "powersave", save = "dexterity", onmissdamage = "half", magic = true, savebase = "group" },
    { type = "damage", clauses = { { modifier = 20, dmgtype = "radiant" } } },
    },


    Because the 'parsePCPower' in 'manage_power.lua' line 1932 is 'DB.setValue(nodeEntry, "bonus", "number", vDamage.bonus);' and expects the 'vDamage.bonus' while the spell defined uses "{ modifier = 20,"..

    so either, 'data_spell.lua'

    -- { type = "damage", clauses = { { dice = { "d#", ... }, bonus= #, type = "", [stat = ""] }, ... } }
    -- Each damage action can have multiple clauses which can do different damage types


    ["guardian of faith"] = {
    { type = "effect", sName = "NOTE: Guardian of Faith", sTargeting = "self", nDuration = 8, sUnits = "hour" },
    { type = "powersave", save = "dexterity", onmissdamage = "half", magic = true, savebase = "group" },
    { type = "damage", clauses = { { bonus = 20, dmgtype = "radiant" } } },
    },

    is required or, 'manage_power.lua'

    DB.setValue(nodeEntry, "bonus", "number", vDamage.modifier );

    changes in the ruleset might have larger knock on effect for saved data, which is why I said I'm not sure which solution would be the way to go to fix this one..

    ( I suspect { type = "damage", clauses = { { bonus = 20, dmgtype = "radiant" } } } is the best way and the instructions of usage to the top of the file so people dont get confused.. )
    Attached Images Attached Images

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Bookmarks

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
STAR TREK 2d20

Log in

Log in