5e extension - Combat Stats Tracker

[MadNomadGM]

v3 was just released a couple days ago. If you haven't seen this exstention since it first came out, check out this new video showing its current state.
https://youtu.be/C--8jrdKLjc

[DM_BK]

This extension:
https://www.fantasygrounds.com/forum...rary-hitpoints
Is causing this error in FGU (when an NPC damages a PC):
Script Error: [string "scripts/manager_stats_MNM.lua"]:848: bad argument #3 to 'gsub' (string/function/table expected)

It would be super cool if that wasn't happening. Though I understand, you can't make all your extensions compatible with every ext out there in the wild.

One feature I wouldn't mind seeing, is an option to turn off NPC data collection. I assume that's going into dm.xml which is likely eventually going to cause some additional growth into the file... I dunno how much but I really personally don't care about the NPC stats.

Thanks! Love this extension!

[Klandare]

This extension:
https://www.fantasygrounds.com/forum...rary-hitpoints
Is causing this error in FGU (when an NPC damages a PC):
Script Error: [string "scripts/manager_stats_MNM.lua"]:848: bad argument #3 to 'gsub' (string/function/table expected)

It would be super cool if that wasn't happening. Though I understand, you can't make all your extensions compatible with every ext out there in the wild.

One feature I wouldn't mind seeing, is an option to turn off NPC data collection. I assume that's going into dm.xml which is likely eventually going to cause some additional growth into the file... I dunno how much but I really personally don't care about the NPC stats.

Thanks! Love this extension!

I don't have that other extension but am also hitting that error (thanks for identifying which of my extensions was causing it). I am wondering if this needs have a different load order value.

[SilentRuin]

I don't have that other extension but am also hitting that error (thanks for identifying which of my extensions was causing it). I am wondering if this needs have a different load order value.

This was not just "an extension". The code was doing a DB.getValue without providing a default - which means it would return nil if it could not find the nodePC "name", causing the third argument of the message routine to fail. Defensive programming for unknown situations and timing issues (which do happen in FGU) should be that you never depend on something coming back with a value. You can fix your own version (as I've had to rewrite it to allow my own extension to be able to take advantage of stats) by simply providing the "" 3rd argument to DB.getValue so it returns a blank instead of nil if nothing is there. You'll get a message with no name in the text but its better than blowing up on you.

[Klandare]

This was not just "an extension". The code was doing a DB.getValue without providing a default - which means it would return nil if it could not find the nodePC "name", causing the third argument of the message routine to fail. Defensive programming for unknown situations and timing issues (which do happen in FGU) should be that you never depend on something coming back with a value. You can fix your own version (as I've had to rewrite it to allow my own extension to be able to take advantage of stats) by simply providing the "" 3rd argument to DB.getValue so it returns a blank instead of nil if nothing is there. You'll get a message with no name in the text but its better than blowing up on you.

Which file inside the extension is the issue? And are you saying just look for the 3rd listing of DB.getValue and where it currently is likely "" then put something like " " ?

[SilentRuin]

Which file inside the extension is the issue? And are you saying just look for the 3rd listing of DB.getValue and where it currently is likely "" then put something like " " ?

I'm not sure what your asking here. Are you saying you don't have the log referenced earlier?

Script Error: [string "scripts/manager_stats_MNM.lua"]:848: bad argument #3 to 'gsub' (string/function/table expected)

I mean that is the file. That is the exact line number in the file. I admit I fixed all the missing 3rd arguements of DB.getValue for "name" in that file so that when they built their respective messages they could never blow up on me. For example...

	local messageText=string.gsub(DB.getValue(nodeMsg,"bestDmgMsg"),"NAME",DB.getValue(nodePC,"name", ""));

It will not fix the issue - but I'm lazy - this will insure it does not blow up. As this error seems to only happen for me when some existing resource is missing or lost (like a module not loaded or no longer present in campaign DB).

A cleaner fix would be to never even show/build the message if the name was not available, but like I said, I'm lazy.

[Klandare]

I'm not sure what your asking here. Are you saying you don't have the log referenced earlier?

Script Error: [string "scripts/manager_stats_MNM.lua"]:848: bad argument #3 to 'gsub' (string/function/table expected)

I mean that is the file. That is the exact line number in the file. I admit I fixed all the missing 3rd arguements of DB.getValue for "name" in that file so that when they built their respective messages they could never blow up on me. For example...

	local messageText=string.gsub(DB.getValue(nodeMsg,"bestDmgMsg"),"NAME",DB.getValue(nodePC,"name", ""));

It will not fix the issue - but I'm lazy - this will insure it does not blow up. As this error seems to only happen for me when some existing resource is missing or lost (like a module not loaded or no longer present in campaign DB).

A cleaner fix would be to never even show/build the message if the name was not available, but like I said, I'm lazy.

ok makes sense to me now. will teach me to start doing replies without enough coffee in me.

thanks for the help

[Atracious]

Is there a way to reset the stats? did a session 0 one-shot and then some fiddling afterwards, and want a clean slate. Or if I can remove NPC's entries from the party sheet list maybe?

[Mad Nomad]

Is there a way to reset the stats? did a session 0 one-shot and then some fiddling afterwards, and want a clean slate. Or if I can remove NPC's entries from the party sheet list maybe?

There is an unlock button and after clicking that the GM can manually override any stat. Also if you right click on any noc row you can delete that row.
If you are using latest version anyway.

[The Decepticon]

Hi, I am getting the following error when loading this extension. Not game breaking by any means but it is there.

Screenshot (12).png