1. #1

    PFRPG2 Extension - Save Result Description Clarification

    This extension makes the save descriptions somewhat more clear. By appending the name of the person who made the save to the result.
    Attached Images Attached Images
    Attached Files Attached Files
    Last edited by Willot; March 29th, 2020 at 20:44.
    "The small town of Swampspittle is a charming reminder of how Faerun use to be.Plague victims crawl eloquently down it's dung filled streets; greasing the way with puss from thier buboes.While at least two children a week are burnt at the stake as changelings in the handsome market square. The town boasts two taverns, one humourous dwarf and a shop that sells little things made of straw."

  2. #2
    Trenloe's Avatar
    Join Date
    May 2011
    Location
    Newcastle, UK (for a bit)
    Posts
    26,063
    I've moved this to it's own thread - so that people can discuss, etc. here.

    Thanks for making and posting the extension.

    Please take the following as constructive feedback and not negative criticism. I notice that you've included the whole manager_action_save file in the extension. This is a file that will change over the coming months, so I'd recommend you don't include the whole file but use function overrides to change only the functions you've modified. This won't make it upgrade proof, but it will reduce the possibility of future clashes.

    I've made a couple of changes in the attached files:
    1) Added an <announcement> tag to extension.xml - this will make an announcement to the chat window when it loads. This is really handy to track versions over time and let people know your extension is (or isn't) loaded.
    2) Made the change I mentioned above - override ActionSave.applySave with the custom applySave function.

    Take a look and see if you're OK with the changes - if not I'll remove the extension.
    Attached Files Attached Files
    FG Con 16 Fantasy Grounds Online RPG Convention - Postponed New date To Be Confirmed.
    Register at www.fg-con.com for all the latest info.

    Private Messages: My inbox is forever filling up with PMs. Please don't send me PMs unless they are actually private/personal messages. General FG questions should be asked in the forums - don't be afraid, the FG community don't bite and you're giving everyone the chance to respond and learn!

  3. #3
    Looks good, I have changed my attached version to yours.
    Last edited by Willot; March 29th, 2020 at 20:45.
    "The small town of Swampspittle is a charming reminder of how Faerun use to be.Plague victims crawl eloquently down it's dung filled streets; greasing the way with puss from thier buboes.While at least two children a week are burnt at the stake as changelings in the handsome market square. The town boasts two taverns, one humourous dwarf and a shop that sells little things made of straw."

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
Joshua Stream Pre

Log in

Log in