Thread: Noto Sans based Fonts Extension
-
January 2nd, 2020, 15:25 #11
Oh, now I understand what you mean. I'm not familiar with good form, but I figure that announcement tags are good for clarifying what version of your extension is loaded. That way users don't have to unpack your extension to figure out if they should upgrade it or not - they can just load it.
-
January 2nd, 2020, 15:25 #12
That is "generally" considered "bad form" to list a crapload of rulesets unless there is a very specific reason to do so. For official DLC, SmiteWorks doesn't want us listing any more than two rulesets, for example. Mind you, you're fine doing it this way but it just means you have to update every time a new ruleset comes out or you find one you didn't know about. Just sticking a single line with Any solves that (as does omitting the ruleset line altogether, I just personally like to have it there so I can see that it was something I considered when looking at the code later) and since this is just a font swap that could benefit everyone regardless of ruleset, I'd say the KISS principle would apply to cut down the amount of effort you have to do.
Also, regarding the announcement, bare minimum at least put some acknowledgment that Noto Sans Font Extention v1.x is loaded. When doing tech support/troubleshooting for users, one of the first things we have to ask is "what extensions do you have loaded?" so having that in the chat makes it easy for the users to answer that.
-
January 2nd, 2020, 15:31 #13
Thank you to Talyn and MooCow for your explanations. I'll get a versioning comment added in and will clean up that rulesets list in my version of the theme.
-
January 2nd, 2020, 16:19 #14
I'd recommend using the announcement for version tracking and also to include a Smiteworks copyright notice if you've used any of the base SmiteWorks code. For example, from the CoreRPG ruleset:
Code:<announcement text="CoreRPG ruleset v3.3.9 for Fantasy Grounds\rCopyright 2019 Smiteworks USA, LLC" font="emotefont" icon="rulesetlogo_CoreRPG" />
Private Messages: My inbox is forever filling up with PMs. Please don't send me PMs unless they are actually private/personal messages. General FG questions should be asked in the forums - don't be afraid, the FG community don't bite and you're giving everyone the chance to respond and learn!
-
January 2nd, 2020, 16:42 #15
Thank you, Trenloe, for linking to the refdoc. So far I've been making my fast and furious changes based on existing work without slowing down to find the relevant docs, yet. This will help.
-
January 2nd, 2020, 22:23 #16
-
January 2nd, 2020, 22:28 #17
- Join Date
- Jan 2014
- Location
- California
- Posts
- 1,564
I would also think that the announcement might be a good place to put that the font is used under license from (licensor).
Thread Information
Users Browsing this Thread
There are currently 1 users browsing this thread. (0 members and 1 guests)
Bookmarks