Page 4 of 4 First ... 234
  1. #31
    Trenloe's Avatar
    Join Date
    May 2011
    Location
    Denver, Colorado, USA (for a bit)
    Posts
    24,445
    Quote Originally Posted by HoloGnome View Post
    There is actually another bug here. FG does not correctly translate the NPC text "Magic Resistance" in the NPC Damage Resistances field when dragging the NPC to the combat tracker.
    AS I mentioned in post #23 above: "The "Magic Resistance" condition is added to a NPC when it is added into the combat tracker if it has a power name of "magic resistance", as part of the parseNPCPower function."

    It doesn't work if Magic Resistance is in the NPC Damage Resistances field - because, having it in that field seems to suggest a resistance to damage, hence why it is parsed as RESIST:magic - which gives damage resistance to magic damage types, because the data is in the Damage Resistances field. Can you give examples of the creatures that have this possibly incorrect data placement?
    Last edited by Trenloe; January 13th, 2020 at 23:53.
    FG Con 16 Fantasy Grounds Online RPG Convention - Friday April 24th to Sunday April 26th, 2020
    Register at www.fg-con.com for all the latest info.

    Private Messages: My inbox is forever filling up with PMs. Please don't send me PMs unless they are actually private/personal messages. General FG questions should be asked in the forums - don't be afraid, the FG community don't bite and you're giving everyone the chance to respond and learn!

  2. #32
    See my previous post. Yes, it works, but only if "Magic Resistance" is defined as a trait. I didn't realize that that was how it worked. From a usability standpoint, I made the (incorrect, but more usable) assumption that I could put resistance effects in the NPC resistance field and they would be copied or translated as needed. "Magic Resistance" is a key effect term, and when it is in the resistance field, it might be helpful if it were transferred directly to the CT unmodified, regardless of the fact that it is not a type of "damage resistance" (but rather conferring advantage on saves).
    FG Wish List - http://fg2app.idea.informer.com/
    License: Ultimate [Unlicensed/Free Trial FG users can play in my games]
    Teamspeak: ts.fg-con.com (alternate server in case of trouble: voice.fg-con.com)
    Password: Dungeoneers
    FG Server Alias: cold wand bold fang

  3. #33
    LordEntrails's Avatar
    Join Date
    May 2015
    Location
    GMT -7
    Posts
    8,621
    Blog Entries
    9
    Magic Resistance is somewhat unique. Just one of those things (like Spellcasting Trait) that you have to know how to use.

    Current Projects: Ultimate Undermountain (NYDUM)
    Community Contributions: Gemstones, 5E Quick Ref Decal, Adventure Module Creation, Dungeon Trinkets
    DMsGuild Content: Balance Disturbed (Adventure), Dungeon Room Descriptions
    FG Product Reviews: Virtual Scribe Reviews

  4. #34
    I understand...but the parser could also easily recognize it as key text and just do the right thing.
    FG Wish List - http://fg2app.idea.informer.com/
    License: Ultimate [Unlicensed/Free Trial FG users can play in my games]
    Teamspeak: ts.fg-con.com (alternate server in case of trouble: voice.fg-con.com)
    Password: Dungeoneers
    FG Server Alias: cold wand bold fang

  5. #35
    Trenloe's Avatar
    Join Date
    May 2011
    Location
    Denver, Colorado, USA (for a bit)
    Posts
    24,445
    The 5E parser is not generic across all data fields. The FG code has specific parser logic for specific fields within a record. It can’t possibly be coded to expect a bunch of key terms in incorrect places.
    FG Con 16 Fantasy Grounds Online RPG Convention - Friday April 24th to Sunday April 26th, 2020
    Register at www.fg-con.com for all the latest info.

    Private Messages: My inbox is forever filling up with PMs. Please don't send me PMs unless they are actually private/personal messages. General FG questions should be asked in the forums - don't be afraid, the FG community don't bite and you're giving everyone the chance to respond and learn!

  6. #36
    Quote Originally Posted by Trenloe View Post
    The 5E parser is not generic across all data fields. The FG code has specific parser logic for specific fields within a record. It can’t possibly be coded to expect a bunch of key terms in incorrect places.
    So...my suggestion wasn't for infinite flexibility, but even just using a sorted list/lookup with a single table, it would be a simple software engineering task and not overly slow on lookups. The list of effect keys is not that long. However, in this case, the suggestion was just to add recognition for "Magic Resistance" in the resistance field so it doesn't incorrectly convert it to RESIST:magic, which is a trivial fix/addition.
    FG Wish List - http://fg2app.idea.informer.com/
    License: Ultimate [Unlicensed/Free Trial FG users can play in my games]
    Teamspeak: ts.fg-con.com (alternate server in case of trouble: voice.fg-con.com)
    Password: Dungeoneers
    FG Server Alias: cold wand bold fang

  7. #37
    LordEntrails's Avatar
    Join Date
    May 2015
    Location
    GMT -7
    Posts
    8,621
    Blog Entries
    9
    Add it to the wishlist if it doesn't already exist. If it does, vote on it

    Current Projects: Ultimate Undermountain (NYDUM)
    Community Contributions: Gemstones, 5E Quick Ref Decal, Adventure Module Creation, Dungeon Trinkets
    DMsGuild Content: Balance Disturbed (Adventure), Dungeon Room Descriptions
    FG Product Reviews: Virtual Scribe Reviews

  8. #38
    I wish that someone would take 10 seconds and add another key pair to the resistance field lookup. Otherwise, I know how it works now, so I will be using the trait name.
    FG Wish List - http://fg2app.idea.informer.com/
    License: Ultimate [Unlicensed/Free Trial FG users can play in my games]
    Teamspeak: ts.fg-con.com (alternate server in case of trouble: voice.fg-con.com)
    Password: Dungeoneers
    FG Server Alias: cold wand bold fang

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  

Log in

Log in