Page 3 of 3 First 123
  1. #21
    In checkFeatAdjustments, the first check is for the phrase "Increase your X score by Y to a maximum of Z" that one seems to work fine for various values of Y.

    It also does checks for the following phrases for ability score modifications. In each case, it ignores the value of Y in the text, and is hard coded to adjust the stat by 1, even if Y is not 1.
    "Increase your W or X score by Y, to a maximum of Z"
    "Increase your V, W, or X score by Y, to a maximum of Z"
    "Increase your U, V, W, or X score by Y, to a maximum of Z"
    "Increase the chosen ability score by Y, to a maximum of Z"

  2. #22
    Samarex/deer_buster,
    Thanks for the clarification; I'll take a look.

    mattekure,
    I'm not seeing that as an issue just looking at the code. The "1" in the third parameter position of the onAbilitySelectDialog indicates that the user gets one pick, and the next parameter is the ability adjustment. Are you seeing a specific example that's failing, so that I can check to see what is happening?

    Regards,
    JPG

  3. #23
    Here is an example of the issue. Create a feat using the phrase "Increase your Strength or Dexterity score by 4, to a maximum of 20." it opens the dialog box to select a score. but the number added is not 4, its just 1.

    Screenshot_3.jpg

  4. #24
    Thanks for the help everyone.

    Updates
    • [CoreRPG+] setTab function in tabs template was not hiding old controls correctly. Fixed.
    • [PFRPG/3.5E] AC bonuses from effects with same type did not correctly apply only largest bonus. Fixed.
    • [5E] Feats that allowed selection of an ability score to increase by more than one, would only add one. Fixed.
    Last edited by Moon Wizard; Today at 05:24.

  5. #25
    Kelrugem's Avatar
    Join Date
    Sep 2018
    Location
    Geneva, Switzerland, and Lyon, France
    Posts
    617
    Quote Originally Posted by Moon Wizard View Post
    Thanks for the help everyone.

    Updates
    • [CoreRPG+] setTab function in tabs template was not hiding old controls correctly. Fixed.
    • [PFRPG/3.5E] AC bonuses from effects with same type did not correctly apply only largest bonus. Fixed.
    • [5E] Feats that adjusted contained selecting an ability score increase by more than one, would only add one. Fixed.
    Thank you

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  

Log in

Log in