5e Bug Reports (Part 4)

[Gothstaff]

Can you be more specific as to what is wrong with it? I don't see anything.

Please click at the "Tomb 6.Decal.JPG" link/attachment, you'll see it right away.

[Gothstaff]

The image used is the same one that's on the cover for ToA and that and the decal are exactly as they appear in the original .psd file provided by WotC. Therefore it's meant to be like that.

I see... the image was made for the cover including the spine and some adjustment there... and likely due to copyright claims you cannot or rather not modify the image...
Well, that sucks

[Zacchaeus]

I see... the image was made for the cover including the spine and some adjustment there... and likely due to copyright claims you cannot or rather not modify the image...
Well, that sucks

You got me thinking so I went back and dug around in the original files again and i’ve found the non cover version of the cover image so i’ll see about updating it. I had never noticed that it was strange until you pointed it out.

[deer_buster]

I think there is an issue with rolling criticals when Fixed NPC rolls is set. If I have a damage of 2d10+7 piercing + 1d12 lightning, which when not a critical gives me 18 piercing and 6 lightning, I should be getting 18 piercing

+2d10 piercing critical +

6 lighting+1d12 lightning critical on a critical. Instead I get 13 piercing +16 piercing critical +1d12 lighting+1d12 lightning critical.

I do not have any critical extensions applied....

[deer_buster]

Note, for testing, I used an Adult Blue Dragon, and changed the Bite to have 1d12 lightning damage instead of 1d10 to ensure I would notice if the right dice were being used.

[Zacchaeus]

I think there is an issue with rolling criticals when Fixed NPC rolls is set. If I have a damage of 2d10+7 piercing + 1d12 lightning, which when not a critical gives me 18 piercing and 6 lightning, I should be getting 18 piercing

+2d10 piercing critical +

6 lighting+1d12 lightning critical on a critical. Instead I get 13 piercing +16 piercing critical +1d12 lighting+1d12 lightning critical.

I do not have any critical extensions applied....

I'll make sure someone who can do something about that knows.

I did a simpler test with a random NPC who did 1d4 bludgeoning and 1d8 fire damage. I note that on a critical both dice rolls are 8's instead of a 4 and an 8.

[deer_buster]

Was going to say I saw the reason, but not sure yet.

EDIT: Ah, yes, when it inserts the clauses into aNewClauses in the handle critical section, it does so sequentially ({1, piercing},{2, piercing critical},{3, lightning},{4,lightning critical}), so it actually uses fixed damage for the piercing and piercing critical, and rolls for the lightning and lightning damage, incorrectly.

[deer_buster]

Perhaps a solution is to change line manager_action_damage.lua:363

from: if kClause <= nPreEffectClauses then
to: if not string.match(vClause.dmgtype, ".critical") then

[Zacchaeus]

Perhaps a solution is to change line manager_action_damage.lua:363

from: if kClause <= nPreEffectClauses then
to: if not string.match(vClause.dmgtype, ".critical") then

I'll take your word for it but I'm sure Moon Wizard will know.

[deer_buster]

I'll take your word for it but I'm sure Moon Wizard will know.

Any response from the god of code?