Page 1 of 2 12 Last
  1. #1
    Minty23185Fresh's Avatar
    Join Date
    Dec 2015
    Location
    NV, USA
    Posts
    625
    Blog Entries
    29

    Incorrect Handling of Effects on a "Half on Success"

    For spells that deal both damage and an effect, and that dole out half damage on a successful saving throw, the effect that is applied is improperly handled by Fantasy Grounds. An example is the Sunbeam spell. When the spell is cast, targets get to make a saving throw, those that fail take full damage and are blinded. Those that succeed their saving throw take half damage and are not blinded.

    Fantasy Grounds properly handles the damage part, but applies the effect (in the example, being blinded) to all targets whether they successfully saved or not.

    In the attached screenshot, the Wizard is casting the Sunbeam spell at three ogres. As shown in the character sheet (on the right side of the screenshot) the ogres are allowed a constitution saving throw. The spell has both a damage component and an effect component.

    As shown in the chat subwindow, on the left side, from top to bottom: (1) The ogres make their saving throws, Ogre 1 and Ogre 3 are successful, Ogre 2 is not. (2) Ogres 1 and 3 take half damage, Ogre 2 takes full damage. (3) All ogres are blinded, which is incorrect per the spell parameters.

    I could not find an extension that remedies this so I have been working on one. Before I finish it up and post it, is this slated to be fixed in an upcoming release?

    HalfOnSuccess-Fails.png
    Current Projects:
    5E Druid Wild Shapes Implementor (Extension)
    Local Dice Tower (Extension)
    Community Contributions:
    Catalog of Forum Threads Related to PDF conversion to FG Module
    Field Filters for All Libraries (Extension)
    "A Neophyte Tackles the FG Extension" - A tutorial blog series.

  2. #2
    Trenloe's Avatar
    Join Date
    May 2011
    Location
    Denver, Colorado, USA (for a bit)
    Posts
    22,624
    When an action is set with Damage = "Half on Success" the creatures that fail the save are not removed from the FG targeting - so that damage can be applied correctly to all of the original targets (full or half).

    When you then apply a non damage effect it is applied to all current targets. Which is all of the original targets due to the half on success damage setting.

    This is an edge case where there is an additional effect/condition on top of the "Half on success" damage and will have to be manually handled.

    Good luck with writing an extension for this - as subsequent damage/effects are asynchronous (i.e. additional actions after the save), it could be quite challenging to code reliably to cover all possible scenarios and the initiation order of various actions


    FG Product Development status: Pathfinder Playtest Ruleset and add-ons: In development. Pathfinder Bestiary, Pathfinder Bestiary 2, Pathfinder Bestiary 3 (in store).

    Private Messages: My inbox is forever filling up with PMs. Please don't send me PMs unless they are actually private/personal messages. General FG questions should be asked in the forums - don't be afraid, the FG community don't bite and you're giving everyone the chance to respond and learn!

  3. #3
    Minty23185Fresh's Avatar
    Join Date
    Dec 2015
    Location
    NV, USA
    Posts
    625
    Blog Entries
    29
    Quote Originally Posted by Trenloe View Post
    ... Good luck with writing an extension for this - as subsequent damage/effects are asynchronous (i.e. additional actions after the save), it could be quite challenging to code reliably to cover all possible scenarios and the initiation order of various actions
    Yikes... Last time I tried to write an extension (EVOE) after a warning like that from you guys I found myself so far out to sea that I finally had to scuttle the boat. I thought I was nearly done with the extension and about ready to post it. Now I find myself reluctant to take the helm..
    Last edited by Minty23185Fresh; September 2nd, 2017 at 01:35. Reason: Oops! the word is scuttle, not shuttle! And to think, Im a sailor!

  4. #4
    Trenloe's Avatar
    Join Date
    May 2011
    Location
    Denver, Colorado, USA (for a bit)
    Posts
    22,624
    Quote Originally Posted by Minty23185Fresh View Post
    I thought I was nearly done with the extension and about ready to post it. Now I find myself reluctant to take the helm..
    Hey, if you think you're nearly done then finish it up and post it. I'm hoping you've found a cool way of handling this.


    FG Product Development status: Pathfinder Playtest Ruleset and add-ons: In development. Pathfinder Bestiary, Pathfinder Bestiary 2, Pathfinder Bestiary 3 (in store).

    Private Messages: My inbox is forever filling up with PMs. Please don't send me PMs unless they are actually private/personal messages. General FG questions should be asked in the forums - don't be afraid, the FG community don't bite and you're giving everyone the chance to respond and learn!

  5. #5
    This thread actually just sparked a random thought. Maybe I can just have the ruleset remove the targets when half damage applied/evaded?

    JPG

  6. #6
    Trenloe's Avatar
    Join Date
    May 2011
    Location
    Denver, Colorado, USA (for a bit)
    Posts
    22,624
    Quote Originally Posted by Moon Wizard View Post
    This thread actually just sparked a random thought. Maybe I can just have the ruleset remove the targets when half damage applied/evaded?
    That would probably work. As long as damage was the first action applied after the save - which was kinda what I was eluding to above when I mentioned "the initiation order of various actions" being a potential issue.


    FG Product Development status: Pathfinder Playtest Ruleset and add-ons: In development. Pathfinder Bestiary, Pathfinder Bestiary 2, Pathfinder Bestiary 3 (in store).

    Private Messages: My inbox is forever filling up with PMs. Please don't send me PMs unless they are actually private/personal messages. General FG questions should be asked in the forums - don't be afraid, the FG community don't bite and you're giving everyone the chance to respond and learn!

  7. #7
    Zacchaeus's Avatar
    Join Date
    Dec 2014
    Location
    Scotland
    Posts
    10,615
    I can't think of any situation where such a removal would cause an issue.
    If there is something that you would like to see in Fantasy Grounds that isn't currently part of the software or if there is something you think would improve a ruleset then add your idea to the wish list http://fg2app.idea.informer.com/

  8. #8
    Minty23185Fresh's Avatar
    Join Date
    Dec 2015
    Location
    NV, USA
    Posts
    625
    Blog Entries
    29
    Quote Originally Posted by Moon Wizard View Post
    This thread actually just sparked a random thought. Maybe I can just have the ruleset remove the targets when half damage applied/evaded?JPG
    My only complaint would be inconsistent behavior between the two buttons.
    The Damage (Dmg) would not clear the unaffected targets.
    But the Effect (Eff) button would.

    Plus if someone applied the Effect first then the damage button would not work right (as Trenloe mentions).
    Last edited by Minty23185Fresh; September 2nd, 2017 at 00:47. Reason: spelling error (missed "n't" and credit to Trenloe)
    Current Projects:
    5E Druid Wild Shapes Implementor (Extension)
    Local Dice Tower (Extension)
    Community Contributions:
    Catalog of Forum Threads Related to PDF conversion to FG Module
    Field Filters for All Libraries (Extension)
    "A Neophyte Tackles the FG Extension" - A tutorial blog series.

  9. #9
    Minty23185Fresh's Avatar
    Join Date
    Dec 2015
    Location
    NV, USA
    Posts
    625
    Blog Entries
    29
    I just posted my extension (here).

    I followed the exact methodology that is currently (FG v3.3.2) used in the ruleset code to handle the damage to handle the effect application.

    It took me about 2 weeks (~ 40-60 hours) to completely dissect the code and thoroughly understand it, then about 6 hours to develop the extension.
    Last edited by Minty23185Fresh; September 2nd, 2017 at 00:39. Reason: minor grammer and spelling errors
    Current Projects:
    5E Druid Wild Shapes Implementor (Extension)
    Local Dice Tower (Extension)
    Community Contributions:
    Catalog of Forum Threads Related to PDF conversion to FG Module
    Field Filters for All Libraries (Extension)
    "A Neophyte Tackles the FG Extension" - A tutorial blog series.

  10. #10
    Nylanfs's Avatar
    Join Date
    Sep 2007
    Location
    Northern Indiana, USA
    Posts
    2,978
    Careful, that way lays madness...
    Paul Grosse
    PCGen BoD
    PR Silverback

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  

Log in

Log in