Character Vitality and Improved Criticals

[trembot_89]

Okily Dokily (in the immortal words of Ned Flanders) v10 is a go and as of today functions perfectly with the current ruleset.

[thomnoland]

Thank you! No more errors! You ROCK!

[Nylanfs]

(in the immortal words of Ned Flanders)

Okilly Dokilly?

[trembot_89]

Okilly Dokilly?

Hahaha, awesome. lml

[paladiusdarkhelm]

Does this one need a compatibility update for FG 3.3.7 like the 3.5 version did? Thanks!

[Trenloe]

Does this one need a compatibility update for FG 3.3.7 like the 3.5 version did? Thanks!

Just as an FYI - many community developers (myself included) will not produce compatibility updates for test versions, only for live FG versions. v3.3.7 is currently in test and is undergoing regular changes. Having said that, it's up to each community developer what they do with their extensions...

[TheoGeek]

Hey Trembot!

I updated my Improved Critical script (refactored the code and added a cool icon by Glassstaff). The code refactor may allow it to work "out of the box" with the Vitality extension, but I'm not sure how to test that to see if it works.

Basically, I removed all "copied-n-pasted" code from ActionDamage.onDamageRoll and added a call to that function in the event that the ImprovedCritical mod is "off" or a critical is not rolled. Basically the "ImprovedCritical" code only executes if a critical damage is taken, and no "core" code is overridden.

I don't know how many other changes you've made to integrate these mods, but I'd like to see if the Vitality mod and the ImprovedCritical mod can be included together now without stepping on each other.

Thanks!

[trembot_89]

Hey Trembot!

I updated my Improved Critical script (refactored the code and added a cool icon by Glassstaff). The code refactor may allow it to work "out of the box" with the Vitality extension, but I'm not sure how to test that to see if it works.

Basically, I removed all "copied-n-pasted" code from ActionDamage.onDamageRoll and added a call to that function in the event that the ImprovedCritical mod is "off" or a critical is not rolled. Basically the "ImprovedCritical" code only executes if a critical damage is taken, and no "core" code is overridden.

I don't know how many other changes you've made to integrate these mods, but I'd like to see if the Vitality mod and the ImprovedCritical mod can be included together now without stepping on each other.

Thanks!

Excellent! I'll take a look and try to bring it up to date, thank you for your hard work!

[TheoGeek]

Awesome! Hopefully, both can be independent now so you don't have to keep integrating them whenever something changes.

[Frank_Jager]

Hi Trembot_89

Any chance you'll be releasing this Extension for the latest version of FG? Also this extension appears to be causing issues with Combat Extended.
I was hoping you would have a small amount of time to make these compatible? Or for you to point me in the right direction for doing so?