New Extension: TheoGeek's Improved Critical

[kentmccullough]

That would be it, here's how I handle this kind of thing...

local onDamageRoll = nil;
local getEffectsByType = nil;

function onInit()

	getEffectsByType = EffectManager5E.getEffectsByType;
	EffectManager5E.getEffectsByType = customGetEffectsByType;

	onDamageRoll = ActionDamage.onDamageRoll;
	ActionDamage.onDamageRoll = customOnDamageRoll;
	
	ActionsManager.registerPostRollHandler("damage", ActionDamage.onDamageRoll);
end

I then call the original (stored as a local) from within my custom function. Either before or after, whichever is appropriate.

[TheoGeek]

Cool. I'll try that. I coded my extension a long time ago when I was just learning FG and LUA, and never really went back to fix that stuff. I may need help.

[kentmccullough]

Let me know if there's anything you need, we'll make this work

[TheoGeek]

Let me know if there's anything you need, we'll make this work

We made it work! Thanks kentmccullough!

Try out the new versions of our extensions (Improved Critical's is now 3.0 on the first post of this thread).

[Broadcast Bard]

Just wanted to confirm, it's fixed.

[TheoGeek]

Just wanted to confirm, it's fixed.

Excellent!

[Darkrin]

I didn't read through all 11 pages but I was wondering is the extension able to max the first damage die on a crit and roll the rest? or is that even possible?

[Beemanpat]

If I remember correctly you can max damage die or crit die or both.

[Darkrin]

thank you Beeman

[TheoGeek]

I didn't read through all 11 pages but I was wondering is the extension able to max the first damage die on a crit and roll the rest? or is that even possible?

I'm assuming that you are asking if the extension can do the following:

"If the weapon damage does 2d6, on a crit, can I max 1d6 and roll 3d6?"

If that's what you are asking, then no, it does not do that.

It can do the following:

1. max weapon normal damage and roll critical damage
2. roll weapon damage and max critical damage
3. max both normal and critical damage
4. ignore critical damage if target is crit immune
5. ignore critical damage altogether

In 5e, a critical hit doubles the damage dice that are rolled, so a crit with a standard 2d6 damage weapon does 2d6 normal damage and 2d6 critical damage - there isn't really a concept of "the first damage die of a weapon with 2 damage dice", but that's an interesting idea. If that's what you are asking, I can look into it.