-
@Tideturner
Thank you for the bug report. Both issues have been resolved in the latest patch coming out now.
-
5e Combat Enhancer version 1.5.1 released.
v1.5.1 (March 15th, 2019) (patch)
- New flanking modifier options for menu. Off/Advantage/+2/+5. [5e_combat_enhancer: registerMenuItems, manager_action_attack: modAttack]
- Bug fix: Pinging map didn't work. Fixed. [manager_ping.lua: doPing (fixed image path)]
- Bug fix: Blood splatter size scaling issues. Fixed. Menu options changed to re-balance to changes. [scripts/manager_token2.lua: createSplatter, 5e_combat_enhancer.lua: registerMenuItems]
FG Core Token Helper version v1.1.1 released.
v1.1.0 (March 15th, 2019)
- Include medium and long range numbers cut off numbers in distance calculations (<= instead of <) [scripts/ranged_attacks: getRangeModifier5e]
- Automatic range modifiers code now includes ranged spells that have an Attack Roll (ATK) as well. [scripts/ranged_attacks.lua: getWeaponRanges5e]
v1.1.1 (March 15th, 2019)
- Added exception for when no maps are open (theater of the mind combat), in that case no ranged or flanked logic is run. [scripts/ranged_attacks.lua: getRangeModifier5e, getRangeBetweenTokens5e | scripts/token_helper.lua: getTokenMap, isEnemyInMeleeRange5e, postChatMessage]
-
Hi Styrmir,
Thanks for the update.
The error that was caused by the map window not being open has indeed been fixed.
The other error is still there.
To reproduce:
- Add an encounter that places the NPC tokens on the map, to the combat tracker.
- Drag an extra NPC in from the NPC list. Do not drag that NPCs token to the map.
- Keep the map open.
- Make ranged attacks.
When making a ranged attack against the NPC with no token on the map:
Script Error: [string "scripts/ranged_attacks.lua"]:218: attempt to index local 'targetToken' (a nil value)
When making a ranged attack WITH the NPC with no token on the map:
Script Error: [string "scripts/ranged_attacks.lua"]:217: attempt to index local 'actorToken' (a nil value)
When making a ranged attack by any NPC to any other NPC, with an NPC in the combat tracker that has no token on the map:
Script Error: [string "scripts/token_helper.lua"]:41: attempt to index local 'token' (a nil value)
There are some inconsistencies on whether the roll is actually made or not, but I haven't figured out what that is yet. I think it might have to do with the actor having a target or not. I.e if you attack by dragging the attack action while having no target, or target an NPC and double click the attack action. In any case the errors are thrown each time.
I'll see if I can get you some more precise scenarios if you want, but it's getting late here so perhaps not today :)
Thank you for your good work,
Tideturner
-
Thanks for the feedback. Good to get the step by step of recreating the error.
I'll have a look when I get the chance.
For now, when running theater of the mind keep the map closed, as you shouldn't need it anyways if you are running theater of the mind.
-
2 Attachment(s)
Styrmir,
My question is can the "effects" pop up box be coded to reposition just below the icon it is activated on? This to me would allow easier "applying" effects on tokens as right now I move the box off the token then apply the effect desired. It might just be my OCD :)
Amazing work! I don't think I'll ever run a game without 5eCE. My players looove the blood trails they leave behind!
Effects box covering token:
Attachment 26727
Effects box just below token:
Attachment 26728
edit:
Another issue I seem to see is with using the "remove from tracker" function.
As it works for me:
a - token is on top layer and I rt-click remove from tracker - token goes to bottom layer (which I believe is normal operation)
b - I go back to token on bottom layer and rt-click add to tracker. Which is does but now it is still on bottom layer??
Shouldn't the token return to the top layer? Right now I alt+left click to remove token then re-add from CT. If not then what is best practice for this remove from tracker/add to tracker function?
-
My workaround for the ranged attack bug (i use to keep ennemies hidden in the combat tracker, not putting them on the map, so i'm sure i will get the ranged attack error often) :
just uncheck the "Automatic ranged modifiers" option and manually apply ranged disadvantages until Styrmir find a solution.
-
@Tideturner
@Bunnyhunt3r
I've made some code changes to catch all those exception scenarios, for example where map is closed, entries in CT but missing tokens on map, CT entries but no map tokens, attacking from CT entry (without token) onto token on map, etc.
This will enable you to keep the automatic range modifier and flanking logic turned on, but it won't run for the entries not fulfilling all of the conditions needed for all the background logic to make it work.
This will be rolled out with the next patch versions of the extensions.
-
@Halfront
The menu is created with its center where the mouse cursor is when you press the menu item. I spent some time moving the menu around with code changes, for now I reverted those changes as there are a number of things to consider when placing it and it could take a few hours hours to code properly for all sizes of tokens, exception circumstances, testing etc.
I've added the "add to tracker" layer movement to the list of things requested.
-
I've encountered an issue when attempting to use the Automatic flanking rules and the Ranged Combat modifier rules, these seem to be the only two affected. I'm receiving this script error, what am I doing wrong?
Script Error: [string "scripts/token_helper.lua"]:41: attempt to index local 'token' (a nil value)
-
@Frank_Jager
See above. Something in your CT isn't on the map. This has been fixed, will be released with next patch.