Huh? That simple?? There's me stressing out and testing every extension I have for compatibility errors, not wanting to make myself look stupid...
And I succeeded anyway. Yay! (Simple Reading could have saved me about 30 mins)
*laughs* No worries.
I might end up pushing out the patch early, tomorrow even. As the exception cases seem to be affect a few of you.
I had wanted to get a thing or two more added in there as well while I was at it. But after a few hours over the weekend digging around and trying a few things in the code it's been taking longer than expected. I might end up holding on to a later date for those and just get the patch out to you first so you'll stop getting errors.
For myself, given that it isn't hard to chuck everything onto a map with a grid from the CT, you just drag the three coloured icons from the bottom, I can't see myself getting many more errors. (An great side effect, at least according to me, seems to be that whenever a PC attempts a roll without a target the extension prevents that roll) Probably a bug, but works as intended as far as I'm concerned.
I'd rather see Large and bigger sizes creatures added before bug fixes especially for something so easy, but I also see to be a huge fan of feature creep in developments so... Probably not wise to take my advice.
5e Combat Enhancer Version 1.5.2 released.
v1.5.2 (March 18th, 2019) (patch)
* Added conditions checking function call before running ranged modifier logic. This was done to cover various situations, such as when running theater of the mind combat, entries on CT but missing or no tokens on map, no map open, attacking from CT entry (without token) onto token on map, etc. [scripts/manager_action_attack.lua: modAttack]
Token Helper Version 1.1.2 released.
* Added conditions checking function before running ranged modifier logic. This was done to cover various situations, such as when running theater of the mind combat, entries on CT but missing or no tokens on map, no map open, attacking from CT entry (without token) onto token on map, etc. [scripts/ranged_attacks.lua: checkConditions]
* Exception added for missing token on map, that has CT entry [scripts/token_helper.lua: getTokenMap]
Now it is just perfect ! FG is really great with this extension, no need for the Unity version imho (except for the IPv6 problem and the 64bits memory improvement though).
Already downloaded! Exactly half an hour before tonight's game. nice
Sadly i think i found a bug on 1.5.2, using a ranged spell attack : the attack is resolved properly but the range is wrongly calculated.
For example, using ray of frost, you can read in the chat :"The ranged attack is OUT OF RANGE and misses. Ray of Frost (0) from 53 feet".
I just tested it. Worked for me ... do you have the range correctly entered for your Ray of Frost?
Attachment 26772
I tried ray of frost, fire bolt,ray of enfeeblement,melf's acid arrow, and i get the same "OUT OF RANGE" sentence, with the "(0) from xx feet". xx is the actual range of the target from the 10 to >70 feet i tried. No range like "(60)" or other range noted in the chat.
I turned off all my other extensions (DOE Sound and Base, NPC Savour, Current HP, Druid Wild Shape) for the same result.
I don't see where is the problem but it is clearly on my side so there is no bug. Time to sleep now, perhaps with a good rest i will figure out the problem :), thanks !
Omg... I found the problem... My test character is a Warlock, not a Wizard, and it seems that putting Wizard spells on a Warlock template cause this mess. I'm dumb and so sorry guys. It is working with a wizard character...:dead:
Glad to hear you found out where you went wrong, happy gaming! :)
I have this same issue. I'm using a MacBook Pro running FG 3.3.7, Combat Enhancer 1.5.1, Token Helper 1.1.2.
All other modifier keys work fine with scrolling (control - scroll rotates the token, option/alt - scroll scales the token). When I shift - left click, it opens the applicable sheet fine. When I shift - scroll though, I get nothing. Nothing appears in the console log either. If I use the built-in touchpad to scroll while holding shift, it works fine, and I get the desired result.
I'm running in a Windows 10 Pro Parallels VM. I use a full-size Mac bluetooth keyboard and a Logitech MX Master 2S mouse. I know there may be other factors at work here. Mac has its own settings for the mouse. Logitech Options has a series of settings. Parallels has some keyboard mappings as well. I made sure there were no custom mappings involving the shift key.
The issue is linked to Parallels (and Parallels Tools) overriding shift-scrolling to horizontal scroll, I think. The support team tells me there is no way to override this.
Is there any way we can get a different modifier key for altitude in this extension? Maybe control+shift, some other combination, or the ability to set the combo in options?
Good Day All :)
I tried to load this extension (version 1.5.x) and when I try to do a ranged attack it gives the following error:
Script Error: [string "scripts/manager_action_attack.lua"]:258: attempt to index global 'RangedAttack' (a nil value)
I tried starting a new campaign and this was the only extension running. I am sure it is something I placed in a wrong spot or something :)
I did put the Combat Enhancer folder in the Tokens/Host folder.
I reverted back to version 1.4.2 and the error is gone.
Thanks :)
This happened to me too. You need to have the Token Helper extension installed and activated in the campaign to make the ranged attack options and flanking melee options work.
Hi Styrmir, and others.
Having played a few sessions as DM with this extension enabled, I find that I often get confused with the NPC highlighting, the combat tracker jumping back and forth, and it constantly demanding focus.
(I.e my thoughts here are from a DM/Host perspective, have not used it as a player)
This is not an error report or anything, and neither is it an expression of dissatisfaction, but I'm hoping we could perhaps have a small discussion about those features. I mean, I enjoy them, I just think they're a bit too insistent. Just airing some thoughts :)
Anybody else being a bit confused by this? It might be that it is just my brain being too easily distracted by those two squirrels over there, I mean look at them, so.. so fidgety...
I'll try to sum up my preference on clicking/highlighting/CT focusing:
- I would prefer that the NPCs are not highlighted, and the combat tracker not brought to the foreground, unless I explicitly tell it to.
- I would prefer that the combat tracker not jumped to the NPC I just clicked on.
- The highlighting I would find more useful if it showed me all characters that are currently selected (or targeted), instead of whomever I last clicked on.
- I would prefer, generally, highlighted NPCs not being expanded.
Note, these click I refer to is clicking tokens on the map. I'm quite pleased with the token highlighting on the map when you mouse over an NPC in the combat tracker.
I tried to map out how the extension does the various click, and how my preference is for that click.
Shift + Left click token
- NPC is added to selection group.
- NPC info window opened.
- NPC highlighted in combat tracker.
- Combat tracker jumps to NPC.
- Combat tracker jumps to foreground
My preference:
- NPC is added to selection group
Double click token
- Works as two single left click. I.e. quickly selects then deselects (or opposite of already selected)
- Combat tracker jumps to foreground
My preference:
- NPC info window opened.
- Combat tracker jumps to NPC.
- NPC is expanded in combat tracker
- Combat tracker jumps to foreground
- No NPC selection/deselection
(Note, I'm not sure if extensions can touch selection code, so the quick select/deselect might be FG stock functionality?)
Left click token
- NPC is selected
- NPC highlighted in combat tracker.
- Combat tracker jumps to NPC.
- Combat tracker jumps to foreground
My preference:
- NPC is selected
Ctrl click token
- NPC is targeted by selected NPCs
- NPC highlighted in combat tracker.
- Combat tracker jumps to NPC.
- Combat tracker jumps to foreground
My preference:
- NPC is targetted by selected NPCs
Alt click token
- NPC is deleted from map
My preference:
- I dunno. This is fine?
Alt+Ctrl click token
- NPC is deleted from map and combat tracker
My preference:
- I dunno. This is fine too?
Anyone have any thoughts about this. Or am I all alone in the void? :)
Regards,
Tideturner
@Styrmir - if the main extension relies on another extension, I'd recommend setting it to have a dependency on the token helper extension in the main combat enhancer extension. Info here: https://www.fantasygrounds.com/refdoc/properties.xcp and also see any DOE as these are set to depend on the DOE base extension.
You'll get a few people posting "why does my extension have a red X against it?" if they don't have the dependent extension - but it will hopefully save time and issues for most people in the long run.
To answer my own post:
I made some edits to the manager_height.lua script file. I've never programmed in Lua before. There might be a better way to do this. First I tried with control and shift, and the shift key was failing to be recognized again.
I've tested this. It retains the original functionality of just pressing control and alt independently.
function onWheel(target, notches)
if Input.isControlPressed() then
if Input.isAltPressed() then
--Debug.console("Hey control and alt are down on a token " .. target.getId());
if not hasHeightWidget(target) then
createHeightWidget(target);
else
if notches > 0 then
doIncreaseHeight(notches,target);
else
doDecreaseHeight(notches,target);
end
end
-- rotate token
else
target.setOrientation((target.getOrientation()+not ches)%8);
end
elseif Input.isAltPressed() then
-- resize token
local scale = target.getScale();
scale = scale + notches/10;
if scale <= 0.1 then scale = 0.1 end
target.setScale(scale);
end
return true;
end
Good Day Drakowulf :)
That did it, the sad part is I had that downloaded but forgot to enable the Token Helper not seeing it as Core RPG- Token Helper :p
It still does not do the Disadvantage for long range, but at least it is a step in the right direction :)
Game starts in a couple hours so I will not mess with it right now :)
A special thank you to those of you who have donated for the extension! Having put so much work into making it what it is today, it is so nice to see that my work is appreciated. Allowing me to buy a few drinks or meals. *raises a drink in your honor* :)
@Trenloe
Thank you, good suggestion. I'll add some dependencies to the next version.
@drakowulf
It seems very specific to your or mac setups, don't have one myself so can't test it out. But glad to hear you've found what works for you and thanks for sharing the code changes as they might be useful for someone else as well.
@Tideturner / Three of Swords / Tyrranosaurus Vex
I appreciate your feedback Tideturner. However in this case given my own usage, feedback from other users and the amount of work these changes would require. I'll keep things the way they are. If you really want to change these things for yourself then all of the 5e Combat Enhancer extension code is available free on GitHub from the first page of this thread.
I jumped from version 1.4.2 to 1.5.2 plus the new icon helper extension version 1.1.2. When I load a campaign and zoom a map the tokens move around on the map (are scaled) even though scale and tokens are locked. Also, when a user connects they get a massively zoomed in version of the map that can't be zoomed out on and the token isn't visible. If I disable the icon helper extension things look normal (although I didn't put it through its paces with effects and actions). Do I have to use the token helper extension? If I don't, what do I lose? If I have to, is there any way to get tokens and zooming to behave? I already tried nuking the cache and unsharing and resharing images and that didn't seem to work either.
Does the map have a grid? If so, do you see the grid moving as well - is it moving across all 3 layers, or is the grid moving together? The reason I ask this is to determine if this is a image layer issue (one or more of the layers becoming out of sync) or if this is a token issue. If a layer issue - what size us the image? Is this a file you've added to the campaign, not a module file? If so, have you resized the image outside of FG and kept the same file name?
Could you try removing all tokens from an image, delete the grid, zoom right out, add the grid back in then add a couple of tokens - does the issue still exist?
If the image is one you've added to the campaign \images directory, try this: exit FG, rename the image (this will result in FG seeing it as a new image), load up FG and then add grid, add tokens, etc..
Darn it Trenloe - why you gotta fix crap? It's working now. The image was used with 1.4.2 just fine (been using Advanced Kombat since Ken managed it) and is a jpg 547x1091 pixels and 128KB (100 pixel grid when applied). Removed all tokens, unshared the image, removed the grid and removed any mask. I then zoomed out and added the grid then a token from the combat tracker. Zooming seems to work fine and when using localhost I now see an appropriately scaled image and my token doesn't move around when zooming. I'm good about managing my shared images, so I'll just do that for our next session and see how it goes. Thanks - I'm pretty sure I did that last time (unshared, cleared grid, replaced tokens) but the one thing a I didn't do was apply the grid when fully zoomed out. I know I was zoomed in some amount. I wonder if that was the issue?
New to this ext. Reading through the thread but there is a lot.
1/ Just testing it out and I get a script error (rangedattack) when I do ranged attacks / spells attacks. Suggestions?
2/ in the OP pic there is a 55ft by the eagle. Is that this extension?
Thanks!
I figured the script error just now when I turned off "automatic ranged modifiers" in the options tab as well.
Figured it out (shift + mouse wheel). in cause anyone else is looking.
Token Helper v1.1.3 released.
v1.1.3 (March 28th, 2019)
* Bugfix: If actor not on map flanking threw error. Fix: Flanking returns false if actor not on map. [scripts/5e_flanking.lua: isFlanking]
Huge blood splatters have turned up, and can't seem to sort. Have tried deleting grid, and redrawing, but they are still to big, even on the smallest setting.
Attachment 26854
@spoonehad
You could try removing the grid and the tokens. Then renaming the image. Then setting grid at 50x50 while zoomed out so you can see the whole map. Then try it again.
Blood splatter sizes are ratio multipliers of the token scaling and grid sizes. So if there are any issues with the token scaling or grid sizes, or lack there of, on any of the layers, then the splatter will show up in the sizes the original images are in.
The map is from a module, (CoS), so I can't rename, and the splatters are huge. So I did a quick new campaign, just loaded in your extensions and CoS module, and all seems good, except the very first time creature goes to 0 HP, I get these lines. Second time a creature goes to 0 HP, no messages.
Runtime Notice: Host session started
Runtime Notice: s'5e Enhanced Combat Version check: Version is 3.3.7, and valid'
Ruleset Warning: chat: Could not find icon (icon)
Runtime Notice: s'DEATH WATCH! 0'
Runtime Notice: s'UPDATING attributes for replaced token'
Runtime Notice: s'ATTEMPTING To Grab Image Window of Abominable Yeti id: 1'
Runtime Notice: s'blood proto is : tokens/host/Combat Enhancer/blood_8.png scale is 2'
Script Error: [string "scripts/manager_token2.lua"]:1008: attempt to index local 'tokenMap' (a nil value)
@spoonhead
Thanks for the detailed feedback and error log.
I've started working on some updates to fix this. Have it working for regular maps, but need some more testing and work to get it working with background maps when I have the time.
I've come across another odd problem, in that for just one character, all their ranged weapon attacks are not being correctly modified in the chat. Whereas all of other characters ranged attacks work as expected. I've tried deleting the PC from the CT and map and starting again, but no joy.
I can't see that the properties of his weapons are any different. However, I did delete the offending shortbow and dropped another one in the inventory and that seemed to correct it, but no joy for the long bow.
Can't see to distinguish between the 2?
Attachment 26877
Seems I found out the problem, as the character isn't proficient in the weapon. Perhaps the wording could be changed in those instances?
@spoonhead
I'm unable to recreate the error. Created a new character that did not have proficiencies in the weapons above. Added them and a few others that weren't trained to the character and everything works as it should.
Combat Enhancer v1.5.3 version release.
v1.5.3 (March 29th, 2019) (patch)
* Added dependency for the Token Helper extension. [extension.xml]
* Fixed scaling issues of blood splatters for certain maps. [scripts/manager_token2.lua: createSplatter]
* Removed some deprecated range code. [scripts/manager_token2.lua: getDistance, getTokenDistance]