Got a few bugs:
Ruleset information: SFRPG ruleset v1.2.6, CoreRPG ruleset v3.3.9
#1:
I had my test biohacker attacking a Deh-Noloh(Starfinder Armory), and its needler was always dealing damage, despite the creatures DR 10/magic.
I proceeded to fiddle with the creature DR type and noticed the logic for DR is currently reversed, when I swapped its DR to DR 10/piercing, it started resisting piercing damage, when I swapped to slashing, its DR started applying to slash attacks but no longer blocked piercing. Finally, when I gave the Biohacker DMGTYPE:magic, DR 10 magic started blocking his damage.
In theory, for PF and SF, DR should reduce all damage types other than the specified one, which should be the bypass. So with DR 10/magic the Deh-Noloh should take reduced damage from all but magical weapon attacks.
#2
For DR and Resistance there isn't currently a logic for negative modifiers.
Case:
Using the same creature as above, and a character buffed with DMGTYPE:magic, I applied a DR:-10 magic effect to the Deh-Noloh.
Then I proceeded to attack it with a magic attack dealing 10 DMG. This attack was fully resisted. The expected scenario was to deal full damage (dr 10 magic + (dr -10 magic) = dr 0 magic);
As an aditional test, I figured it either adds all instances of DRs or checks against all DRs it finds:
I declared a second buff, another DR:10 magic. (Now it has 2 instances of DR:10 magic) and attacked with an attack dealing 11 damage. This attack was resisted.
#3:
Adding a custom class is currently returning the following error (I tried both adding from zero, and creating a duplicate of an existing class, and just unlocking this duplicate for edit):
This happened when I tried to add in the biohacker by hand, I found a bit after the playtest xml and used that instead for my tests.Quote:
Script Error: [string "scripts/manager_class.lua"]:68: attempt to index local 'nodeFeatures' (a nil value)
Script Error: [string "scripts/manager_class.lua"]:68: attempt to index local 'nodeFeatures' (a nil value)
Database Notice: Campaign saved.