Is there any chance we could see this change in the ruleset?
manager_action_attack.lua
line 60
change toCode:function notifyApplyHRFC(sTable)
local msgOOB = {};
msgOOB.type = OOB_MSGTYPE_APPLYHRFC;
msgOOB.sTable = sTable;
Comm.deliverOOBMessage(msgOOB, "");
end
Code:function notifyApplyHRFC(rAction)
local msgOOB = {};
msgOOB.type = OOB_MSGTYPE_APPLYHRFC;
if rAction.sResult = "fumble" then
msgOOB.sTable = "Fumble";
elseif rAction.sResult = "crit" then
msgOOB.sTable = "Critical Hit;
end
Comm.deliverOOBMessage(msgOOB, "");
end
line 581
change toCode:-- HANDLE FUMBLE/CRIT HOUSE RULES
local sOptionHRFC = OptionsManager.getOption("HRFC");
if rAction.sResult == "fumble" and ((sOptionHRFC == "both") or (sOptionHRFC == "fumble")) then
notifyApplyHRFC("Fumble");
end
if rAction.sResult == "crit" and ((sOptionHRFC == "both") or (sOptionHRFC == "criticalhit")) then
notifyApplyHRFC("Critical Hit");
end
by passing rAction to notifyApplyHRFC you would give extension devs a really useful way to expand on critical / fumble effects without having to override a function that has great potential for conflicts.Code:-- HANDLE FUMBLE/CRIT HOUSE RULES
local sOptionHRFC = OptionsManager.getOption("HRFC");
if rAction.sResult == "fumble" and ((sOptionHRFC == "both") or (sOptionHRFC == "fumble")) then
notifyApplyHRFC(rAction);
end
if rAction.sResult == "crit" and ((sOptionHRFC == "both") or (sOptionHRFC == "criticalhit")) then
notifyApplyHRFC(rAction);
end