Better Combat Effects

Awesome peoples. Thanks for the update Mattekure.

Version Update 2.25
fixed: Issue with Source tags not properly resolving
fixed: Error with Automatic Save Adv

[QUOTE=nephranka;633366]

Quote:

---

Originally Posted by BlazingAzureCrow

Kent McCullough & Rob Twohy's Automatic Save Advantage is having a conflict with this extension. When both are on, "SAVEE" effects won't roll. Tested in a campaign with only them on. The dice doesn't roll, and the error returned when it tries to roll it is

"[Script execution error: [string "scripts/manager_action_save_asa.lua"]:79:attempt to index local 'sourceNode' (a nil value)"/QUOTE]

I can confirm this error. Not sure when it broke.

---

I looked at this and I'm going to say it is working as intended. Yes it does add 1 rnd to TRUNRS to get around the auto decrement initiative. I know at one point someone had a request for a effect that ended at the end of their turn, the same turn it was applied. The bottom line to remember is it will get removed when the tag fires at 1 rnd duration.

Quote:

---

Originally Posted by elfmage

Hi rhagelstrom,

Thanks for looking into this. The new build seems to work more favorably - thanks.

Just as a heads up based on my testing you seem to add a round on application of the effect for TURNRS to work around the CT removing a round from the effect at the start of a round. TURNRE, STURNRS & STURNRE do not apply this extra round in the same way to work around this. I tested this for [TARGET] & [SELF] on the 4 effects. Just wanted to point this out in case your intention was to apply this for all custom your effects.

Either way, I can easily work around this issue by making the duration 2 vs 1 rd.

---

Thank you!

Quote:

---

Originally Posted by rhagelstrom

I looked at this and I'm going to say it is working as intended. Yes it does add 1 rnd to TRUNRS to get around the auto decrement initiative. I know at one point someone had a request for a effect that ended at the end of their turn, the same turn it was applied. The bottom line to remember is it will get removed when the tag fires at 1 rnd duration.

---

Sure thing, I only pointed it out due to the inconsistency someone may be confused due to it.

Thanks for looking at/fixing the other stuff though, much appreciated.

Trying to use the DMGR: effect in 5e for interception.

The effect itself works fine, only issue I've encountered is that it seems to be ignoring the `Expend on next Roll/Action`, so it's staying on the target as if it was set to `Expend: Never`

---

Ignore me, I was using the effect completely wrong, applying it to the one dealing the damage instead of the target of the hit

[QUOTE=rhagelstrom;633431]Version Update 2.25
fixed: Issue with Source tags not properly resolving
fixed: Error with Automatic Save Adv

Thank you so much~!

Quote:

---

Originally Posted by Svandal

There is a problem with the new version of this extension with the "SAVEDMG" effect.
A couple of days ago this effect worked as intended, but in this version it does not work anymore.
It is this effect:
Acidic Spray; SAVES: reflex 23 (R); SAVEDMG: 7d6, acid

Problem 1:
It does roll the save, but it does not remove the effect on a successfull save

Problem 2:
If the save is a failure it does not get any damage (and no damage dice gets rolled either)

Edit:
Pathfinder 1 ruleset
No other extensions loaded

---

This is still a problem in this version of this extension.
I have tried this effect in 5e, and it works.
Acidic Spray; SAVES: DEX 23 (R); SAVEDMG: 7d6, acid

But for pathfinder ruleset it does not work, something in version 2.24 broke the SAVE effects for pathfinder 1st ruleset.

Quote:

---

Originally Posted by Svandal

This is still a problem in this version of this extension.
I have tried this effect in 5e, and it works.
Acidic Spray; SAVES: DEX 23 (R); SAVEDMG: 7d6, acid

But for pathfinder ruleset it does not work, something in version 2.24 broke the SAVE effects for pathfinder 1st ruleset.

---

Can you send me a sample campaign and I'll take look. It's a little hard for me since I don't have any of the source books to test a lot of normal things

Version Update 2.26

Feature - Conditions are now searched first and then the custom effects list when using tags such as SAVEADD
Fixed - The SAVEADD family (SAVEADD, SAVEADDP), all effects with these tags on an actor would process on a failed save, success in SAVEADDP case. These are now bound the the effect if a BCE tag that makes an ongoing save proceeds it.
Fixed - DMGRT was not being removed on damage

Quote:

---

Originally Posted by rhagelstrom

Can you send me a sample campaign and I'll take look. It's a little hard for me since I don't have any of the source books to test a lot of normal things

---

Sure I can send you something, but I dont know what is useful. If you are more specific I can do that

For this bug you can just start a new campaign with your extension loaded, add a npc or pc in the combat tracker with no stats. No source books needed.

Then add your effects into the combat tracker.
For pathfinder use will, reflex or fortitude instead of dex etc.
So the effect I made as an example.
Acidic Spray; SAVES: reflex 23 (R); SAVEDMG: 7d6, acid

It will not roll damage on a failed save
It will not remove on a failed save
It will roll the save and tell if it is a failure or success.
No errors are thrown.

The 5E status indicators extension is having an odd conflict with the Better Combat Extension. When a creature puts a SAVEE effect on another creature to force them to make ongoing saving throws, when they make it it forces the creature that put the effect on the creature to make it instead but also does some weird stuff where it still might remove the effect from them. This was tested in a campaign with only it and Better Combat Effects on. Leaving this where both extension creators can see it

https://cdn.discordapp.com/attachmen...89/unknown.png

I've run into an issue using BCE, when BCE is loaded (forge version) ADVSAV: [ability] does not function (concentration does) disabling the extension allows the effect to work properly.

Other extensions (forge and otherwise) i have loaded include;
5E - Advanced Effects
5E - Automatic Mirror Image
5E - Polymorphism FGU
Feature: Aura Effects
Feature: Theogeek's Improved Critical

Quote:

---

Originally Posted by Rebecca

I've run into an issue using BCE, when BCE is loaded (forge version) ADVSAVE: [ability] does not function (concentration does) disabling the extension allows the effect to work properly.

Other extensions (forge and otherwise) i have loaded include;
5E - Advanced Effects
5E - Automatic Mirror Image
5E - Polymorphism FGU
Feature: Aura Effects
Feature: Theogeek's Improved Critical

---

What is "ADVSAVE: [ability]" coding?
This is not part of BCE, nor is it part of base FGU.
You might mean "ADVSAV: [ability]" if that is the case, this is correctly working for me (and it's part of base FGU), while I use BCE.

Quote:

---

Originally Posted by MrDDT

What is "ADVSAVE: [ability]" coding?
This is not part of BCE, nor is it part of base FGU.
You might mean "ADVSAV: [ability]" if that is the case, this is correctly working for me (and it's part of base FGU), while I use BCE.

---

Excuse me, made a typo, ADVSAV: [ability] (example, "ADVSAV: wisdom") is not working for me while BCE is loaded
A little extra testing, looks like stuff like "Magic Resistance" also does not work while BCE is loaded

Quote:

---

Originally Posted by Rebecca

Excuse me, made a typo, ADVSAV: [ability] (example, "ADVSAV: wisdom") is not working for me while BCE is loaded
A little extra testing, looks like stuff like "Magic Resistance" also does not work while BCE is loaded

---

All this is working for me, maybe you using another ext also that is conflicting?

In the picture, you can see only BCE loaded, and the first roll was without "ADVSAV: strength", the second was when I applied the effect.

Quote:

---

Originally Posted by MrDDT

All this is working for me, maybe you using another ext also that is conflicting?

In the picture, you can see only BCE loaded, and the first roll was without "ADVSAV: strength", the second was when I applied the effect.

---

I doubt it's another ext, but i haven't tested yet, i'll do that when i'm back at my PC

Quote:

---

Originally Posted by Rebecca

I doubt it's another ext, but i haven't tested yet, i'll do that when i'm back at my PC

---

I use 3 of those 5 exts you listed. I do not use AURA or CRIT one, however, the reason I don't use AURA one is because it does have some conflicting coding with a few of the other exts I use (I use 70+ exts).
In the picture above I only used BCE.
It is working with my other exts.

I would suggest make sure you using the most updated version, and try turning off the other exts and see if it still does it. I would start with AURA one.

I just tested the extensions i'm using.
Any extension paired with BCE, ADVSAV didn't work.
BCE by itself, ADVSAV didn't work.
Tested Aura Effects by itself, ADVSAV worked.
Ran update.
Tested BCE by itself, ADVSAV worked.
Tested all extensions at once, ADVSAV worked.
FGU was last updated yesterday by fiance.
I have no goddamn idea what's what anymore, i'm doubting whether i got the coding wrong before i made my initial post, but i had 2 people help me with those before, anyway, it works.

Somewhat similar issue, with BCE enabled I can't apply adv/dis to ANY saves, using the modifier buttons, effects, or any other method. I've tried disabling all other extensions but no luck.

Quote:

---

Originally Posted by digimatt

Somewhat similar issue, with BCE enabled I can't apply adv/dis to ANY saves, using the modifier buttons, effects, or any other method. I've tried disabling all other extensions but no luck.

---

Update, worked for me, somehow, i'm not going to question the magic anymore.

Thanks, an additional update took care of it for me too.

Quote:

---

Originally Posted by Rebecca

I just tested the extensions i'm using.
Any extension paired with BCE, ADVSAV didn't work.
BCE by itself, ADVSAV didn't work.
Tested Aura Effects by itself, ADVSAV worked.
Ran update.
Tested BCE by itself, ADVSAV worked.
Tested all extensions at once, ADVSAV worked.
FGU was last updated yesterday by fiance.
I have no goddamn idea what's what anymore, i'm doubting whether i got the coding wrong before i made my initial post, but i had 2 people help me with those before, anyway, it works.

---

The FG updater is a fickle beast. Occasionally, I've found that I have to run the updater several times for the updates to stick. It may be that the published updates haven't made it through the 'approval' process, but whatever the problem is, running an update a few times has solved many a problem for me.

Quote:

---

Originally Posted by BlazingAzureCrow

The 5E status indicators extension is having an odd conflict with the Better Combat Extension. When a creature puts a SAVEE effect on another creature to force them to make ongoing saving throws, when they make it it forces the creature that put the effect on the creature to make it instead but also does some weird stuff where it still might remove the effect from them. This was tested in a campaign with only it and Better Combat Effects on. Leaving this where both extension creators can see it

https://cdn.discordapp.com/attachmen...89/unknown.png

---

I've pushed a fix for this.

Quote:

---

Originally Posted by mattekure

I've pushed a fix for this.

---

Thanks not getting this error anymore so thats great.

Quote:

---

Originally Posted by mattekure

I've pushed a fix for this.

---

Thank you! Already said over on your Discord, but I really appreciate your work.

Quote:

---

Originally Posted by BushViper

The FG updater is a fickle beast. Occasionally, I've found that I have to run the updater several times for the updates to stick. It may be that the published updates haven't made it through the 'approval' process, but whatever the problem is, running an update a few times has solved many a problem for me.

---

You know that does make sense and would neatly explain the issue, probably just safest to update before every game.

I just saw this thread and it blew up. Everyone seems good with things working?

Indeed, no issues here, apologies for blowing up the thread

Version Update: 2.27
Fixed - 5E - SDC correctly accounting for bonuses from power group settings

Attachment 50977

Still having an issue with the add-on causing weird bonus calculations. I'm using the 2.27 update as you can see in the screenshot, and I'm on the latest version of FGU. BCE is the only extension I have enabled.
The image shows a character with proficiency bonus of 6 and charisma bonus of 3 with a DC of 26 that should only be 17 for their Hold Person save.

Thanks for all of your work��

I can second the findings from Nebs with a 5E campaign and no other extensions besides BCE 2.27. It appears to be related to proficiency. Here's a level 1 character with a Save DC of 18, when it should be 15.
Attachment 50981

Removing proficiency from the Save DC reduces by 4, instead of 2:
Attachment 50982

And with BCE disabled, no other extensions, to show what is expected:
Attachment 50983

Version Update 2.28
Fixed - 5E - Fix for bonehead screwup accounting for bonuses from power group settings
Fixed - 5E - BCE Tags that are associated with an attack action are now compatible with Advance Effects extension's Action Only

Somehow I ended up calling the eval function twice! Sorry for the inconvenience

Quote:

---

Originally Posted by Nebs

Attachment 50977

Still having an issue with the add-on causing weird bonus calculations. I'm using the 2.27 update as you can see in the screenshot, and I'm on the latest version of FGU. BCE is the only extension I have enabled.
The image shows a character with proficiency bonus of 6 and charisma bonus of 3 with a DC of 26 that should only be 17 for their Hold Person save.

Thanks for all of your work��

---

I have no idea what the conflict is, but when BCE is on I'm getting an issue when I roll tables, where the following error occurs and nothing rolls:

"Script execution error: [string "scripts/manager_effect_bce5E.lua"]:112:attempt to index local 'rActor' (a nil value)"

I'm trying to figure out in a test campaign what other extensions are interacting to cause it because it's not BCE on its own. Since it calls out "BCE" in the error line I figured I'd drop it here just in case something was obvious that I don't have the knowledge to notice. This error has only been happening as of today.

Quote:

---

Originally Posted by BlazingAzureCrow

I have no idea what the conflict is, but when BCE is on I'm getting an issue when I roll tables, where the following error occurs and nothing rolls:

"Script execution error: [string "scripts/manager_effect_bce5E.lua"]:112:attempt to index local 'rActor' (a nil value)"

I'm trying to figure out in a test campaign what other extensions are interacting to cause it because it's not BCE on its own. Since it calls out "BCE" in the error line I figured I'd drop it here just in case something was obvious that I don't have the knowledge to notice. This error has only been happening as of today.

---

I just pushed a fix for this. 2.29

Fixed! Thank you!

I have an issues with SAVEONDMG. it seems not work. (Only BCE on)

Version Update: 2.30
Fixed - SAVEONDMG not working

Quote:

---

Originally Posted by Drogo210

I have an issues with SAVEONDMG. it seems not work. (Only BCE on)

---

I'm having an issue where my NPC is not adding it's Con save bonus on a SAVES role.

Setup:
1. NPC has a +2 to constitution, and is proficient in constitution saving throws for a total of a +6. (Used an aboleth to test)
2. Applied the following effect to the NPC--> Searing Smite (C); SAVES: CON [SDC] (R); SAVEDMG: 1d6 fire
3. Once applied, [SDC] resolves to 15

At the start of the NPC's turn, FG roles the saving throw, but it only roles a d20 and does not include the +6 in the saving throw role.

Quote:

---

Originally Posted by ReelaK

I'm having an issue where my NPC is not adding it's Con save bonus on a SAVES role.

Setup:
1. NPC has a +2 to constitution, and is proficient in constitution saving throws for a total of a +6. (Used an aboleth to test)
2. Applied the following effect to the NPC--> Searing Smite (C); SAVES: CON [SDC] (R); SAVEDMG: 1d6 fire
3. Once applied, [SDC] resolves to 15

At the start of the NPC's turn, FG roles the saving throw, but it only roles a d20 and does not include the +6 in the saving throw role.

---

Having the same issues. NPCs or PCs.
It's not just limited to SAVES either

Also another issue, is that SAVEA doesn't seem to be working when its applied, its not forcing the save when the effect is applied.