Combat Modifier Calculation Extension

Quote:

---

Originally Posted by dellanx

Where may I find the new Token Height extension? Can't seem to find the post. Thanks!

---

linky link... https://www.fantasygrounds.com/forum...ight-Indicator

Quote:

---

Originally Posted by Zygmunt Molotch

linky link... https://www.fantasygrounds.com/forum...ight-Indicator

---

Thank you!

Can we have an option of disabling the automatic flanking effect?
It causes more trouble than it is worth in my opinion. The flanking button is more than enough.

Quote:

---

Originally Posted by Svandal

Can we have an option of disabling the automatic flanking effect?
It causes more trouble than it is worth in my opinion. The flanking button is more than enough.

---

I'm not sure yet how to interact with the options panel. In the meantime, I just uploaded a version that doesn't do any flanking calculation, but still recognizes the "Flank" modifier button. Not as good as a switchable option, but should help for now.

Quote:

---

Originally Posted by dogfisc

I'm not sure yet how to interact with the options panel. In the meantime, I just uploaded a version that doesn't do any flanking calculation, but still recognizes the "Flank" modifier button. Not as good as a switchable option, but should help for now.

---

Add this to onInit of a named script:

Code:

---

OptionsManager.registerOption2('AUTO_FLANK', false, 'option_header_game', 'opt_lab_autoflank', 'option_entry_cycler',
                { labels = 'option_val_off', values = 'off', baselabel = 'option_val_on', baseval = 'on', default = 'on' })

---

Then you can use

Code:

---

if OptionsManager.isOption('AUTO_FLANK', 'on') then

---

to see if it is still enabled.

You can give the option a title by adding a string within <root><base> of extension.xml:

Code:

---

        <string name="opt_lab_autoflank">Automatic Flanking</string>

---

turning flanking as an option off, would be most welcome

it's frequently wrong for our combats :D

but the range stuff is fantastic!

Thanks @bmos! I’ll work on it when I get some time.

Would it be possible to get a version of only flanking? I am attempting to hack a 4E version but running into a lot of errors. :-)

Hey, Dogfisc

Bmos solved an error I got last night playing pf1e

A Spider, Giant Tarantula, which has a blank feat field

created the error Attachment 48258Attachment 48258Attachment 48258

in

Quote:

---

manager_action_attack_custom.lua

---

the function

Quote:

---

npcHasFeat

---

needs to accept blank strings, like so

Quote:

---

function npcHasFeat(ctNode, sFeat)

local sLowerFeat = StringManager.trim(string.lower(sFeat or ""));
local sFeatList = DB.getValue(ctNode, "feats", "");
local sLowerFeatList = StringManager.trim(string.lower(sFeatList));
return string.match(sLowerFeatList, sLowerFeat);

end

---

this is Bmos's fix, I'm always bugging him for debugging

as you can see, the Official Creature is also coded wrong, but thats for the Official Bug report thread :D

And here is a bug report. Compatability error with token height extension:
https://www.fantasygrounds.com/forum...ight-Indicator

It has to be something in one of the last patches of token height, it worked correctly before:

See attached files, here is an explanation:
Fantasy grounds unity latest live version. Only this and token height extension.

When I try to attack with my NPC cyclops with a heavy crossbow (or other NPCs with ranged weapons) I can do it if I target something in the combat tracker (drag the attack to the combat tracker)
But If I drag the attack onto a token on the map (both tokens are in the combat tracker) I get this error:
Handler error: [string "scripts/manager_combat.lua"]:325: attempt to index local 'token' (a number value)

If I try to attack with a PC (in this case a PC with compsite longbow) I get this error if I drag the ranged attack from the PC sheet action tab directly to the combat tracker, or if I drag the attack onto a token on the map:
Script execution error: [string "scripts/manager_combat.lua"]:325: attempt to index local 'token' (a number value)