would love to see a reload for 5E
Printable View
would love to see a reload for 5E
The previous discussion was about loading single-shot weapons like crossbows. The reload button has been removed since ammunition now feeds from the inventory.Quote:
Originally Posted by Garrick147
See the video for more info.
Yay. I see it now. Waiting anxiously for "5e reload" (we have a game starting at 7pm est :)Quote:
Originally Posted by bmos
Ah I was waiting but will release now :)Quote:
Originally Posted by webdove
Thanks for the update!! There appear to be a couple of bugs to iron out.
Attachment 51798
I think there might be an extension incompatibility as a result of these changes.Quote:
Originally Posted by webdove
Right you are. Too close to game time for debugging. I wonder which one is the culprit.
Attachment 51803
I got a bug report with only this mod loaded and it is only a bug with one of my existing campaigns.
It only applies for one of my existing campaigns, which I have attached. I do not know why, but it worked last time I opened this campaign two weeks ago.
This bug does not appear in any of my other campaigns.
The error thrown in the console windows when I try any attack with any weapon is:
ERROR script execution error: string "scripts/manager ammunition.lua 340 attempt to call field 'getWeaponName' (a nil value)
Wasn't able to reproduce the issue with your campaign. I see how that could happen with other extensions loaded though (so I have pushed a new update) but since you said it is happening for you without any other extensions loaded I am puzzled.Quote:
Originally Posted by Svandal
Quote:
Originally Posted by bmos
Well. I do run many extensions, and the bug happened when I ran many extensions at once.
Then I closed the campaign, disabled every other extension and was able to reproduce it with only your extension running.
I will try the new update later today.
I do not get an error any more, not with all my extension s loaded.Quote:
Originally Posted by Svandal
Awesome!Quote:
Originally Posted by Svandal
In 5e, to make use of INFAMMO is it put in the weapon properties?
No, that is an effect.Quote:
Originally Posted by BushViper
So you can trigger it from a spell, for example.
You can see it in action here: https://youtu.be/yW0JeWRxnx8?t=130
The conflicting extensions is Celestion's "Advanced Effects" on the Forge https://forge.fantasygrounds.com/shop/items/68/view. When I load only Ammunition Manager and Advanced Effects the crossbow in an unloaded state will still attack. With only Ammunition Mangers loaded it will not attack.Quote:
Originally Posted by bmos
I will send him a note mentioning the conflict with Ammunition Manager as well.
Ah. I have submitted a fix there but it is awaiting acceptance.Quote:
Originally Posted by webdove
https://github.com/CelestianGC/AdvancedEffects/pull/6
Thank you so much for the quick fix. Tonight is game night :)Quote:
Originally Posted by bmos
If I want to test it now do I just merge these two files with my latest version of advanced effects?
campaign/scripts/char_weapon_adnd.lua, scripts/manager_effect_adnd.lua
I think Celestian just posted a new version with the fix :)Quote:
Originally Posted by webdove
Sadly v5.3 has not made it to the forge yet. I will have to disable the forge one and manually load the one from github. That worked, unloaded shots are blocked.
New bug when I try to attack.
Attachment 51959
No time to chase it now.
Rats. I also did not test my other extensions thoroughly enough. Now with them all active weapon unloaded does not block attacks again. I could swear I checked that, but today it works with your ext along and not with the rest of mine. sigh.Quote:
Originally Posted by webdove
Just making sure I understand: You think there is another extension that is incompatible as well?Quote:
Originally Posted by webdove
Yes, I suspect so. I will look into that.
The two conflicting extensions are:
advanced effects
automatic flanking and range,
https://www.dmsguild.com/product/314..._0_0_0_45545_0
I tried loading advanced effects 5.3 from github
Click attack button on crossbow, hand and I got this error.
Attachment 51968
So there seems to be a problem with the Advanced Effects patch and a problem with Automatic Flanking and Range.
Re AE, I messed up the compatibility patch I sent to Celestian :(Quote:
Originally Posted by webdove
So I have posted a working one: https://github.com/CelestianGC/AdvancedEffects/pull/7
I patched and labelled my version of advanced effects to 5.3a. It works properly now with ammo manager.Quote:
Originally Posted by bmos
The remaining conflict is with Auto Flank and Range (which I use a lot).
You can show the author of that extension this section of char_weapon's onAttackAction function which should make it very easy to see how to add support to that paid extension.
I sent Kent/Posideon your note.
He is listed as "posideonsian#3316" on this Discord server https://discord.gg/rob2e
also as
https://www.fantasygrounds.com/forum...kentmccullough
I ran into this issue with AE as well. How do we get the fixed version? It stopped us from making attacks in combat, so it is a major issue. Thanks!Quote:
Originally Posted by bmos
There hasn't been a fixed version posted publicly.Quote:
Originally Posted by nephranka
Here is one.
Thank you!Quote:
Originally Posted by bmos
Bmos, pending the compatibility fix for automatic flanking and ranged from Kent, you might consider adding an option to disable the load button function in 5E Ammo mgr so all three extensions can be used together.
Web
P.S. Kent sent me a private message that he was working on it.
Awesome, thanks for organizing that :)Quote:
Originally Posted by webdove
Also that is a great idea (even for reasons other than compatibility) since I know some groups don't use reloading actions but would still like ammo counting.
But I would also point out that such a fix would break the feature allowing effects attached to magic ammo to be counted since it is in the same overwritten function.
Here are my private messages with Kent
Brill — 03/15/2022
Hi Kent. I am trying to use a new extension from BMOS called "ammunition manager". It had a conflict with Celestian's "advanced effects" which was cleared up. It also has a conflict with "Automatic Flanking and Range" and he asked me to send this to you.
March 13th, 2022, 18:23#267
bmos bmos is online now
Celestial Paragon
bmos's Avatar
You can show the author of that extension this section of char_weapon's onAttackAction function
https://github.com/bmos/AdvancedEffe...n_adnd.lua#L34
which should make it very easy to see how to add support to that paid extension.
bmos' extensions
he/him | Discord Tag: wil.thieme#3396
GitHub
AdvancedEffects/char_weapon_adnd.lua at 4bf14978a0d575e2b03be651e08...
Item Enhancement Extention. Contribute to bmos/AdvancedEffects development by creating an account on GitHub.
AdvancedEffects/char_weapon_adnd.lua at 4bf14978a0d575e2b03be651e08...
He uses that to prevent firing of an unloaded "loading" weapon.
Brill — 03/15/2022
BMOS is listed as https://www.fantasygrounds.com/forum...hp?194283-bmos
Fantasy Grounds Message Boards
Fantasy Grounds is a virtual tabletop application which allows GMs and player to play RPG games online.
posideonsian — 03/16/2022
gotcha, will try and get this fixed up soon
Is there a place where all the current features, options, effects are tracked for Ammunition Manager? I look on the forge, "bmos extensions" forum and this forum and I could not find a complete current description anywhere (e.g. about magic ammunition tracking which only had a few lines in GitHub #12).?
Not really. I can't remember if I even mention it in the video.Quote:
Originally Posted by webdove
Basically that is (IMO) an Advanced Effects feature so go there to learn more.
The only thing that is different when you use Ammunition Manager with it is that it uses effects tied to ammunition along with the weapon rather than just the weapon.
EDIT: I have updated the README with a better explanation of how this works:
Quote:
If used with Advanced Effects for Pathfinder and 3.5E or 5E Advanced Effects, "Action Only" effects attached to equipped ammmunition used in an attack will be included in the roll.
This allowed things like "Magic Arrow; ATK: 1 enhancement" to be added to the arrow effects list and it will only be used to modify the attack when the archer uses those arrows (even if those arrows are equipped constantly in the inventory).
EDIT TO ADD: Annnnd it looks like you've already made a patch! Thanks!
Hi there. After the latest updates it seems like Ammunition Manager is not playing nicely with the Advanced Effects extension by celestian (https://forge.fantasygrounds.com/shop/items/68/view).
I've isolated the error I'm getting down to these two extensions. I don't get the error when running either one by itself, but I do when running them together.
Attachment 52123
Hope it's an easy fix, as the advanced effects extension is amazingly useful and I'd hate to have to pick between one extension or the other!
bmos, I found another incompatibility. The 5E Auto Encumbrance extension https://www.dmsguild.com/product/358...iate_id=712946 assumes the unit for each Crossbow Bolts (20) is 20 bolts not one when it calculates weight.Attachment 52141
When you link from Ammo Mgr to the inventory item "crossbow bolts (20)" ammo mgr assumes the unit for crossbow bolts (20) is a single bolt. If you put it one unit in inventory for each bolt then the weight you carry is 20x too much. If you leave the unit in inventory as 1 per quiver of 20 bolts then when you link them you only show the number of quivers in the action tab and not the number of bolts. Do you understand?
Web
Interestingly, today I have Advanced Effects, Automatic Flanking and Range and Ammo manager all loaded. I am no longer getting the nil pointer error that I got on 3/12 and the load button is properly preventing attacks. Woopee!
Getting this error with the Ammo Manager. Happens when I click on the Attack roll in the Action tab. I am running 5e.