Problems / Bugs with BRP?

Quote:

---

Originally Posted by devinlc

Hello Again.

I ran another session tonight and my players told me that they can't see most of the items on my Combat Tracker.

...

---

A tip: log into FG as a player so that you can see what the players see. Just open a second FG instance and connect to your campaign. It's very helpful to be able to see a players view of the campaign. It helps resolve issues with, for example, the coverage of the fog of war.

Hello.

My players are begging me for more room for Powers on the Powers tab. Is there any way to cut the Character Failings by 50% and add that to the Powers section?

Regards,

Devin

I could tweak it, but due to the Beta, it will be some time till the update goes LIVE.

Quote:

---

Originally Posted by superteddy57

I could tweak it, but due to the Beta, it will be some time till the update goes LIVE.

---

Thanks. As much space as you can spare for Powers would be great.

Regards,

Devin

Quote:

---

Originally Posted by devinlc

Hello.

My players are begging me for more room for Powers on the Powers tab. Is there any way to cut the Character Failings by 50% and add that to the Powers section?

Regards,

Devin

---

The powers window is scrollable. You can have as many powers you want in it. If you really need more visible space then use an extension. IMO there's no need to change the general setup of the powers tab because of the needs of one group. As I said, this is why we have extensions.

Quote:

---

Originally Posted by peterb

The powers window is scrollable. You can have as many powers you want in it. If you really need more visible space then use an extension. IMO there's no need to change the general setup of the powers tab because of the needs of one group. As I said, this is why we have extensions.

---

Scrolling is a pain for something you use all the time and need to see to remember what you have. I don't see any way that many lines are needed for character failings. This isn't just for one group per se, it's a good design choice for any group IMO. If you can show me how a character can use that many lines for character failings, I'd be interested.

I'm going to give it a look and see what can be done. No promises. Just not swaying suggestions away. All feedback is considered.

Quote:

---

Originally Posted by devinlc

Scrolling is a pain for something you use all the time and need to see to remember what you have. I don't see any way that many lines are needed for character failings. This isn't just for one group per se, it's a good design choice for any group IMO. If you can show me how a character can use that many lines for character failings, I'd be interested.

---

This extension removes the failings and power level windows, leaving only a powers window on the powers tab. Install by copying the .ext file to the extensions folder in the Fantasy Grounds Data folder. Unfortunately I can't post attachments (for some reason) so I link to a file on google drive.

BRP Power tab.ext

Quote:

---

Originally Posted by peterb

This extension removes the failings and power level windows, leaving only a powers window on the powers tab. Install by copying the .ext file to the extensions folder in the Fantasy Grounds Data folder. Unfortunately I can't post attachments (for some reason) so I link to a file on google drive.

BRP Power tab.ext

---

Thanks. Will try it.

Devin

Hello.

Another item we noticed while playing. Effects do not add to the Combat Tracker when they are dragged onto the token or the combat tracker. This includes PCs and NPCs. The only way to add an effect is to manually type it into the combat tracker, which slows down play. Not looking for any sort of automation of the actual effects themselves, just would like to have it add the effect text into the combat tracker (e.g., Prone or Paralyzed) when dragging the effect onto it.

Is that a bug? If so, is it easily fixed?

Regards,

Devin

Devin,

Instead of typing I have found if the name of the character is selected on the combats tracker (As in it is their turn to act) if you click the particular effect button, it gives it to them.

Quote:

---

Originally Posted by IrishSpider

Devin,

Instead of typing I have found if the name of the character is selected on the combats tracker (As in it is their turn to act) if you click the particular effect button, it gives it to them.

---

OK. Cool. That is a workaround. Thank you. It does force one to basically go out of initiative order to apply it to the target and then remember whose turn it was to act, but since BRP doesn't usually have a lot of foes at one time (unlike higher level D&D combats) I can certainly live with it as is.

Devin

Quote:

---

Originally Posted by devinlc

Playing around with the Combat Tracker (CT), I note the following:

2. Even if using hit locations, some things in BRP only do damage to general hit points (like poison). There needs to be a way to reflect this. In thinking about what it probably the best and easiest way to do this, I could think of two ways:

A. Create a line on the Armor tab for a universal hit location called General that has no need for AP and the general hit point wound could be recorded there and then accumulated with hit location wounds to reduce maximum hit points on the Main tab.

---

So, option A can already be utilized currently. Just letting people know in case they have the same issue I did. You can select CUSTOM as your hit location type and then add a location and call it "General Hit Points" and give it the full hp of the PC. Then, when the PC takes damage only to its general hp, you can mark the wound on that location. And, if you set the Melee and Missile D20 ranges to 100 for this phantom hit location, it will move it to the bottom of the hit location chart. Works pretty well!

Regards,

Devin

Getting this error message in fantasy grounds whenever i click on an NPC
[Error] Window: Control (cohorts) anchoring to an undefined control (contentframe) in windowclass (nps)

That control and window class are not defined in the Basic Role Playing game ruleset provided through the FG store. Do you have any extensions running?

Regards,
JPG

When you adjust an NPC's power points whether on the combat tracker or their sheet it also lowers their POW score. Therefore, there's no way to track power point usage without also lowering an NPC's permanent POW stat, which isn't how it is supposed to work. POW should basically set the max PP or be an autonomously entered field. Can this be fixed?

Regards,

Devin

Pushed a hotfix. This will decouple the stat from the PP box and when a NPC is added to the ct, it will copy the POW to this box and reducing the number wont' change the stat anymore.

Quote:

---

Originally Posted by superteddy57

Pushed a hotfix. This will decouple the stat from the PP box and when a NPC is added to the ct, it will copy the POW to this box and reducing the number wont' change the stat anymore.

---

Excellent. Thanks!

Devin

Hello.

Question. If I wanted to change the label of the Power category "Mutations" to "Miracles", what file would I edit? I checked the various .lua and .xml files in the Basic Roleplaying.pak and while I find many references to "PowerType", I cannot find anywhere the actual types are stored.

Thanks,

Devin

Quote:

---

Originally Posted by devinlc

Hello.

Question. If I wanted to change the label of the Power category "Mutations" to "Miracles", what file would I edit? I checked the various .lua and .xml files in the Basic Roleplaying.pak and while I find many references to "PowerType", I cannot find anywhere the actual types are stored.

Thanks,

Devin

---

Unoack the PAK and then use a find in files option in your text/code editor to search for mutations and make sure case sensitive is not checked.

Quote:

---

Originally Posted by damned

Unoack the PAK and then use a find in files option in your text/code editor to search for mutations and make sure case sensitive is not checked.

---

I'm very much a newbie at this. Sorry. As I understand it, I unpack the PAK by changing the extension to .zip and unzipping it, which I did. But there are a great many files that unzipped. Do I have to search them all with my text editor?

I've got the following in my unzipped PAK root folder:

campaign folder
common folder
ct folder
desktop folder
graphics folder
ref folder
scripts folder
strings folder
base.xml
gameelements.xml
license.html
logo.png

I assume I can ignore the graphics folder entirely. Campaign folder has a bunch of xml and lua files.

If I have to go file by file and search I can...just want to see if there's a way to pare down the files to search.

Thanks,

Devin

many code and text editors (a simple free one is Notepad++) have a feature called find in files.
You nominate the text you want to search for - mutations and the root path you want to search (you can also tell it to only search xml and lua files) and it will find all locations for you in 1.3seconds.

Thanks, I will try that.

The file you are looking for is "manager_gameline.lua" in the folder "scripts".

Quote:

---

Originally Posted by Stollesson

The file you are looking for is "manager_gameline.lua" in the folder "scripts".

---

Thanks. I found it using Notepad ++ as suggested. Now if I can only figure out why, when I make the change of "Mutation" to "Miracle", rezip the .pak file, and put it back in the rulesets folder, I get an error on loading the campaign. I did prudently backup the original .pak, so I'm not in any distress. But I need to figure out what I did wrong.

You don't need to rezip up the ruleset. You can leave it in a folder in your rulesets folder and it will use that before the .pak file.

Quote:

---

Originally Posted by superteddy57

You don't need to rezip up the ruleset. You can leave it in a folder in your rulesets folder and it will use that before the .pak file.

---

That worked! Thanks. I am pretty sure I can now fiddle with the skills listing as well in the same lua file.

Regards,

Devin

Quick question.

If I make changes to the lua scripts in the Basic Role Playing ruleset, will that be overwritten when you make updates?

If yes, does that mean I need to do these changes via extensions instead?

Regards,

Devin

If it's in it's own folder, no. But you will have to make the updates manually to your own custom BRP

Quote:

---

Originally Posted by superteddy57

If it's in it's own folder, no. But you will have to make the updates manually to your own custom BRP

---

OK. Then it sounds like I should do an Extension, since I don't want to have to try to figure out what updates FG makes to the set and then manually do them all.

Thanks,

Devin

Yes, this would be best as an extension.

While testing my own strike rank handling code I noticed that the existing code doesn't really work as expected.

The SR value is never updated. That's probably because

Code:

---

local nodeActor = link.getTargetDatabaseNode();

---

in onUptionUpdate() in ct/scripts/ct_entry.lua returns nil.

This code in getStrikeRank() in scripts/manager_gameline.lua

Code:

---

local DEX = DB.getValue(node, "abilities.dexterity", 11);
local SIZ = DB.getValue(node, "abilities.size", 11);

---

returns values even if the node is nil.

Following up on the previous post.

You can verify the problem by:
a) create a new campaign
b) turn on the strike ranks option
c) reload the ruleset
d) create character
e) Drag it to the CT. The SR will be 5.
f) Change the characters SIZ and DEX to 21. This should set the SR to 1. But it doesn't, it remains at 5.
g) Change SIZ and DEX to 3. This should set the SR to 7. But it doesn't, it remains at 5.

Further investigation.

Debugging

Code:

---

local nodeActor = link.getTargetDatabaseNode();

---

with

Code:

---

Debug.console("Node Actor 1", nodeActor)

---

I get

Quote:

---

s'Node Actor 1' | databasenode = { combattracker.list.id-00001 }

---

which I'm pretty sure is not what's needed. I know that the code is old so this maybe is some code that needs to be refactored?

Digging into this a bit more.

In ct/scripts/ct_entry.lua the following code, from onOPtionsUpdate()

Code:

---

function onOptionUpdate()
        ...
        local nodeChar = link.getTargetDatabaseNode();

---

results in a different database node then this code from linkPCFields()

Code:

---

function linkPCFields()
        super.linkPCFields();

        local nodeChar = link.getTargetDatabaseNode();

---

The code in linkPCFields returns the characters db node (which is what you want), while onOptionUpdate don't. Since onOptionUpdate calls getStrikeRank with no db node the SR update fails.

I can get it to factor the Siz and Dex mods, but it won't factor weapon or power mods into the Strike Rank. That would require more factoring to have the players/GM to pick their action and add them to the box. Which as you can see is a bit of an undertaking.

Quote:

---

Originally Posted by superteddy57

I can get it to factor the Siz and Dex mods, but it won't factor weapon or power mods into the Strike Rank. That would require more factoring to have the players/GM to pick their action and add them to the box. Which as you can see is a bit of an undertaking.

---

Yes, I understand that. But, as I explained in my posts above, the existing code doesn't work. The SR is never updated because the getStrikerank funktion gets a nil value instead of a character node.

Just to avoid any misunderstandings, I'm not asking you to factor weapons or power into strike ranks, I'm going to fix that part myself. I'm just letting you know that there's a problem with the existing code, and (incidentally) that create problems down the line for my code.

Yes, I understand your request. I just wanted to be sure there was no misunderstanding with power and weapon mods to the strike rank.

Well, I got it working.

In ct/scripts/ct_entry.lua I modified onOptionUpdate() so that the DB.setValue used the database node of the CT windowlist.

Code:

---

function onOptionUpdate()
    local sOptHRSR = OptionsManager.getOption("HRSR");
    strikerank.setVisible(sOptHRSR == "on");
    local nodeChar = link.getTargetDatabaseNode();
    local ctNode = getDatabaseNode();
    local nStrikeRank = LineManager.getLine().GetStrikeRank(nodeChar);
    DB.setValue(ctNode, "strikerank", "number", nStrikeRank);
end

---

I also modified linkPCFields() and added a link to a aggregated SR value that is re-calculated when the underlying data is changed.

Code:

---

function linkPCFields()
        super.linkPCFields();

        local nodeChar = link.getTargetDatabaseNode();
        if nodeChar then
                pp.setLink(DB.createChild(nodeChar, "pp.current", "number"), true);
                wounds.setLink(DB.createChild(nodeChar, "wounds", "number"));
                hp.setLink(DB.createChild(nodeChar, "hp.max", "number"), true);

                initresult.setLink(DB.createChild(nodeChar, "abilities.dexterity", "number"), true);
                strikerank.setLink(DB.createChild(nodeChar, "sr.activeSR", "string"), true);
        end
end

---

As an added bonus the ordering of entries worked out by itself since high DEX = low SR.

I pushed a hotfix for the strike rank issue. I would look over the code for my implementation as it is somewhat different than the approach you have made.