Advanced Effects for 3.5E and Pathfinder

Hi

I have been having some serious issues with FGU since 4.3.3 but it seems to all come down to this extension.

It prevents the FHEAL effect from working. Once the combat tracker turn is ended and the next creature needs to have FHEAL applied (if they have damage) the effect does not work and triggers a console error.

This has the subsequent effect of being unable to apply or remove effects in the combat tracker using buttons on character sheets or even drag and drop. Also, if an effect is meant to expire it would not and just stayed at duration 1 round remaining.

Initially it was the Extended automation error that came up - [ERROR] Script execution error: [string "Full OverlayPackage:..ger_action_damage.lua"]:278: attempt to index local 'rSource' (a nil value)

When I turned this extension off, I then got this error when triggering the same event - Script execution error: [string "..PG-Advanced-Effects:..ipts/manager_AE.lua"]:577: attempt to index local 'rSource' (a nil value)

After turning off the Advanced Effects extension everything is working. I then turned on the Extended Automation extension and it is still working correctly.

I have attached the two compiled log files from my latest tests. If there is anything else you need to help with this please let me know.

Cheers,
Mike

Quote:

---

Originally Posted by Kronides

Hi

I have been having some serious issues with FGU since 4.3.3 but it seems to all come down to this extension.

It prevents the FHEAL effect from working. Once the combat tracker turn is ended and the next creature needs to have FHEAL applied (if they have damage) the effect does not work and triggers a console error.

This has the subsequent effect of being unable to apply or remove effects in the combat tracker using buttons on character sheets or even drag and drop. Also, if an effect is meant to expire it would not and just stayed at duration 1 round remaining.

Initially it was the Extended automation error that came up - [ERROR] Script execution error: [string "Full OverlayPackage:..ger_action_damage.lua"]:278: attempt to index local 'rSource' (a nil value)

When I turned this extension off, I then got this error when triggering the same event - Script execution error: [string "..PG-Advanced-Effects:..ipts/manager_AE.lua"]:577: attempt to index local 'rSource' (a nil value)

After turning off the Advanced Effects extension everything is working. I then turned on the Extended Automation extension and it is still working correctly.

I have attached the two compiled log files from my latest tests. If there is anything else you need to help with this please let me know.

Cheers,
Mike

---

Thanks for the report!
Looks like this has probably been broken for some time, although perhaps there was some change in 4.3.3 or the new ruleset versions that revealed the weakness.
Anyway, now it works :)

Quote:

---

Originally Posted by bmos

Thanks for the report!
Looks like this has probably been broken for some time, although perhaps there was some change in 4.3.3 or the new ruleset versions that revealed the weakness.
Anyway, now it works :)

---

No, it looks like it still isn't. I just now updated and tested again.
Perhaps I worded my previous post poorly. I believe that the error is only occurring when the Advanced Effects extension is active.

Quote:

---

Originally Posted by Kronides

No, it looks like it still isn't. I just now updated and tested again.
Perhaps I worded my previous post poorly. I believe that the error is only occurring when the Advanced Effects extension is active.

---

Yeah, that's how I tested it. Just AE and with an effect on a character with FHEAL only.
The same script error is... not possible with the latest code changes.
So either I messed up publishing it or the script error would have to be different now.
I just tried to reproduce the issue, but couldn't. I'll re-push the update and if you still get an error please let me know what it says now :)

I am still getting the [ERROR] Script execution error: [string "Full OverlayPackage:..ger_action_damage.lua"] when dragging damage onto a anything from the chat box.
i just wanted to check what current build number Advanced effects is just to make sure i have downloaded the right one

Quote:

---

Originally Posted by Arimil508

I am still getting the [ERROR] Script execution error: [string "Full OverlayPackage:..ger_action_damage.lua"] when dragging damage onto a anything from the chat box.
i just wanted to check what current build number Advanced effects is just to make sure i have downloaded the right one

---

v1.18-hotfix.1 is the latest

I think this error is coming from your amazing extension when I open the widow to add an effect to an npc
[2/27/2023 1:47:18 AM] [ERROR] window: Control (contentanchor) anchoring to an undefined control (title) in windowclass (advanced_effect_editor)

Quote:

---

Originally Posted by bmos

Yeah, that's how I tested it. Just AE and with an effect on a character with FHEAL only.
The same script error is... not possible with the latest code changes.
So either I messed up publishing it or the script error would have to be different now.
I just tried to reproduce the issue, but couldn't. I'll re-push the update and if you still get an error please let me know what it says now :)

---

Hi again, I just got a chance to test again with new hotfix version.

Testing with the hotfix version active and the Extended Automation and Overlays disabled - works without error.

Testing with Extended Automation and Overlays enabled and Advanced Effects disabled - works without error.

Testing with both enabled still gives this: Script execution error: [string "Full OverlayPackage:..ger_action_damage.lua"]:278: attempt to index local 'rSource' (a nil value)

Note that to get this error to generate put 2 creatures in the combat tracker A and B.

Give B FHEAL: 5 (or any value) and ALSO give it some wounds. If there are no wounds it does not fail.

Set the turn to A and then hit the end turn on the tracker - instead of the turn ending and B healing, there will be a note about FHEAL in the chat, and the console will come up with an error. From that point on any effects cannot be added or removed with buttons from the tracker.

I have attached another set of logs, can also report in the Extended Automation if you need me to?

Quote:

---

Originally Posted by Kronides

Hi again, I just got a chance to test again with new hotfix version.

Testing with the hotfix version active and the Extended Automation and Overlays disabled - works without error.

Testing with Extended Automation and Overlays enabled and Advanced Effects disabled - works without error.

Testing with both enabled still gives this: Script execution error: [string "Full OverlayPackage:..ger_action_damage.lua"]:278: attempt to index local 'rSource' (a nil value)

Note that to get this error to generate put 2 creatures in the combat tracker A and B.

Give B FHEAL: 5 (or any value) and ALSO give it some wounds. If there are no wounds it does not fail.

Set the turn to A and then hit the end turn on the tracker - instead of the turn ending and B healing, there will be a note about FHEAL in the chat, and the console will come up with an error. From that point on any effects cannot be added or removed with buttons from the tracker.

I have attached another set of logs, can also report in the Extended Automation if you need me to?

---

Ah, looks like Kel's extension needed to be patched also. I have submitted a fix there. Thanks for the added detail.

Hi,
Having a small problem. I trying to code a bane weapon, I'm using
IFT: TYPE (demon); ATK:2; DMG: 2+2d6
The attack works but the damage doesn't. I'm I doing something wrong?

Thanks
Kelly

Quote:

---

Originally Posted by backup42

Hi,
Having a small problem. I trying to code a bane weapon, I'm using
IFT: TYPE (demon); ATK:2; DMG: 2+2d6
The attack works but the damage doesn't. I'm I doing something wrong?

Thanks
Kelly

---

Try writing your damage as 2d6+2, that's the more common notation.

Didn't work. I also tried it without the plus 2 and no go. Maybe I'll restart Fantasy Grounds and see if that fixes it.

Restarting did not help. Is there any other extensions I need that work along side of this one?

Quote:

---

Originally Posted by backup42

Hi,
Having a small problem. I trying to code a bane weapon, I'm using
IFT: TYPE (demon); ATK:2; DMG: 2+2d6
The attack works but the damage doesn't. I'm I doing something wrong?

Thanks
Kelly

---

Try this -
IFT: TYPE(demon);ATK:2;DMG:2;DMG:2d6

The damage is not working at all, weird. Not even the plus 2.

I figured it out. it was his weapon. I deleted it and custom-made another one and it worked. I had to delete the attack plus 2 because for some reason it was adding plus 4 instead but after I delete the atk 2 it worked. Actually the attack works fine. He gets a +2 bonus against demons from a feat. So everything works as intended.
Playing with high level characters is tough lol

Quote:

---

Originally Posted by backup42

I figured it out. it was his weapon. I deleted it and custom-made another one and it worked. I had to delete the attack plus 2 because for some reason it was adding plus 4 instead but after I delete the atk 2 it worked. Actually the attack works fine. He gets a +2 bonus against demons from a feat. So everything works as intended.
Playing with high level characters is tough lol

---

Nice! Glad you found a solution. Weird details though!

Never mind Ignore me

Quote:

---

Originally Posted by backup42

I figured it out. it was his weapon. I deleted it and custom-made another one and it worked. I had to delete the attack plus 2 because for some reason it was adding plus 4 instead but after I delete the atk 2 it worked. Actually the attack works fine. He gets a +2 bonus against demons from a feat. So everything works as intended.
Playing with high level characters is tough lol

---

which code worked?

Quote:

---

Originally Posted by Morenu

which code worked?

---

I used bmo's custom item generator to make it, but if you don't have it the code is:

IFT: TYPE(demon);ATK:2;DMG 2d6+2

I am trying to figure out if there is a way to have a feat, trait or item add an effect to the ability tab other than naming the item a spell name (like Potion of spider climb).

If I wanted to have a Feat that gave a usable power instead of an always on power without the player having to create the actual effect on the ability tab.

So right now lets say I wanted a hat of disguise to automatically place a disguise self spell in the abilities tab (under items on advanced character sheet), I can cheat and call it Hat of disguise self and make it a scroll (or wand or potion I suppose) and it does this: Attachment 58294. The red circle is what I would like to be able to do so I could call up a specific spell. Then I could create spell effects for feats, traits and whatever and then call that "spell" effect automatically when the feat or trait or item is equipped.

I am not sure if that makes sense, but I thought it would be a way to do the PFRPG - Feats in an extended version like Spellbook Extended.

And if you would rather this be moved to another thread I can delete it and redo it elsewhere, but this idea requires this extension to be active.

Quote:

---

Originally Posted by Morenu

I am trying to figure out if there is a way to have a feat, trait or item add an effect to the ability tab other than naming the item a spell name (like Potion of spider climb).

If I wanted to have a Feat that gave a usable power instead of an always on power without the player having to create the actual effect on the ability tab.

So right now lets say I wanted a hat of disguise to automatically place a disguise self spell in the abilities tab (under items on advanced character sheet), I can cheat and call it Hat of disguise self and make it a scroll (or wand or potion I suppose) and it does this: Attachment 58294. The red circle is what I would like to be able to do so I could call up a specific spell. Then I could create spell effects for feats, traits and whatever and then call that "spell" effect automatically when the feat or trait or item is equipped.

I am not sure if that makes sense, but I thought it would be a way to do the PFRPG - Feats in an extended version like Spellbook Extended.

And if you would rather this be moved to another thread I can delete it and redo it elsewhere, but this idea requires this extension to be active.

---

So like instead of just adding effects items could also add abilities? Great suggestion, but not currently possible with this. Not sure when I could build it out either, I have a big backlog of issues right now.

Glad you like the idea. I really wish I could wrap my mind around the coding. I feel like I would enjoy making extensions.

I would think the easiest way would be to make a "spell" for the feat or trait or item, Name the spell the same as the feat/trait/item with effect at the end. then add that spell to the feat effect. and preferably have it work with adv. character sheet and be able to define it to go to spell/weapon/item/other under the ability tab.

well glad you like the idea, guess I will go watch the ruleset wizard videos again. :)

That would probably be a magic item compendium module that has the magic items with built on effects (probably with the extended item extension required). I could see it getting rather ugly coding it depending on what extensions are already in use and how they interact with items, inventory, and the abilities tab.

I was thinking something like this Attachment 58478 where I could go to The arcane Strike feat and under the effect, have a way to call this spell to be put on the action tab. so something like [SPELL Feat Arcane Strike] and when the feat is added to the character sheet, it automatically adds the spell as well.

I was thinking something like this Attachment 58478 where I could go to The arcane Strike feat and under the effect, have a way to call this spell to be put on the action tab. so something like [SPELL Feat Arcane Strike] and when the feat is added to the character sheet, it automatically adds the spell to the action tab as well.

What does unlisted mean in the forge? This extension is showing up with that on my list of extensions.

Quote:

---

Originally Posted by rmilmine

What does unlisted mean in the forge? This extension is showing up with that on my list of extensions.

---

It might be in the middle of being updated.

Quote:

---

Originally Posted by rmilmine

What does unlisted mean in the forge? This extension is showing up with that on my list of extensions.

---

Thanks for that, looks like I might have hit the wrong button!

So how might i use this to change the damage type of a weapon? For example, a bow using silver arrows, changing the damage type of the bow to silver when the silver arrows are equipped via the ammunition manager extention?


Edit: Found my own answer minutes after making this post
Add 'DMGTYPE: silver' to the arrow's effects directly.

The latest Fantasy Grounds update on 8/17/24 broke the Feature Advanced Effects for Pathfinder, as well as a complimentary Feature: Extended Automation and Alternative Overlays by Kelrugem.

Submitted a pull with a fix for item sheets losing AE and throwing errors.

Quote:

---

Originally Posted by Azure Fang

Submitted a pull with a fix for item sheets losing AE and throwing errors.

---

Thank you!
Just pushed the release :)

Quote:

---

Originally Posted by bmos

Thank you!
Just pushed the release :)

---

That fixed the issue that I was seeing. No more errors. Thanks bmos

You're welcome, but all credit goes to AzureFang for this one!
I just clicked the button to send it to the Forge :)

Never mind. Didn't see the latest messages before posting.

Quote:

---

Originally Posted by bmos

You're welcome, but all credit goes to AzureFang for this one!
I just clicked the button to send it to the Forge :)

---

Oops, sorry about that. Thank you Azure Fang

It looks like there is still a visual glitch with Advanced effects. When the item is locked it shows fine:

Attachment 61680

But when unlocked, it conflicts with GM notes. Which I think is another mod now that I am thinking about it. The advanced effects used to be above the item description so there was never any conflict, but it seems to have been moved to the bottom and it causing some crazy text.

Attachment 61681

I am not sure if you can correct this issue and maybe move it back to just above the item description, or if this will be an issue for the gm notes mod.

Thanks,
-Elaith

Hi
If you use variables in that effects (example: has +1 CA each 4 levels, with a class feature, and I write "AC: [QLVL]" in his class feature), how could I recalculate the variables when it should change?

I see if I edit the effect, add one whitespace and remove it, the value is recalculated, but then I need to edit all the class abilities, feats and traits when something changes.

Following the example, should I edit all the features with [LVL], [QLVL] and [HLVL] each level up to add and remove a withespace?

Thanks for your help!

I believe you can just remove and readd them to the Combat Tracker and everything recalculates

Posted a conflict in this thread, copying the basics below:

Quote:

---

Hey Bmos, for a graphic issue with 2 of your extensions. Advanced Effects and Enhanced Items. Here is a merged screenshot of only those 2 extensions loaded and what is happening (and a fresh update)

Attachment 61845

---