So I discovered a very small problem tonight. It was discovered while troubleshooting another effect that wasn't working correctly. It is a very edge case and it appears that critical hit confirmation rolls are not applying ATK bonus effects in all cases.
Here is what I found.
If I make an attack roll without any effects, critical hit confirmation rolls never error. The proper bonus is applied to the initial roll to hit and the confirmation roll.
If I make an attack roll with a flat ATK bonus effect, say (Test; ATK: 2), the bonus always applies to the initial roll to hit and and the roll to confirm.
However when using "IFT: ALIGN (alignment)" with an ATK roll bonus or penalty, it applies it to all normal attacks and it applies to the initial roll to hit on a critical threat. However on the roll to confirm critical hits it doesn't apply the bonus on the roll. I will point out, I do include a proper alignment in the condition statement.
I've tried it with multiple different alignments for the ALIGN conditional operator and it always happens. I've not tried it with other types of conditional operators to the IFT condition, but based on it not working correctly for ALIGN, I would assume it doesn't work for any of them. I'm attaching a screen shot of a Sahuagin which has attacked one of the PCs in my campaign. The PC's alignment is set properly, his is LN, and the IFT statement is looking for lawful alignment. As you can see the initial roll that threatens does apply the bonus but the confirmation roll doesn't. Also ignore the fact that I have invalid stats for the trident. I'm only using these values to illustrate a point and make it easier to get a critical hit event to trigger.
Attachment 37674
If you want I can post a screenshot of it working when I use just a flat bonus to ATK as an effect, but I don't feel that it would contribute much.