Equipped Effects Extension (.ext file) [Fantasy Grounds Unity]

Aridhro has delivered his latest set of data conforming to the name matching I support in equipped effects. The latest addition in here was to pave the road for his latest Monster Manual supplement data in 5E Automated Effects which he has just delivered. A note on the NPC stuff (his monster manual data provides these PC power actions for them and chat boxes to do it manually without my stuff - you'll have to read up on it)...

Just remember your CT will not auto update - you will have to drag the chat data into it - or use equipped effects - and FGU only EVER changes that CT action list when the NPC is initially added into the CT. So existing campaigns with an active combat tracker would have to have the NPCs removed and readded into the CT. The reason I do not allow this to automatically happen is because it is pandora's box when someone has NPCs they have locally defined in CT (you don't want to change those automagically - which is probably why FGU only updates on the add into the CT)

V 1.32 - Conflict - the conflict I resolved in V1.27 was only resolved by making the other extension work - mine still did not translate NPC powers at all. I have hopefully, and finally, resolved this conflict so that I actually work also.

Note - if you use "Translate NPC Powers" with Advanced Spell Damage extension not all of the upcasting will be parsed as the data is no longer the same for things as it used to be. They now include all of the power actions defined - if they are defined. That is a limitation in using these extensions together. You can just turn off "Translate NPC Powers" if you want the original data and the original parsing of that data in Advanced Spell Damage to fully play out. Same for Spell Tokens. See Aridhro's workaround below.

Quote:

---

Originally Posted by SilentRuin

Note - if you use "Translate NPC Powers" with Advanced Spell Damage extension not all of the upcasting will be parsed as the data is no longer the same for things as it used to be. They now include all of the power actions defined - if they are defined. That is a limitation in using these extensions together. You can just turn off "Translate NPC Powers" if you want the original data and the original parsing of that data in Advanced Spell Damage to fully play out. Same for Spell Tokens, though that can be worked around if you do something elaborate like first turn off "Translate NPC Powers" and take the resulting NPC you add into the CT and copy it back into NPC list. Then remove from CT - and take that copy and put it back in. Or so I'm told.

---

I can confirm the following workaround works for both 'Advanced Spell Damage' and 'Spell Tokens'

Workaround 1 (CT to CT)
Set "Translate NPC Powers" option to OFF
Add NPC to CT
Set "Translate NPC Powers" option to ON
Drag NPC from combat tracker to combat tracker


Workaround 2 (CT to DB to CT)
Set "Translate NPC Powers" option to OFF
Add NPC to CT
Drag NPC from CT to NPC list (putting it in your campaign db)
Set "Translate NPC Powers" option to ON
Add your newly made NPC to CT

(second workaround lets you prep all your casters in advance)

Result:
NPC with spell tokens, upcasting ability and most importantly: The 5eAE DATA

I wanted to say thanks!
This helps so much!
Rock On!

V 1.33 - Feature - added option "Item Subtype Search (requires restart)" defaulted to on. This will add a subtype search to the Item list. Largely because I've always been annoyed I could not search for ammunition and had to dig through tons of entries to find them. Plus its useful for other stuff. If another extension your using modifies the item list you can just turn this option off and restart the app.

I grew annoyed at never being able to search for subtypes in my world. So as I was modifying notes and spells already in here I added in items. Optionally of course in case it is not wanted by others or something someone else uses already does it. Pretty much for me.

Any search improvement is a good improvement. Still waiting for a means to search for all "Fae" up to level X.

When loading this extension into a PFRPG campaign, no other extensions at all, NPC records have the "Spells" tab replaced by a copy of the "Other" Tab.

Its a 5E extension.

From the readme in the original post:
Equipped Effects Extension (.ext file) [Fantasy Grounds Unity (2E/3.5E/4E/5E/CoreRPG/PFRPG/PFRPG2/SFRPG rulesets)]

Ruleset definitions from the extension itself:
<ruleset>
<name>2E</name>
</ruleset>
<ruleset>
<name>3.5E</name>
</ruleset>
<ruleset>
<name>4E</name>
</ruleset>
<ruleset>
<name>5E</name>
</ruleset>
<ruleset>
<name>CoreRPG</name>
</ruleset>
<ruleset>
<name>PFRPG</name>
</ruleset>
<ruleset>
<name>PFRPG2</name>
</ruleset>
<ruleset>
<name>SFRPG</name>
</ruleset>

So no, it's not just a 5E extension, and if it is then SilentRuin needs to take all those other rulesets out and I'd be pretty disappointed I spent money on something that said it would work for PFRPG and then just didn't.

From the product page

"Note: This extension was created for Fantasy Grounds Unity 5E ruleset. It has not been extensively tested on FG Classic and thus will not be supported / maintained with FG Classic in mind. Use on FGC at your own risk.
Also, understand that Extensions = RISK: We want users to understand that extensions are code that is added or overrides portions of code in the Fantasy Grounds Unity (FGU) application. When the underlying code in FGU changes it can break an extension. We promise to maintain support as FGU is updated. When you run with other extensions they can conflict by trying to overwrite the same parts of the FGU code. We will keep this extensions working with FGU changes, and other extensions created by SilentRuin. We make no promises to resolve conflicts caused by extensions created by other authors."

It's sold on the Dmsguild which is only permitted for products for 5E.

I may be wrong but I don't see it advertised as anything other than 5E.

You want me to go through, post by post, showing you the places in this thread and in the comments on that very product page where he says that it's not just for 5E, or do you want to let the developer answer?

Quote:

---

Originally Posted by ChrisRevocateur

You want me to go through, post by post, showing you the places in this thread and in the comments on that very product page where he says that it's not just for 5E, or do you want to let the developer answer?

---

Ok the other tab I assumed was generic. Keep in mind I ONLY do this for 5E, though originally some people in the early days wanted it for effects in other things and I saw no harm in leaving the extension.xml with those as long as I guarded it with 5E only. I'll take a look if something slipped through - but honestly I left that crap in there way after I added the bulk of the functionality - which is clearly only for 5E which is all I use this in per all the warnings I put out.

Quote:

---

Originally Posted by ChrisRevocateur

You want me to go through, post by post, showing you the places in this thread and in the comments on that very product page where he says that it's not just for 5E, or do you want to let the developer answer?

---

Ok I can see having legacy users from last year when I first did this before it went to DMsG and made all my DMsG pages state it was 5E was when I started insuring I guarded against anything 5E only just in case people still had it from way back then. I did not know "other" was something not generic that I could replace but now its guarded. No version change for this as really this effects nobody but where NPC other could not be morphed for the first link translate stuff I was required to put in per WOTC/SW directive on insuring modules that had supplemental data still required the modules they were based on to be loaded. You should have a downloadable version in DMsG with no version change.

If at some point I'm forced to change extension.xml I will - and if I am - then you'll have to add the things you think it can support back in. For now, I'll leave that legacy stuff in as it would not be ethical to suddenly stop supporting the minor stuff just because I've never used those other rulesets. Except in VERY superficial testing last year when I first wrote this just for custom effect name matches. It has moved way past that feature though.

I use this extension with 4e all the time and it’s great. I hope that complainer didn’t ruin it for everybody else.

Quote:

---

Originally Posted by SilentRuin

Ok the other tab I assumed was generic. Keep in mind I ONLY do this for 5E, though originally some people in the early days wanted it for effects in other things and I saw no harm in leaving the extension.xml with those as long as I guarded it with 5E only. I'll take a look if something slipped through - but honestly I left that crap in there way after I added the bulk of the functionality - which is clearly only for 5E which is all I use this in per all the warnings I put out.

---

Thank you for looking at it. I understand you only aim at 5th Edition, and so things like this are gonna slip through. I really just wanted to let you know about the issue I found so you could decide what to do about it, if anything.

V 1.34 - Feature - new option "Process Multiple Effect Names" defaulted to "off" will allow multiple name matches in custom effects. If you have duplicates in there that you do not wish to process then this should stay "off" - original behavior. But some people require different IF logic in effects which requires separate effect line entries so added this option in. For example, if you have an item name of "Blah" and in custom effects have "Blah; 'test 1", "Blah; 'test 2", and "Blah; 'test 3" you will see all 3 of those effects added into CT when this option is on.

Someone mentioned they had some effects with different IF requirements which could not be put in one custom effect definition. I did not want to change the current behavior of only using first match in case of duplicates or local DB overrides from module custom effects so made the default option "off". Note every match now has to cycle through whole custom effect list with this "on".

Quote:

---

Originally Posted by SilentRuin

V 1.34 - Feature - new option "Process Multiple Effect Names" defaulted to "off" will allow multiple name matches in custom effects. If you have duplicates in there that you do not wish to process then this should stay "off" - original behavior. But some people require different IF logic in effects which requires separate effect line entries so added this option in. For example, if you have an item name of "Blah" and in custom effects have "Blah; 'test 1", "Blah; 'test 2", and "Blah; 'test 3" you will see all 3 of those effects added into CT when this option is on.

Someone mentioned they had some effects with different IF requirements which could not be put in one custom effect definition. I did not want to change the current behavior of only using first match in case of duplicates or local DB overrides from module custom effects so made the default option "off". Note every match now has to cycle through whole custom effect list with this "on".

---

Based on you last line do you see a performance impact with this on?

Quote:

---

Originally Posted by Leprekorn

Based on you last line do you see a performance impact with this on?

---

As I don't plan to use it - would I care? ;) In my tiny test - with all of Aridhro's data to find 4 versions of "Torch" one of which was his - I saw no noticeable hit. But of course, I added that line as a WARNING to those who do plan to use it.

Fair enough :D

V 1.35 - Bug - feature/trait/feat could grab a spell instead of a power which caused issues if you had a spell and one of these named the same. Now check that DB level value is 0 for any matching spell to a feature/trait/feat which is what a power should be in this world. Nothing else (items/NPC CT action list) name matching is effected - only feature/trait/list name matching - which now has additional check to make sure level data is undefined or 0. Fixed.

Basically, you should see no impact and have to do nothing with this version change. Essentially it should have never been finding spells only powers for feature/trait/feat name searches for spells and we make that determination by checking the level value as 0. It only effects people with spell name and feature/trait/feat name conflicts where the same name was used but have completely different functions (different spell/power defintions). This would be resolved by leaving the spell name definition alone (had a level) and making sure the spell/power defined for the feature/trait/feat has level 0 defined in it. Cantrip name conflicts your screwed I can only do so much. Also, If you had for some reason used a spell/power with a non 0 level defined as a match for a feature/trait/feat (you should not have) then simply edit the level attribute to 0 and it will find it again. This will not effect spell name matching for equip/unequip items (original feature of this extension) but only the feature/trait/feat spell (power) name matching.

V 1.36 - Bug - Weapon powers are usually created with PCs in mind. And PCs have a separate section in action page for weapon attack/damage. NPCs do not. They have the highlight-able text (usually not very reliable for complex save/effects) and the action list in the CT. If you define a power for an NPC it would always replace the text translation. This would lose the attack/damage info of a weapon (as the power - designed for a PC - would never include that data). This was fixed by adding in the first parsed text up to a powersave or effect for things that had "weapon attack" in description. Result being, NPCs would now have the action list with the attack/damage data for the weapon followed by whatever power was added in, where previously it would be missing (only present in NPC sheet text). Hard to describe this bug, but that is the best I can think to explain it.

You can still always turn off the NPC translation of powers in options if you want.

Hi, is there anything planned to visually show the effects on the datasheet? Like if you have +2 AC that you can see the correct value like "16 base + 2 from a magic item equals 18"? Right now you can only see the base value, and if you get hit you see the magical effects summed up, but in case you need the AC value you cannot see it directly. Same goes for stats and such.

Anyways, the extension is really cool. Thanks for that!

Quote:

---

Originally Posted by masterqgj

Hi, is there anything planned to visually show the effects on the datasheet? Like if you have +2 AC that you can see the correct value like "16 base + 2 from a magic item equals 18"? Right now you can only see the base value, and if you get hit you see the magical effects summed up, but in case you need the AC value you cannot see it directly. Same goes for stats and such.

Anyways, the extension is really cool. Thanks for that!

---

FGU is designed to work with a sheet hardcoding the data that you manually operate on yourself. Effects in FGU are for applying things that are changeable and applied to the rolls on the fly and sometimes only effect them in certain circumstances. FGU will never modify the sheet based on an effect or power definition. Neither will this extension. If you have a feature/feat/trait/item for an NPC or PC that is applied that is going to do a name search and if it finds a match apply and effect and/or power definition to the NPC/PC. In no way will this make effects/powers behave differently than in the stock FGU scenario.

Now armor can modify the AC as you point out but that has nothing to do with this extension. If you have a magic item equipped - that had a modifier - that is only good as long as that item is equipped. And if FGU underlying logic went in and hashed that out and modified your AC - all well and good. But it does not. Nor will this extension as how effects/powers work has not changed - all that has changed is that this will apply name matching effects/powers - it won't change how those get applied or work in FGU.

Short answer, if FGU modifies the sheet based on an effect/power then this will also - its the same operation happening. If it does not, then as this changes none of those applied effect/power operations - neither will it.

Hello SilentRuin,

thanks for the explanation. I'm a bit sad, that FGU does not work differntly, but i guess it is as it is :).

Hello,

i just found a strange behaviour and am not sure if that is right, or what i'm doing wrong. If i add an effect like "Armor; AC: 1" for 1 round and equip the item "Armor" the status effect is lost when you're making a long rest. Do i have to increase the duration? Isn't the extension intended to work around such "issues" or what am i doing wrong?

[Edit] Oh, i saw in the video the duration has to be "0" in this case - is that right?

Quote:

---

Originally Posted by masterqgj

Hello,

i just found a strange behaviour and am not sure if that is right, or what i'm doing wrong. If i add an effect like "Armor; AC: 1" for 1 round and equip the item "Armor" the status effect is lost when you're making a long rest. Do i have to increase the duration? Isn't the extension intended to work around such "issues" or what am i doing wrong?

[Edit] Oh, i saw in the video the duration has to be "0" in this case - is that right?

---

Again, NOTHING to do with this extension. Effects and powers work as they always do in FGU. This extension has no control over how they work. But yes - in FGU - effects of duration 0 are considered permanent.

Thx again and my bad :( i didn't know that 0 was the standard FGU behaviour. Sorry.

There’s a conflict with other extensions which add index buttons to library windows like “items” using the LibraryData.addIndexButton() function. For instance, the 5E Random Spellbook Generator adds a button to bring up the generator to the item list. This button is inaccessible while Equipped Effects is loaded, so I suspect something is being overwritten.

Quote:

---

Originally Posted by pr6i6e6st

There’s a conflict with other extensions which add index buttons to library windows like “items” using the LibraryData.addIndexButton() function. For instance, the 5E Random Spellbook Generator adds a button to bring up the generator to the item list. This button is inaccessible while Equipped Effects is loaded, so I suspect something is being overwritten.

---

Ok its resolved. FGU has LibraryData structures that I replace and add in things. A while back I added options to resolve any conflicts these caused.

So when you have spell list conflicts (for where I add in import/export buttons which are purely optional) you turn off "Spell Import Export(restart app)" and restart the application.

When you have item list conflicts (like this one - where I added in subtype search for item list) you turn off "Item Subtype Search(restart app)" and restart the application.

I've forgotten most things I've added into my extensions which is why I maintain these threads which contain all the original reasons (like these) on why I added things in.

In the end I wrote this stuff for ME and add things in I want over time.

Quote:

---

Originally Posted by SilentRuin

So I've been told. As I don't use these or have any idea what they do I've tried to guess today on what might be something generic I'm not doing correctly. The XML modifications on my side are joins - so as long as the other extensions play nice it should not be that. There are templates involved also - which are typically unshareable with other code which is why I hate them. I'm trying one "guess" to see if the inner workings of a template can call its own super.onInit() in case that's even possible - but if that fails its just an "unknown conflict" until some author explains what it is as I don't use them.

The author of any of these things can feel free to DM me in discord if they have something generic I can supply to resolve it or if I have a bug that somehow causes it. But some things just conflict and I won't add in specific code that is not generic to mine. Its hard enough tracking all the myriad of FGU changes every time they update without trying to manage everything else under the sun in a non generic manner. I've supplied overrides and such (wish FGU would do that) to reach some internals in the code before but that was generic change which I'm always willing to do.

For now, I've not heard back from the person willing to test my "hail mary" with no knowledge of what the other stuff does - but not holding my breath. Some things just conflict - especially if they share template code.

---

This is all the other extension does by utilizing base code within a unique lua script if that helps.

Code:

---

function onInit()

    aRecords = LibraryData.getRecordTypes();
    for kRecordType,vRecordType in pairs(aRecords) do
        if vRecordType == "item" then
            LibraryData.addIndexButton(vRecordType, "button_spellbookgenerator");
        end
    end
end

---

I edited out that message as it was resolved - I explained it here...

Quote:

---

Ok its resolved. FGU has LibraryData structures that I replace and add in things. A while back I added options to resolve any conflicts these caused.

So when you have spell list conflicts (for where I add in import/export buttons which are purely optional) you turn off "Spell Import Export(restart app)" and restart the application.

When you have item list conflicts (like this one - where I added in subtype search for item list) you turn off "Item Subtype Search(restart app)" and restart the application.

I've forgotten most things I've added into my extensions which is why I maintain these threads which contain all the original reasons (like these) on why I added things in.

In the end I wrote this stuff for ME and add things in I want over time.

---

It's entirely possible I could write some elaborate parsing of the existing structure and add my stuff into the existing one or modify it - but just not worth it for optional stuff I don't need.

Hi,
just discovered that you can´t edit the 'Other' tab of NPCs if this extension is running.
Tested it with a fresh campagin an only this extension loaded.

Running Version is 1.36

I have no problem editing the other tab for npcs.

Quote:

---

Originally Posted by Skexis Chamberlain

Hi,
just discovered that you can´t edit the 'Other' tab of NPCs if this extension is running.
Tested it with a fresh campagin an only this extension loaded.

Running Version is 1.36

---

My "sLavage" Orc says otherwise. You'll have to explain exactly what you think your seeing so I can duplicate it. I trust your not trying to "edit" some first link display text or something as that would not be editable. Or even visible without my extension (it's optional also).

This is a brand new NPC and I can´t click into the field to write anything down.

You can edit text, that ist already in the "Other" Tab, but if it´s empty you cant "activate" it to enter text.

Quote:

---

Originally Posted by Skexis Chamberlain

This is a brand new NPC and I can´t click into the field to write anything down.

You can edit text, that ist already in the "Other" Tab, but if it´s empty you cant "activate" it to enter text.

---

[Post Edit] Could not duplicate - was able to put in text to other page just fine. Just hard to see flashing vertical line cursor with Sir Motts theme. Click on window - start keying in - works.

Here look at this new npc. The cursor is right below the brown line. You need to place the cursor there first.
Attachment 48362