Hi,
New update broke the extension.
Attachment 56353
Printable View
Hi,
New update broke the extension.
Attachment 56353
Pushed v1.13-hotfix.1 to hopefully sort out the UI issues that came along with v1.13.
It ended up being quite a bit of further work to do this (153 lines of code changed, 65 lines removed), so hopefully nothing else breaks as a result!
Thanks for fixing this!Quote:
Originally Posted by bmos
Still seeing issues:
hotfix.2 pushed. thanks!
Looks good. Thanks for the fast fix!
I am getting this error whenever I load it into a Pathfinder 2e system:
[2/26/2023 2:59:22 PM] [WARNING] Could not load script file (FG-CoreRPG-Extraplanar-Containers) (C:item_main:extraplanarcontents) (campaign/scripts/extraplanarcontents.lua)
[2/26/2023 2:59:22 PM] [WARNING] Could not load script file (FG-CoreRPG-Extraplanar-Containers) (C:item_main:contentsvolume) (campaign/scripts/contentsvolume.lua)
It seems to be working just fine though.
I'm also running Pathfinder 2, Extension runs fine for me, without any Errors or Warnings.Quote:
Originally Posted by Idward
Sorry this is such a late response! What version is listed in the chat when you load the extension? It should be v1.13-hotfix.3.Quote:
Originally Posted by Idward
Extraplanar Containers v1.14-hotfix.1
- Support Pathfinder 2e-style items that ignore N weight units. Syntax of this is "the first 2 bulk of these items don't count against your bulk limits" as found here.
- To support this, the weight of items in mundane containers is now counted by combining the subtotals of each mundane container with the subtotal of items not in a container rather than by counting each item not in an extraplanar container.
- Some other code cleanup also included.
- HOTFIX: Better string search. No longer case sensitive, "of these items " now optional.
Click here to see raw code changes
https://i.imgur.com/bM5QnFv.png
Could this be made to work for the Starfinder equivalent of bags of holding? (Null-Space Chambers)
Editing this used to work, however, I think I am struggling with the Forge adding this vs having a local copy of the ext in my extensions directory.Quote:
Originally Posted by bmos
I wanted to make sure I had the latest file from the forge so I deleted my extensions for my extensions folder.
They updated and this one was working, however, it no longer appears in my folder and seemingly now ignores any new changes to this custom config file.
I went to the git hub page and manually downloaded and added it but still no luck. Any ideas?
--
-- Please see the LICENSE.md file included with this distribution for attribution and copyright information.
--
function onInit()
table.insert(ExtraplanarContainers.tContainers, 'belt')
table.insert(ExtraplanarContainers.tContainers, 'box')
table.insert(ExtraplanarContainers.tContainers, 'case')
table.insert(ExtraplanarContainers.tContainers, 'chest')
table.insert(ExtraplanarContainers.tContainers, 'cofffer')
table.insert(ExtraplanarContainers.tContainers, 'handbag')
table.insert(ExtraplanarContainers.tContainers, 'outfit')
table.insert(ExtraplanarContainers.tContainers, 'mount')
table.insert(ExtraplanarContainers.tContainers, 'purse')
table.insert(ExtraplanarContainers.tContainers, 'sack')
table.insert(ExtraplanarContainers.tContainers, 'saddlebags')
table.insert(ExtraplanarContainers.tContainers, 'spellbook')
table.insert(ExtraplanarContainers.tContainers, 'vest')
table.insert(ExtraplanarContainers.tContainers, 'Wayfinder')
table.insert(ExtraplanarContainers.tExtraplanarCon tainers, 'bank')
table.insert(ExtraplanarContainers.tExtraplanarCon tainers, 'boat')
table.insert(ExtraplanarContainers.tExtraplanarCon tainers, 'dog')
table.insert(ExtraplanarContainers.tExtraplanarCon tainers, 'horse')
table.insert(ExtraplanarContainers.tExtraplanarCon tainers, 'house')
table.insert(ExtraplanarContainers.tExtraplanarCon tainers, 'mount')
table.insert(ExtraplanarContainers.tExtraplanarCon tainers, 'ship')
table.insert(ExtraplanarContainers.tExtraplanarCon tainers, 'all tool Vest')
end
The second set has a typo where you have a space in the word Containers so it's "Con tainers"
I'd also suggest you delete the Extraplanar Containers ext file (so that you always have the latest from Forge) and just keep your custom config ext file.
I just confirmed that the latest extension version is working.
So when I delete the extension from my extension folder, it never returns. Only the customcontainers.lua remainsQuote:
Originally Posted by bmos
When I look at the customcontainers.lua, I do not see the typo in Notepad or Notepad++
Attachment 57576
My extensions download to the vault to avoid the confusion of "did I install this manually or from the Forge?" so it's normal not to see it in the extensions folder.
I think you have shown the problem. You can't load a lua file in FG except as part of an extension or ruleset.
In your extensions folder, you should have a file called FG-CoreRPG-Extraplanar-Containers-Custom-Config.ext. Inside of this should be everything that comes in that file from the first post.
You can make changes to the customcontainers.lua file, but it has to stay inside the ext file.
Understood, the Forge places extensions in the Vault folder and is no longer placed in the extensions folder.Quote:
Originally Posted by bmos
Per your instructions, my FG-CoreRPG-Extraplanar-Containers-Custom-Config.ext is inside the extensions folder
When I edited the FG-CoreRPG-Extraplanar-Containers-Custom-Config.ext file when I did not have the forge version, the edits functioned as anticipated, however, now that I have the forge version, it appears my edits do not function any longer.
I verified there were no typo in the file.
When I edit that file, I rename it to .zip and extract the contents.
I open the .lua file in Notepad ++. I make my edits and save the file, then re-zip the folder, rename the zip file back to .ext, and replace the file in the extensions folder. (I presume this is how it should be done?)
For now, I will continue to test or forgo editing the file and simply include the word (container) in any item name that fails to function as expected. This has the desired functionality of making the item collapsable.
Can you attach your edited ext file here?Quote:
Originally Posted by The Judge
Another solution: you don't have to zip the folder back up. Just move the FG-CoreRPG-Extraplanar-Containers-Custom-Config folder into the extensions folder and delete the FG-CoreRPG-Extraplanar-Containers-Custom-Config.ext file. Then changes are very easy.
Here is the ext fileQuote:
Originally Posted by bmos
That's what I figured, you have an extra folder in there because you zipped up the FG-CoreRPG-Extraplanar-Containers-Custom-Config folder instead of its contents.
So just drag the folder out of the zip into your extensions folder and it should work ok. Don't forget to load it in the FG launcher.
Thank you sir, the folder in the folder was the issue.Quote:
Originally Posted by bmos
Yeah, I'd also really like to know if it's possible to get this extension to work with the Starfinder ruleset?Quote:
Originally Posted by JackBroady
It does already, presumably?Quote:
Originally Posted by sirkerry
( https://github.com/bmos/FG-CoreRPG-E...db866aab988f2f -- added it to the list of extraplanar containers).
Not a Starfinder player, but since the description seems to be along the lines of "you can close up to <x> bulk in this" -- i.e. it's more a Bag of Holding that can contain up to X weight and none of it counts, rather than a PF2e-style backpack where it can contain up to X bulk and Y doesn't count where Y < X, it should be correct?
(Only stumbled across this thread today, because I'd not realized that it did implement that PF2e backpack and was a bit puzzled that bulk didn't change when I was trying to move items contained within a backpack to a custom extradimensional container set up to abstract away that 2 bulk. It was already being correctly handled, so total bulk wasn't changing and I didn't need to spend time adding a silly "free2bulk" container).
While the container name is supported, I didn't finish adding support for the ruleset overall. I'll try and remember to do that when I get a chance.
I located the correct file in the vault to edit but the extension is encrypted and requires a password. I took a look through the forums and discovered that when you upload an extension to the forge you can choose to have it encrypted or not. If it's encrypted no one can edit the .lua to add additional containers to the extension.
bmos publishes the whole source code on github: https://github.com/bmos/FG-CoreRPG-E...nar-ContainersQuote:
Originally Posted by Bearded Wonder
Not sure if this is the latest version, but you can download it (green Code button) as zip, unpack, edit, zip it up again and rename as .ext and place it in the extension folder (on your PC). Just don't forget to disable the Forge version (on the Forge inventory web page) and remove the live extension from the vault folder, otherwise you have it doubled.
I contemplated doing that. It reintroduces the issue of "did you download it from github or from the forge" that bmos said he was trying to avoid back in June. I was bringing it to his attention because it's an option as an extension author that he may or may not have intended to select. If his intent was to leave it accessible for us to muck around with and customize then there is an option that he can select somewhere in the forge to remove the password lock for the vault. I had no idea that the option even existed so he might not either. If he wants to keep it password protected that's fine, it just prevents customizing the .lua file.
Agreed - this indeed brings (back) a lot of logistics on "which version is active". I usually use text files with same file name in each folder to note source (extensions) and content (for vault files) - and if there is another source currently not used.
But I agree - vault provides limited added value for free extensions.
In the first post of this thread there is an attachment which allows you to customize container names :)
First, I love this EXT <3
today, I doubleclicked the "[+] Bag of Holding" entry to open its window, I edited the capacity and closed the window. Unfotunately, since then, the collapsed BoH has disappeared from the PC inventory, and if I type as much as "Bag" into the location for any other item in the inventory, that entry disappears as well (and seems to get added to the Bag, as adding 600 lbs of "Stuff" causes the 'overfull' message to appear). I'd love to edit the item name for the BoH but as it's not in the inventory anymore, I cannot access it.
What can I do?
Yeah, that's a known problem! You can just disable the extension which will show you all the items in the inventory. Then you can just move back out of the bag.Quote:
Originally Posted by Roach
Need to update it someday so you can't put two containers into each other...
I have found that if this happens, simply expand all collapsed containers and the originals re-appear.
FGU: v4.4.5 ULTIMATE (2023-10-26)
When adding something into the container that exceeds the weight limit, I have a console error pop out
[ERROR] Handler error: [string "..raplanar-Containers:..ts/char_invname.lua"]:48: setFrame: Specified frame does not exist. (required)
I see on GitHub "This extension has been tested with FantasyGrounds Unity v4.3.8 (2023-04-25)."
Is there any hope of an update for this extension (jingles bag of forge coins) I can add some incentive if it helps.
I think the remaster update has made your extension not recognize the legacy ruleset as my containers no longer show the controls for setting weights or seeing current bulk. Can you add the PF2-legacy ruleset name so it works.
thanks
In case it helps, the ruleset name that needs to be added is:
PFRPG2-Legacy
Same thing happenning in 5e as well.Quote:
Originally Posted by The Judge
Thanks for the report and sorry it took a while to address.Quote:
Originally Posted by The Judge
This issue should be fixed. They changed the frame type "required" to "fieldrequired" in CoreRPG and I had to adjust the extension to use that new frame definition instead.
The extension is still not working. I reverted back to the legacy rules and the containers stop showing their bulk details. I think if you can just add the legacy ruleset (PFRPG2-Legacy) it would load the extension in games using that ruleset. Thanks
Thanks! It does look to be fixed in 5e.Quote:
Originally Posted by bmos
Thanks for the heads up. I think PFRPG2-Legacy should work with Extraplanar Containers now.Quote:
Originally Posted by DonE66
It is working now. Thank you!
I did notice the nice feature of highlighting in red a container that is over weight is not persistent between games. Is there a way to remember or check on start that a container is over weight?