Printable View
Yes, just one needed, depending on what type of overlays one wants :) However, it should not hurt to have both loaded (but also not useful), but I think the alternative overlays have higher loadorder I think, so, one always has then the overlays of tahl_liadon :)Quote:
Originally Posted by DCrumb
Seems to be an incompatibility with the latest version of "Extended Automation and Overlays" (released today on the Forge). Any attempt to roll an attack against a target gets the following Lua error:
[ERROR] Script execution error: [string "scripts/manager_action_attack.lua"]:361: attempt to perform arithmetic on local 'nADVATK' (a nil value)
If I unload the "Advanced Effects" extension attacks work properly. I am suspecting the Extended Automation and Overlays is expecting some extra return data from some functions it overrides that maybe Advanced Effects also overrides? But that's just a guess on my part - I didn't look at the code yet.
Cheers,
Brian
EDIT: scratch what I wrote below. There's more changes needed than that to get the two extensions to coexist.Quote:
Originally Posted by MostTornBrain
I looked at it in a bit more detail. Seems the function "getEffectsByType_kel()" in manager_AE.lua needs a small update comparing it to the the getEffectByType() function in Kel's extension. A few function calls (checkConditional()) now has a couple extra arguments. I just merged those lines into a test copy of Advanced Effects and it appears to work -at least attacks no longer throw errors, but I haven't checked the numbers extensively for other potential breakages.
Cheers,
Brian
Ok, I got the two extensions to work together. There was a second function, hasEffect_kel() which now needed to return 2 values rather than one, and the calls to checkConditional needed to be updated similary to what was needed to be done for getEffectsByType_kel(). Comparing to Kel's implementation into manager_effects_35E.lua was what I used as a reference.Quote:
Originally Posted by MostTornBrain
Cheers,
Brian
Indeed, I need to update a couple extensions now that Kel has had a chance to push updates.Quote:
Originally Posted by MostTornBrain
I just updated my Extended Natural, Shield, and Armor AC Bonus Types Extension and hope to get to Advanced Effects tomorrow. Thanks for taking the time to report the issue!
+1 to this - seeing the same issue. Both of these extensions are SUPER handy.
To clarify, updating to the latest version in the Forge now resolves the issue.Quote:
Originally Posted by crossbow57
Cheers,
Brian
A relief to hear, thanks MostTornBrain! Forgot to update my post to say it had been fixed.Quote:
Originally Posted by MostTornBrain
Sorry to say that is NOT my experience. Just did an update and reloaded... still kicking the same error. :(Quote:
Originally Posted by MostTornBrain
To see if it would help, I disabled the extension in the Forge, then re-enabled it.
According to the load screen script it looks like I'm using version v1.7-hotfix 1 -- is that the latest?
Make sure you do not have a copy of this extension in the /extensions directory :) Bmos's extensions now load into the vault directory, but every copy of an extension in /extensions overwrites vault versions :) (and hence, preventing updates to be applied)Quote:
Originally Posted by crossbow57
And you know, Kelrugem - I just realized that I'm using your "Strain and Injury" version of the automation and overlays. Would that still cause this, I wonder? I'll run a test or two... but in case that's helpful, I love my strain/injury.
I believe this shouldn't matter, but who knows :DQuote:
Originally Posted by crossbow57
Did you check the /extensions folder as in my previous post? :) If yes, then the strainInjury code may indeed infringe with something (but let's hope that this is not the reason) :)
I'm in my extension folder - I see no entry there for "Advanced Effects" -
I see entries for "Full OverlayPackage.ext" (this one is not enabled when I load) and "StrainInjury with Full OverlayPackage with new icons.ext" (this one is enabled).
Oki, I now tested; I fully updated to get Bmos's latest version, and it works for me, I do not get the error :) Can you try to update again? (beware, forge updates won't turn the update button red :) ) Maybe even try to delete the versions of my extension and redownload them via the update button :)Quote:
Originally Posted by crossbow57
I also tested a few minutes ago and confirmed the two extensions are working together after getting updates today in my FGU install.
These are the reported versions on the console, in case that helps:
Advanced Effects - PFRPG and 3.5E v1.7-hotfix.1
Extended automation, dated at 10 January 2022, for 3.5E and PFRPG rulesets, v. 4.1.13
Ugh - No joy. Got a clean reinstall on your extensions. I even bounced back and forth between the standard overlays with strain/injury and the alternatives. It must be another conflict buried in there somewhere - I don't want to waste your time, but for whatever reason, still getting the error when Advanced Effects is loaded when an attack is rolled. I'll keep trying some combos.
in the worst case, if you only use extensions from the forge now, completely erase the /extensions folder and then update again :) (or maybe even /vault one, too; but then the download may take a while) Maybe the download didn't go wellQuote:
Originally Posted by crossbow57
And no worries, we are here to help :)
My method for testing is far from scientific, and I realize I am on the fringe, but seems like I've reached a good place.
Here's what I did: I loaded the Full Overlay/Automation extension - AS WELL AS the Strain/Injury automation package - even though you (Kel) have always said you don't need both... well... in this case, it seems to have made it work. All effects are added to the CT and calculating without error.
So, in case anyone else is down this rabbit hole... this worked for me. Now... no one breathe too hard. ;)
Long live the extensions! Thanks for the help.
Hmm, but you should actually not need both since both are literally the same (with the difference of the HP rules) :D And I tested it just with StrainInjury and Advanced Effects and it worked for me, even without Full OverlayPackage, so, there might still be something going on in your setup which is just not visible now anymore :D (especially this error points towards something which may also affect other things later on)Quote:
Originally Posted by crossbow57
(and I have a déja vu, I believe someone else did something similar and at some point we figured out what the problem was)
Do you maybe have also some unpacked extensions in the /extensions folder? Can you maybe send a screenshot of your /extensions folder? Then I can look :)
I just checked: It was actually you some months ago who had the problem with bugs when the Full OverlayPackage is not activated, too, and I am still puzzled about why this happens for you :D It may be that even a third extension plays into this problem. Certainly, if just advanced effects and StrainInjury is loaded you should not have any problem :) Also back then your problem was with respect to an error which pointed towards an older version like here, this is very strange :D
Besides a screenshot of your /extensions, can you also say/copy the messages of the extensions in the chat once you started your campaign? :)
(just if you have time and want to :) )
EDIT: But I am now going to bed, so, it may take a while until I can answer again :)
I was going to say... yep, that sounds like ME.
No doubt I'm a bit of a mess, having been a heavy extension user Pre-Forge. I attached a screen shot of the works (I think).
Harder to parse what is going on in the vault folder, of course.
Advanced Character Inventory Manager is now Advanced Item Actions on the forgeQuote:
Originally Posted by crossbow57
Expanded NPC weapons is on Forge also: https://forge.fantasygrounds.com/shop/items/210/view
Thank you very much :) As Bmos pointed out, you seemingly have some outdated versions, and since the forge ones (of Bmos) are now in the vault you have to delete the versions in /extensions :)Quote:
Originally Posted by crossbow57
The best may be:
1. Check if you already have all your extensions in the forge
2. If yes (so, all on forge), then wipe your /extensions folder
3. Then update via the FG launcher/updater
This should give you a clean install of all versions, and all the accidental overwritings of old versions should be cleaned :)
Just following up for anyone's morbid curiosity at this point - haha.
I had 49 entries in my extension folder before I pulled them all out. I did a full re-sync for all the active things in the Forge - pruned a few, etc. The new extension folder has 39 entries, so that sounds like good progress. I'll say the load time on the server is much faster, that's for certain. So - if I got nothing else out of this exercise, that's improvement, thank you.
Then I loaded the server with all the things, but chose just the Advanced Effects and Strain/Injury with alternate icons choices -- JUST THOSE TWO -- Turned ALL other extensions off. Annnnd... drum rolll.... STILL got the error!
At this point, I can only assume it is a curse.
Reloaded with all the things - enabled both the standard overlay/automation package as well as the strain/injury version... No Error! Amazing.
I can only assume that it has mutated and become somehow self-aware at this point, but it seems to work with all the things enabled - the next step would be a complete re-install of the whole thing? Not sure I want to go through all that just now. I'll keep experimenting - thank you all, seriously, for your advice and help.
hehe, thanks for testing :) It is an extremely strange issue and I have no idea what is going on :D (especially since I run my games with StrainInjury, too, and never faced this problem) Well, I hope this "curse" won't cause any other problem besides that you have to load the non-StrainInjury one for whatever reason, too :DQuote:
Originally Posted by crossbow57
Could you test again? Bmos just added some compatibility code to my extension :) It should not solve your issue, but this is just due to that there should be no error at all :D But who knows, maybe whatever is causing your issue actually got solved now, too :)Quote:
Originally Posted by crossbow57
Can you clarify that it is the exact same error message you're seeing, if the new updates don't fix it?Quote:
Originally Posted by crossbow57
I just re-read the thread and this seems to be the closest you have come to providing the exact issue ;)
A screenshot and steps to reproduce would be ideal.
Good Evening Gentlemen,
I'm also getting the error: nADVATK
I am running 4.1.13
completely deleted everything in /extensions and /vault.
Checked for updates.
Disabled all other extensions, both in Forge and in the game load screen: so I'm just running "StrainInjury with Full OverlayPackage" and "Advanced Effects"
Started a new campaign (PF 1E)
Loaded just the Bestiary 1.
Had an aboleth make an attack against an Aasimar and got the error:
"Script execution error: [string "scripts/manager_action_attack.lua"]:368: attempt to perform arithmetic on local 'nADVATK' (a nil value)"
Log Txt attached.
Let me know if I can provide any other info. Thank you for any help you can offer.
Aaah, Bmos, I might know where the incompatibility of crossbow and RobboNJ69 arises:
You probably have some if-clause checking for whether extended automation is loaded, isn't it? Does this if-clause also check for StrainInjury versions? If not, then this would explain, why crossbow was able to solve the problem by also loading the extended automation extension :) (and gladly the loadorder of StrainInjury is higher such that crossbow indeed found a pretty neat workaround :D)
Great point!Quote:
Originally Posted by Kelrugem
I installed the other version and it is working now. There doesn't appear to be any negative effects.
Thanks for your input and ideas!
Rob
Cool :) What do you mean with other version? Did I miss an update from Bmos? :)Quote:
Originally Posted by RobboNJ69
Yes, I was not completely sure whether I was right in my last post; because the last time I tested it myself, I was not able to reproduce it. Glad that it works for you now again :)
Following the older posts, in addition to:Quote:
Originally Posted by Kelrugem
"StrainInjury plus extended automation and overlays"
I installed:
"Feature: Extended automation and alternative overlays"
Now everything is working. I know they are essentially the same extension, but the error message came up, breaking attacks, when I only had the first one installed.
Rob
Very strange! Usually, there should be no need to install both extensions; so, maybe my previous assumption in my other post is correct :) Then I wonder why I cannot reproduce the error thoughQuote:
Originally Posted by RobboNJ69
Hi,
Any thoughts on supporting ability bonuses to be parsed from the "Advanced Effects" section of character sheet via a call to EffectManager35E.evalEffect()? Doing this, and then just replacing rEffect.sName with the result would expand the ability bonus into the numeric value in the combat tracker when the char is dragged over.
This is a rough proof-of-concept example with some debug comparing the original effect string vs. the parsed one at the end of updateCharEffect in manager_AE.lua:
Here's an example of a char sheet where using the above change I added two advanced effects that reference abilities - the Monk AC bonus (in this instance the monk is level 7 and gets a +1 and +[WIS]. The second effect example is Intimidating prowess, where the char's [STR] is added.Code:sendEffectAddedMessage(nodeEntry, rEffect, sLabel, nGMOnly, User.getUsername());
local sParsedEffect = EffectManager35E.evalEffect(nodeEntry,rEffect.sLabel, nil);
Debug.chat(rEffect.sLabel,sParsedEffect);
rEffect.sName = sParsedEffect;
EffectManager.addEffect("", "", nodeEntry, rEffect, false);
Attachment 52025
The resulting entries on the CT look like this:
Attachment 52026
Are there any downsides to doing this? I find it handy to have the ability score text reference in the defined effect on the char sheet so I can more easily remember where the number came from. Obviously, the numbers in the CT won't change if an ability changes in the middle of combat, but at least during downtime if you level up and an ability changes, it would be reflected the next time the char is dragged to the CT.
Cheers,
Brian
This is awesome! That is one of the improvements I have been wanting to make and hadn't looked into how it could be done :)Quote:
Originally Posted by MostTornBrain
If it turns out to not have any unexpected adverse side-effects, I think this might also help reduce the parsing effort on the CT side of things - at least minimally in some cases. For example, if I enter the contrived effect of "AC: 1+4+5+1" with this evalEffect() pre-parsing occurring, it gets put into the CT as "AC: 11". Not a huge difference, but every little bit helps. :-)Quote:
Originally Posted by bmos
Cheers,
Brian
Hello, I have loaded the extension 1.1.2, but when I equip an item with an effect I get the error "Handler error: [string "scripts/manager_affect_adnd.la"]510:attempt to call field 'getActorFromCT' (a nil value)"
What is the problem?.
Thank you.
v1.1.2 is from May 28th, 2020.Quote:
Originally Posted by alyxvr
Here is the latest.
https://forge.fantasygrounds.com/shop/items/33/view
Did this get implemented?Quote:
Originally Posted by bmos