Beta Release v3.3.7

I think this is going to have to be an iterative concept. I'm already spending too many cycles on the panel that I should be spending on FGU. Since there are no APIs to do that, it would require implementing and documenting even more APIs. I even thought about making the chat a floating window instead; but I'm worried about whether the current FG client would have crashes since there are many places in the FG code that reference chat window and chat entry, plus ongoing chat log storage in the control itself. As I was saying, the whole chat window usage needs to be reviewed and redone. Unfortunately, this will have to be an effort for another revision.

Cheers,
JPG

Quote:

---

Originally Posted by Moon Wizard

I think this is going to have to be an iterative concept. I'm already spending too many cycles on the panel that I should be spending on FGU. Since there are no APIs to do that, it would require implementing and documenting even more APIs. I even thought about making the chat a floating window instead; but I'm worried about whether the current FG client would have crashes since there are many places in the FG code that reference chat window and chat entry, plus ongoing chat log storage in the control itself. As I was saying, the whole chat window usage needs to be reviewed and redone. Unfortunately, this will have to be an effort for another revision.

---

All good!

Quote:

---

Originally Posted by Moon Wizard

Updates

• [CoreRPG+] Modifier stack, character list and dice tower panels moved above full background image panel.
• [DEV] Panel order not maintained when using merge attribute. Fixed.

---

Whatever this did, it broke my panel ordering.

I redefine the panels such that they render over previously defined panels. This change seems to lock some predefined ordering such that even if I redefine the panels, they're rendered at their predefined older order so my custom assets are always rendering over it..

To clarify, redefine implies replacing such that <panel name="chat"> .... </panel> has no merge attribute. I would redefine for instance, "chat" after a desktop spanning panel, and this would cause the chat window to be rendered atop my custom spanning panel.

This update broke my ordering such that chat and modifier stack, even when redefined are stuck behind my custom panel as they use their predefined order.

I literally can't interact with any of my UI elements because of this.

The panel ordering is preserved when the merge attribute is used. It you don't use the merge attribute or delete first, then you will override the ordering, and your new panel will be placed at the end of the definition order.

This is how it should have been done in the first place, but wasn't. Unfortunately, all the panel updates lately brought to light that the behavior was non-deterministic across multiple rulesets and extensions as they used the merge attribute.

Regards,
JPG

Quote:

---

Originally Posted by Moon Wizard

The panel ordering is preserved when the merge attribute is used. It you don't use the merge attribute or delete first, then you will override the ordering

---

That's not the observed behavior though. I don't use merge attributes in my panels, they're all straight redefines, so they should be placed at the end of the definition order. You can make a test extension with a spanning panel followed by a redefined chat panel and see which renders first. If the spanning panel, you won't even see the chat one. This has been my observation.

The only time I've used the merge attributes is to circumvent this specific change to delete the defaults and create new panels of duplicate behaviors, but named differently. This came at the cost of ruleset and extension-wide changes which isn't desirable.

MW, there is some documentation missing from the dataLibrary.lua file. I recommend adding something like the following following the comment line that says "RECORD TYPE LEGEND":
-- sEditMode: [optional]set this to "play" if you want both GMs and players to be able to edit the record (local mode users won't be able to edit). Set it to "none" if you want no edit ability.
-- aGMEditButtons: [optional]This is a list of templates that you can add if you want additional buttons when the record list is in edit mode.
-- sExportPath: [optional]Set this if you want exports going to some place that is not conventional. (I'm not sure what this relative path goes to, but I think it is the FantasyGrounds data path)

Also, the bAllowClientEditMode which is documented doesn't appear to do anything (maybe was deprecated when sEditMode was added?)

On 3.3.7 Clicking on the sound icon from DOE sound open a blank window. Returning on the 3.3.6, it works like a charm. I will stay on 3.3.6 as the DOE sound is mandatory for me.

Quote:

---

Originally Posted by Bunnyhunt3r

On 3.3.7 Clicking on the sound icon from DOE sound open a blank window. Returning on the 3.3.6, it works like a charm. I will stay on 3.3.6 as the DOE sound is mandatory for me.

---

Please report this to Dulux Oz in his DOE Sound thread - so he’s aware of potential issues with his extensions and v3.3.7.

Ok, i will,
thanks

Updates

• [DEV] Adjustments to panel merging.

Bidmaron, I updated the notes in LibraryData just now.

Regards,
JPG

Updates

• [CoreRPG+] Moved modifier box and dice tower back under full background image panel to match chat window.

Note: While there is a lot of expressed interest in having a full background image panel with chat/modifier stack/dice tower over the top, the original intent of the full panel is for at table play. Also, to create a good implementation for online play will require more time than is available for this release (Dec. 18).

Regards,
JPG

Updates

• URL links were no longer working from hot key bar. Fixed.

Quote:

---

Originally Posted by Moon Wizard

Strange, I can not seem to produce the crash issue on the latest version of the client in the Test channel, though I know this was an issue a couple revisions ago. Can you try running an Update to get the latest client and try again? If still an issue, can you be very specific on steps you found to reproduce?

---

Changed back to live, deleted all my rulesets, changed back to Test and re-downloaded them all. Created a new DnD campaign, no extensions, shared a map. Shared the map again without changing to panels and had no problem. Changed the player's map to Panel, shared that same map again and player's client crashed.
Video: https://youtu.be/4AJVl_mw7ZU

Quote:

---

Originally Posted by Moon Wizard

While I'm sure that more savvy users such as yourself would have no problem getting around the fact the chat window, modifier stack, dice tower and sidebar obscure parts of the image, I'm worried about users who are not as familiar with Fantasy Grounds being confused and unable to access those parts of the image at all. Let me think on it a bit, and talk with Doug a bit as well.

---

Completely agree, but I can tell that this would be a very popular feature. But honestly, if that can be added later using an extension for us savvy users I would really appreciate. Or even having a setting in options "Show Chat on Fullscreen Panel", but having it off by default in the future, would be great.

Quote:

---

Originally Posted by Moon Wizard

Also, thanks for the catch on the Cypher rulesets. I set them up wrong in the update system.

---

Glad to be of service.

Now I just noticed that the panel isn't anchored to the chat anymore, instead it's in a fixed position. Not sure if it's a bug, but it does look horrible on Savage Worlds, since the chat will overlap part of it https://i.imgur.com/M4jFpCI.jpg and not being able to resize how much of the screen you want the panel to use (I would want to fit my CT that's larger than the chat, for example).

Anyway, thanks a lot for the effort on this panel feature, I love it.

Edit: Not sure if this is tied to the problem mentioned above, just tried attacking on Savage Worlds while using panels and it crashed. I might have a friend test it too and report if he also gets the same crashes when hosting, but he sure did when he was connected on my server. Not trying to be repetitive, just mentioning that both crash problems are still present.

Ok, I can't recreate the player client crash you've shown, which is concerning. Can anyone else recreate? (i.e. While the player client has a previously shared image window, they send to background panel. Next, the GM re-shares the map via the radial menu.)

Dr0W, can you double-check the version reported on the front screen of the FG launcher? Then, delete the FG client program (FantasyGrounds.exe); and run FantasyGroundsUpdater.exe to let it download a new one. (v3.3.6 and the original builds of v3.3.7 had a similar issue that was fixed.)

The initial background panel is deliberately not anchored to the chat window any more, because the chat window can be moved. Thus, anchoring to the right edge of the chat window is problematic as long as the chat window is movable. So, it's fixed to the default chat window edge, which will need to be adjusted for Savage Worlds. It's one of the reasons why I'm concerned about the chat window floating over the map in the first place in a pre-locked condition. As per the discussion with damned, the chat window is something that will need a redesign to accommodate a larger panel.

Thanks,
JPG

I'm unable to recreate the issue either. I've tested on a number of different maps and with the DM and players screens of the same and different monitors and with and without the 5e theme and I don't see anything.

I can confirm that at the launcher was showing 3.3.7.
Deleted FantasyGrounds.exe and let it download again, still crashes.

I'll have a friend who experienced same crash to try it while he is hosting and will come back to you later.

Also, I must say that once I was the only one having a bug on the SavageWorlds ruleset, that neither Ikael or anybody else could reproduce. This bug showed up from time to time, and uninstalling FG and deleting everything wouldn't fix it. I would either go on a full format, or download a registry cleaner and clean my computer's registry from anything FG related, that was the only way to fix it (until it showed up a few months later).
This bug stopped happening for over a year now, but I do find it possible that I am the only one with those crashes right now.

Edit: My friend just tried, had the very same crash. I had him follow the very same steps, and he crashed on his own computer acting as both, host and client.
Then I asked him to host for me, told him to share map and got a crash once again. So it's crashing for both of us, both ways. Video: https://youtu.be/Dy5M2uN7y7c
We also tried using just CoreRPG, same crash.

I made the same thing (new install whitout traces of the FG), and the crash occur in various rulesets (official and fan made) the test was made in local network and connected with a person in another location, none of the extensions on the list was loaded.
1 - The DM opens a map and share
2 - The Player change the map to panel mode
3 - The DM share the same map

BOOM! Fantasy Grounds in player side Crash!

Thanks, guys. I was also reviewing the code as well, and I see an area where the original logic may be problematic for the new panel implementation. I'll try to get something early next week for you guys to try.

Thanks,
JPG

Updates

• [CoreRPG+] Toggling carried status of container did not update carried status of contained item if location field did not match letter cases. Fixed.
• [DEV][CoreRPG+] Added support for "notes" field in simple reference list window ("reference_list" class).

Quote:

---

Originally Posted by Moon Wizard

Updates List (Updated 12/7)

• [PFRPG/3.5E] Immunity effect change: For basic damage type immunity, only applied if immune to all basic damage types; for attribute damage type immunity (critical, precision, lawful, etc.), always applied.

---

I am a bit confused about that point :) What exactly does this change? Is it not like usual? :) Thanks in advance :)

And thanks for adding the class features for 3.5e :)

That last one is a most excellent add, MW! Thanks.

Quote:

---

Originally Posted by Bunnyhunt3r

On 3.3.7 Clicking on the sound icon from DOE sound open a blank window. Returning on the 3.3.6, it works like a charm. I will stay on 3.3.6 as the DOE sound is mandatory for me.

---

For the record: this issue has been resolved (in all the DOE's) and will be available upon release of FGv3.3.7 live.

I could use some extra eyes on this latest change to make sure everything is still working. If you have a few minutes, just pop FG open and run through a couple typical usage scenarios in your campaign.

Updates

• [CoreRPG+] Client changes to address potential crash conditions for new image panels.

Thanks,
JPG

I've played some minutes now with that and I got no crashes so far :) Thanks for the fix :) But I realized that the "Client Synch View" only works when the players and the GM do not use any of the two new background options :) Is this intended?

Dr0W / yako2020,
Can you guys run a new Update, and give the image panel sharing another try?

Kelrugem,
The thread below covers the issue. It's a bit detailed. In practice, the majority of people won't notice any change.
https://www.fantasygrounds.com/forum...603#post398603

Regards,
JPG

I just noticed that the Synch Client View option wasn't working in the new panels yesterday, but I'm not sure it's going to be fixed before release.

In fact, I'm not sure how it will be addressed, since synching the view across 3 different possible windows was not something that existed when the client view synch/lock was implemented. Given the minimal use of this feature, it might be easier to remove synching completely.

Regards,
JPG

Thanks for both your answers :) I will look at this thread and I understand the issue with synching :) I personally do not have any problem with whether synching is possible or not :)

Quote:

---

Originally Posted by Moon Wizard

I just noticed that the Synch Client View option wasn't working in the new panels yesterday, but I'm not sure it's going to be fixed before release.

In fact, I'm not sure how it will be addressed, since synching the view across 3 different possible windows was not something that existed when the client view synch/lock was implemented. Given the minimal use of this feature, it might be easier to remove synching completely.

Regards,
JPG

---

I do like Synch Client View - just putting in my 2c worth...

Quote:

---

Originally Posted by Moon Wizard

I just noticed that the Synch Client View option wasn't working in the new panels yesterday, but I'm not sure it's going to be fixed before release.

In fact, I'm not sure how it will be addressed, since synching the view across 3 different possible windows was not something that existed when the client view synch/lock was implemented. Given the minimal use of this feature, it might be easier to remove synching completely.

---

I think I used the view sync once and that was probably it. It's a neat feature but I've had no use for it.

Updates

• [3.5E] Removed duplicate class feature text from SRD Basic Rules module.

Updates

• [DEV] windowinstance: In createControl function, added third parameter to specify data source path.

Bey nice, MW. thanks!

Updates

• [DEV] Interface.onWindowClosed handlers being called after windows unlinked from database nodes. Fixed.

@Moon Wizard, I can confirm that the crash is no longer present. Re-sharing images on panel mode won't crash anymore, thanks a lot! I will continue to look for bugs.

However, this one is still present: https://youtu.be/qzFMriT0CPU
Seems to be a Savage Worlds only crash

Hmm, first I've heard of that one, and more challenging too, since I'm not familiar with SW attack implementation. Might need Aki's help...

* Do you also get the crash when doing attack rolls on tokens in the image panel in 5E as well, or only on Savage Worlds? (This will help me narrow down where to look.)

Thanks,
JPG

It does not happen on D&D, everything is working fine there. It I've only tried D&D and SW and it only happens on SW so far.

A few more info to help:
-If a player or GM is using their map as a window, it does not crash. Everything works fine.
-If a player is using the map as a panel, if they try to attack anything their client crashes. It does not matter if the attack was done by dropping dice on tokens, on CT or just by targeting and d-clicking the attack button. The attack does not happen at all, the GM doesn't get an entry for the attack it seems as if nothing happened at all. Only the player client crashes.
-If it is the GM doing that, same thing happens and only the GM crashes.

If a GM or Player instead of attacking deals DAMAGE directly, it does not crash. An entry for the damage is made normally and works flawlessly. The problem seems to be with the attack only.

Quote:

---

Originally Posted by Dr0W

It does not happen on D&D, everything is working fine there. It I've only tried D&D and SW and it only happens on SW so far.

A few more info to help:
-If a player or GM is using their map as a window, it does not crash. Everything works fine.
-If a player is using the map as a panel, if they try to attack anything their client crashes. It does not matter if the attack was done by dropping dice on tokens, on CT or just by targeting and d-clicking the attack button. The attack does not happen at all, the GM doesn't get an entry for the attack it seems as if nothing happened at all. Only the player client crashes.
-If it is the GM doing that, same thing happens and only the GM crashes.

If a GM or Player instead of attacking deals DAMAGE directly, it does not crash. An entry for the damage is made normally and works flawlessly. The problem seems to be with the attack only.

---

Dr0W and MoonWizard, I have not been able to reproduce the issue in SavageWorlds ruleset. I have been using Fantasy Grounds Test version as client for many weeks already and always used panel feature. My client has never crashed and I have been slaying and whacking alot of things during the time.

I've just tested it with the help of Ikael and Bruno_2020.

With Ikael it worked fine. He attacked using Panels and it went well.

With Bruno_2020 he got a crash. When he attacked, the dice did roll but nothing else happened. The attack entry wasn't added to the CT and he disconnected.

If I may add, it might not be related at all but it's worth to be mentioned: Me and Bruno_2020 are both from Brazil, and we're both using Windows 7 64-bit, and our system language is set to brazilian portuguese. Other than that, I can't see any other similarities between us.

If it's like the other issue, it's because a pointer gets deleted before scripting is finished; and it wasn't an issue previously because the system is being used in new ways. For some reason, everyone in the US doesn't have an issue, but Dr0W and other Brazilian users are. Probably something different about the Windows builds, and how they behave.

At any rate, I need to figure out how to pinpoint which script call is causing the issue. That's why I said I might need Aki's help to understand the script workflow for Savage Worlds attack rolls...

Thanks,
JPG