Printable View
The onChildDelete issue? It was because I did this:Quote:
Originally Posted by Bidmaron
DB.addHandler("charsheet.*.inventorylist.*", "onChildDeleted", updateFromDeletedInventory);
instead of this:
DB.addHandler("charsheet.*.inventorylist", "onChildDeleted", updateFromDeletedInventory);
Note the removed .* on the end of .inventorylist.
This is not going to look good on your annual review...Quote:
Originally Posted by celestian
Thanks, Celestian. You have done some great work on this, and it almost makes me wish I played 5e.
hah, I've been tempted to play 5e myself mainly cause of all the content and then I wouldn't need to write these things but then it's part of the fun.Quote:
Originally Posted by Bidmaron
It's sourced from my AD&D ruleset, to bad you don't play that either ;)
Yeah, I am a PF guy. I think WotC hit the ideal balance with 3.5, and I turned to PF when Wizards went to that awful 4th edition.
I used to play AD&D many years ago.
Tis true ;)Quote:
Originally Posted by LordEntrails
I pickup new things like this daily. I'm envious of the guys that have been doing this for years and know all this stuff ;)
Did this extension get broken with the latest patch? My PLAYER advanced effects no longer seem to be getting added to the Combat Tracker when adding the player to the tracker (not visible in the Combat Tracker as an effect on the character) nor are they applying when damage is done to the player. Thnx
EDIT - perhaps nevermind? The effects I was trying to add were Jack of all Trades and racial Resists. The effects code works just fine as a Action Power, but the same syntax will not work in the Advanced Effects area of the Abilities tab. After reading some more of this thread I am taking it those type of effects have to be manually applied? If this is correct please just ignore this post. Thnx again celestian
Racial resistances should work fine with this extension I think (RESIST: <damagetype> should work. For Jack of All trades it depends on how you are creating the effect.
It should function as expected under 3.3.6. I ran various tests myself. However if you do find a problem do let me know.Quote:
Originally Posted by Kibri_Oakbright
Zacchaeus is correct, resists should work. I am unfamiliar with "Jack of all Trades" tho so can't be sure until I see what the effect is.Quote:
Originally Posted by Zacchaeus
How would you enact a Belt of Ogre Strength, an item that sets your STR to 19. Do you have to put it in as a modifier to the users STR, which means you have to customise it for each character?
Yes, since there isn’t a way for Fantasy Grounds to calculate the difference. So if the character has currently 15 strength then it would be STR: 4 if it was 11 it would be STR: 8.Quote:
Originally Posted by flynnkd
The Savage Worlds ruleset allows you to set an attribute as well as modify it, so perhaps one day the 5e ruleset can be updated to do so as well.
AD&D Core does as well so it is possible. I imagine at some point they will add some type of support for it for 5e though.Quote:
Originally Posted by Nyghtmare
I still cant get this extension to work. Have tried something simple like RESIST: lightning which shows as [RESIST: lightning] visibility [show] under advanced effects on the character sheet. Added the character to CT still no effect visible nor is it applying the effects. Removed character from CT, closed character sheet. Re-added character to CT and still same result. Tried the effect on 4 other character sheets in same campaign and same result, none of them working.
Any known issues with other extensions causing the problem? I will try to start a new campaign and see if it works without other extensions but thought I would ask first.
EDIT:
OK, so I created a new campaign and new character sheet and the extension seems to work there. I will go one by one adding other extensions and see if one of the other extensions is causing the failure, or if for some reason the character sheets in my main campaign are "bugged" somehow and just not working with this extension. Will try to keep updated on what I find out. THNX
More than likely it's another extension causing this problem. They are stomping over each other trying to do similar tasks with the same functions.Quote:
Originally Posted by Kibri_Oakbright
I can't guess which one but anything that works with effects or combat tracker would be a good start.
Well I figured it out and it is rather silly actually. I seemed to have an older version of your? effects EXT, called Item Enhancements, installed as well as your Advanced Effects. Seems when running both they were canceling each other out. HAHAHA. Anyway, just a heads up for anyone that might have the older Item Enhancement EXT it will indeed conflict with Advanced Effects. My bad but glad i figured it out. Thnx again everyone for your help and patience with a newer FG user.
Tonight, during a class in FGC, we noticed some behavior with Advanced Effects turned on. In the damage section for weapons, the 'Multiplier' field lost its functionality, regardless of the Stat being used (abilities, level, prof, etc.). The Multiplier worked for Spells (damage or heal) but not weapons. When the table was re-opened with the only change being the disabling of the extension, the multiplier began working again.
Attached is a sample for a level 1 PC. The 2x multipler (times Level) resolves to +2 for spells, but not for weapons.
Not sure if this was an operator error, but it was reproduceable on multiple tables.
I'll have to dig into it and see whats up. I'm not familiar with this in 5e. Thanks for the bug report. I certainly can see the same behavior.Quote:
Originally Posted by Rumtintin
Sounds good - certainly an 'edge case,' but we happened to stumble upon it so I figured I'd pass it along. Big fan of the extension.
Actually this was easier than I thought. Try this version and tell me if it works for you. My testing showed it did. If it does I'll update the first post with it as "3.1".Quote:
Originally Posted by celestian
edit: removed attachment
Boom - that did it, works like a charm, nice job!Quote:
Originally Posted by celestian
Update 3.1
* bugfix: issues with multipliers and weapon damage corrected.
(see first post for download)
Just wanted to say this is great work! Now adamantine armor actually works like it's supposed to.
How did you achieve this since I know of no effect either with or without the extension that turns critical hits into non critical ones?Quote:
Originally Posted by AlchemicalAgent
If I remember right, you can use "IMMUNE: critical" effect to ignore critical damage, which essentially treats critical hits as normal hits in the long run.
Regards,
JPG
Quote:
Originally Posted by Zacchaeus
Yes, that's exactly how I did it. The player also has heavy armor master so I just made these two effects that are applied when he wears it.Quote:
Originally Posted by Moon Wizard
Adamantine Plate Armor;IMMUNE: critical;
Adamantine Plate Armor;RESIST: 3 slashing,bludgeoning,piercing,!magic
Yes, yes, of course :)Quote:
Originally Posted by Moon Wizard
OK - 2 Questions for you guys!
Is it possible to set something up that only happens on a Nat 1? Similar to like "IF: critical;" - is there an "IF: automatic miss;" or anything similar?
Would it be possible to set it up so, on a critical, it does damage, and also heals the wielder of the weapon with said effect on it?
Nope, to both i’m afraid.
The healing bit can be done by negating the damage (right click on the result in cha and select +/- and drag the result onto the character that gets the heal.
It seems like there must be some way to detect a natural 1 on to hit rolls because the built in fumble table works when we roll a natural 1.
Yes, and you can trigger the fumble table with it. But the only effect that can detect a natural 1 is 'reroll', and that just rerolls, you can't have a natural 1 trigger something else (without writing an extension).Quote:
Originally Posted by esmdev
Now we need an extension writing wizard to fly in and say "Oh, that would be easy to do" and have it already attached to the reply! lol *fingers crossed*Quote:
Originally Posted by LordEntrails
I'm using this extension and in my first real game on FG yesterday I encountered a problem. Not a problem per se but maybe a suggestion?
The party came across a roadblock and wanted to investigate. 2 people went ahead and started looking around. One found something hiding in the bushes. I used the little button on the encounter page to add them to the CT and create their pre-placed tokens. When I did that, there were 4 chat messages saying "Goblin added" or something. Those messages revealed to the party that there were 4 Goblins in the encounter. I was only going to reveal one of the Tokens and go from there and maybe the others would be a surprise.
Is this normal behavior? What can I do to prevent this?
Edit: Added screenshot Attachment 25407
I would remove the effects that do nothing (that blank message seems to imply that there are effects on those npcs w/o any text).Quote:
Originally Posted by HuseyinCinar
You can also "hide" effects from PCs so that they don't see that. Check the options for visibility for each effect configuration.
I fear you worry over nothing. Although in the DM chat it shows that Goblins have been added with an effect. The players will have been completely oblivious to this since nothing would have shown on their chat.
I am not familiar with his theme so couldn't tell if that was DM only chat. I assumed he had a client connected that said they could see it.Quote:
Originally Posted by Zacchaeus
Judging by the CT that is the DM view. But in any case the players will never see what is being added to the CT. Players are not aware of NPCs on the CT or on the map until they are made visible by the DM. Furthermore effects which are applied to a creature such as resistances etc are not broadcast to the players either. So even if the Goblins above had an actual effect or not would be immaterial as far as the players are concerned. Once the NPCs are made visible then there is a message sent to the client to say that it is the NPCs turn - but even then effects applied to the NPC don't get broadcast.Quote:
Originally Posted by celestian
I wrote my own add/remove messages to output specific values (so you could see what item applied/etc). So unless you set the effect "hide" it will show... unless it's an item an unidentified I think.Quote:
Originally Posted by Zacchaeus
I might go back and see about adding in a default to hiding npcs effects dropped into the CT since they initially are invisible anyway.
Here is the option you need to set. This option works across npc, pcs and items.
https://i.imgur.com/hxlpjt7.png
I agreed that unhidden effects on an NPC will be visible on the client side CT; but my point was that this fact isn't broadcast in chat which was I think what the OP was concerned about. Even with effects not hidden nothing will show up on the chat as far as effects on an NPC is concerned; not even effects which the PCs might have applied.
But it does broadcast in chat unless it's hidden. That's what I was saying. I use the CoreRPG add effect but I don't use it's text output for the reasons previously mentioned.Quote:
Originally Posted by Zacchaeus