I've address most of that with the latest pushes. Have you updated recently?
Printable View
I've address most of that with the latest pushes. Have you updated recently?
Can you edit your post a bit more as to what is not working and remove the things that are working from the update?
2) I tested this with artist and seems to be working fine, Can you give me an example occupation to test this with that you are seeing it in.
3) will be fixed with next update
4) This is intended behavior moving forward till I can find a better solution in the code for how they handled it
5) It was intended that skills would be updated as occupation skills through the profession record. I just shored up that behavior
6) See 4. They are intended as default skills moving forward
7) See 3
Just downloaded the update and re-tested on a new campaign:
2 - both Entertainer & Author from the Investigator Handbook; the art/craft line is not inserted.
For more clarity, all the skills written in the occupation code like the example below are not inserted:
<id-001>
<skill type="string">Art/Craft (Acting)</skill>
</id-001>
Lua line extracted from a copy of the Entertainer entry of the Investigator Handbook.
3 - "Lang -Own" is no more NULL but is calculated on 1/2 INT instead of 1xINT.
4 to 7: ok, I can understand the change but at the moment the lack of possibility to manually edit the list is quite a problem: take the example of the art\craft line missing, I can easily solve it by adding it to the list and then mark it as occupational, but atm the only way I can do that is by manually edit the db.xml.
IMHO is better to leave the list editable, at least to the Keeper.
EDIT: tried to post this 3 time this morning (Italy time zone) but all three post have been lost, this one worked flawlessly. This happened with my last post too, there's some kind of time restraint on posting or somenthing like that?
First please stop sending multiples of the same report. They are being flagged for moderation and you may not be seeing them show. I am able to see all the previous posts. It's flooding the forum.
2) I've updated the professions in the core rulebook to no longer use the parenthesis and use the sublabel in the skill to work cleanly with the system. For custom professions, using the parenthesis is not possible and thusly I went to a unified system. If any other modules have this I will be happy to update them. Just let me know which modules need updating.
Attachment 66282
3) The recent update I just made will address this.
4 to 7) The list hasn't changed in function to what it was before I did a clean up. The list sets default skills from the eras and ensures these can't be deleted by mistake or on purpose. If a skill is added by an occupation, you can delete it from the link of the occupation from the character sheet. This is where you are able to adjust those skills. If you delete the skill from that list it will delete it from the character sheet. In any case, the GM is able to delete default skills from the sheet as requested with this update.
First, sorry for the multiple post, but I was under the impression of something not working on my side because the first post didn't appear for a whole day, at that point I tried repost it, and it appear immediatly. So I've assumed that the correct beahavior was the second one, while the not appearing was an error. Sorry, not an expert on forums, I usually avoid them like the plague ;)
2 - Ok, tested with base occupations and the skill get inserted, but Lang - Own (Author occupation) or Fighting Brawl (Soldier occupation) doesn't get updated as occupational skills. The Investigators Handbook needs to be updated, I was testing everything with those occupations.
3 - yep, fixed. Thanks.
4 - Ok, followed your instruction and it actually updates the occupational check (with the exception of Lang - Own and Fighting Brawl). If you change a sublabel the old one remain in the list , but with the delete enabled it takes a millisecond to fix. Thanks.
Sorry, just noticed another problem: usually if an occupation has Lang - Own as on occupational skills the occupation have 9 skill entry and not 8, example: the author occupation of the base manual is missing a free choice skill.
EDIT: forgot to add that is fixable by adding the skill in the profession selection tab, so is a very low priority fix, but can be misleading if you don't pay close attention to it.
No worries about the extra posts, just wanted to let you know the system was to blame on this one.
I'm still working on the Lang Own / Fighting Brawl issue of making it an occupation skill. But glad the others are working. I'll need a bit of time to sort that one.
Sorry, it's me again.
Was doing some test to align my translation extension to the changes and stumbled on a oversight in line 42 of char_skill.lua:
local bBrawl = DB.getValue(nodeSkill, "label", "") == "Fighting" and DB.getValue(nodeSkill, "sublabel", "") == "Brawl";
Not an urgent fix, since it probably affects only me ;)
Pushed to using the Interface.getString function call instead.