Better Combat Effects

Awesome peoples. Thanks for the update Mattekure.

Version Update 2.25
fixed: Issue with Source tags not properly resolving
fixed: Error with Automatic Save Adv

[QUOTE=nephranka;633366]

Quote:

---

Originally Posted by BlazingAzureCrow

Kent McCullough & Rob Twohy's Automatic Save Advantage is having a conflict with this extension. When both are on, "SAVEE" effects won't roll. Tested in a campaign with only them on. The dice doesn't roll, and the error returned when it tries to roll it is

"[Script execution error: [string "scripts/manager_action_save_asa.lua"]:79:attempt to index local 'sourceNode' (a nil value)"/QUOTE]

I can confirm this error. Not sure when it broke.

---

I looked at this and I'm going to say it is working as intended. Yes it does add 1 rnd to TRUNRS to get around the auto decrement initiative. I know at one point someone had a request for a effect that ended at the end of their turn, the same turn it was applied. The bottom line to remember is it will get removed when the tag fires at 1 rnd duration.

Quote:

---

Originally Posted by elfmage

Hi rhagelstrom,

Thanks for looking into this. The new build seems to work more favorably - thanks.

Just as a heads up based on my testing you seem to add a round on application of the effect for TURNRS to work around the CT removing a round from the effect at the start of a round. TURNRE, STURNRS & STURNRE do not apply this extra round in the same way to work around this. I tested this for [TARGET] & [SELF] on the 4 effects. Just wanted to point this out in case your intention was to apply this for all custom your effects.

Either way, I can easily work around this issue by making the duration 2 vs 1 rd.

---

Thank you!

Quote:

---

Originally Posted by rhagelstrom

I looked at this and I'm going to say it is working as intended. Yes it does add 1 rnd to TRUNRS to get around the auto decrement initiative. I know at one point someone had a request for a effect that ended at the end of their turn, the same turn it was applied. The bottom line to remember is it will get removed when the tag fires at 1 rnd duration.

---

Sure thing, I only pointed it out due to the inconsistency someone may be confused due to it.

Thanks for looking at/fixing the other stuff though, much appreciated.

Trying to use the DMGR: effect in 5e for interception.

The effect itself works fine, only issue I've encountered is that it seems to be ignoring the `Expend on next Roll/Action`, so it's staying on the target as if it was set to `Expend: Never`

---

Ignore me, I was using the effect completely wrong, applying it to the one dealing the damage instead of the target of the hit

[QUOTE=rhagelstrom;633431]Version Update 2.25
fixed: Issue with Source tags not properly resolving
fixed: Error with Automatic Save Adv

Thank you so much~!

Quote:

---

Originally Posted by Svandal

There is a problem with the new version of this extension with the "SAVEDMG" effect.
A couple of days ago this effect worked as intended, but in this version it does not work anymore.
It is this effect:
Acidic Spray; SAVES: reflex 23 (R); SAVEDMG: 7d6, acid

Problem 1:
It does roll the save, but it does not remove the effect on a successfull save

Problem 2:
If the save is a failure it does not get any damage (and no damage dice gets rolled either)

Edit:
Pathfinder 1 ruleset
No other extensions loaded

---

This is still a problem in this version of this extension.
I have tried this effect in 5e, and it works.
Acidic Spray; SAVES: DEX 23 (R); SAVEDMG: 7d6, acid

But for pathfinder ruleset it does not work, something in version 2.24 broke the SAVE effects for pathfinder 1st ruleset.

Quote:

---

Originally Posted by Svandal

This is still a problem in this version of this extension.
I have tried this effect in 5e, and it works.
Acidic Spray; SAVES: DEX 23 (R); SAVEDMG: 7d6, acid

But for pathfinder ruleset it does not work, something in version 2.24 broke the SAVE effects for pathfinder 1st ruleset.

---

Can you send me a sample campaign and I'll take look. It's a little hard for me since I don't have any of the source books to test a lot of normal things

Version Update 2.26

Feature - Conditions are now searched first and then the custom effects list when using tags such as SAVEADD
Fixed - The SAVEADD family (SAVEADD, SAVEADDP), all effects with these tags on an actor would process on a failed save, success in SAVEADDP case. These are now bound the the effect if a BCE tag that makes an ongoing save proceeds it.
Fixed - DMGRT was not being removed on damage